diff mbox series

remoteproc: sysmon: fix shutdown_acked state

Message ID 20201204193740.3162065-1-arnd@kernel.org (mailing list archive)
State Accepted
Commit 9d7b4a40387d0f91512a74caed6654ffa23d5ce4
Headers show
Series remoteproc: sysmon: fix shutdown_acked state | expand

Commit Message

Arnd Bergmann Dec. 4, 2020, 7:37 p.m. UTC 
From: Arnd Bergmann <arnd@arndb.de>

The latest version of sysmon_stop() starts by initializing
the sysmon->shutdown_acked variable, but then overwrites it
with an uninitialized variable later:

drivers/remoteproc/qcom_sysmon.c:551:11: error: variable 'acked' is used uninitialized whenever 'if' condition is false [-Werror,-Wsometimes-uninitialized]
        else if (sysmon->ept)
                 ^~~~~~~~~~~
drivers/remoteproc/qcom_sysmon.c:554:27: note: uninitialized use occurs here
        sysmon->shutdown_acked = acked;
                                 ^~~~~

Remove the local 'acked' variable again and set the state directly.

Fixes: 5c212aaf5457 ("remoteproc: sysmon: Expose the shutdown result")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
 drivers/remoteproc/qcom_sysmon.c | 7 ++-----
 1 file changed, 2 insertions(+), 5 deletions(-)

Comments

patchwork-bot+linux-remoteproc@kernel.org Dec. 7, 2020, 8:10 p.m. UTC | #1 
Hello:

This patch was applied to andersson/remoteproc.git (refs/heads/for-next):

On Fri,  4 Dec 2020 20:37:35 +0100 you wrote:
> From: Arnd Bergmann <arnd@arndb.de>
> 
> The latest version of sysmon_stop() starts by initializing
> the sysmon->shutdown_acked variable, but then overwrites it
> with an uninitialized variable later:
> 
> drivers/remoteproc/qcom_sysmon.c:551:11: error: variable 'acked' is used uninitialized whenever 'if' condition is false [-Werror,-Wsometimes-uninitialized]
>         else if (sysmon->ept)
>                  ^~~~~~~~~~~
> drivers/remoteproc/qcom_sysmon.c:554:27: note: uninitialized use occurs here
>         sysmon->shutdown_acked = acked;
>                                  ^~~~~
> 
> [...]

Here is the summary with links:
  - remoteproc: sysmon: fix shutdown_acked state
    https://git.kernel.org/andersson/remoteproc/c/9d7b4a40387d

You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
diff mbox series

Patch

diff --git a/drivers/remoteproc/qcom_sysmon.c b/drivers/remoteproc/qcom_sysmon.c
index d01bc4bda7bf..9fca81492863 100644
--- a/drivers/remoteproc/qcom_sysmon.c
+++ b/drivers/remoteproc/qcom_sysmon.c
@@ -533,7 +533,6 @@  static void sysmon_stop(struct rproc_subdev *subdev, bool crashed)
 		.subsys_name = sysmon->name,
 		.ssr_event = SSCTL_SSR_EVENT_BEFORE_SHUTDOWN
 	};
-	bool acked;
 
 	sysmon->shutdown_acked = false;
 
@@ -547,11 +546,9 @@  static void sysmon_stop(struct rproc_subdev *subdev, bool crashed)
 		return;
 
 	if (sysmon->ssctl_version)
-		acked = ssctl_request_shutdown(sysmon);
+		sysmon->shutdown_acked = ssctl_request_shutdown(sysmon);
 	else if (sysmon->ept)
-		acked = sysmon_request_shutdown(sysmon);
-
-	sysmon->shutdown_acked = acked;
+		sysmon->shutdown_acked = sysmon_request_shutdown(sysmon);
 }
 
 static void sysmon_unprepare(struct rproc_subdev *subdev)