diff mbox series

[v2] remoteproc: stm32: improve debug using dev_err_probe

Message ID 20201217144125.12903-1-arnaud.pouliquen@foss.st.com (mailing list archive)
State Accepted
Commit cf34838d591f1fce426fb7823c2f1890b6d1ccc8
Headers show
Series [v2] remoteproc: stm32: improve debug using dev_err_probe | expand

Commit Message

Arnaud POULIQUEN Dec. 17, 2020, 2:41 p.m. UTC 
From: Arnaud Pouliquen <arnaud.pouliquen@foss-st.com>

When possible use dev_err_probe help to properly deal with the
PROBE_DEFER error.
The benefit is that DEFER issue will be logged in the devices_deferred
debugfs file.

Signed-off-by: Arnaud Pouliquen <arnaud.pouliquen@foss-st.com>
---
V1 to V2: As suggested by Ahmad Fatoum use dev_err_probe to deal with
          deferred cases

V1: https://www.spinics.net/lists/kernel/msg3765884.html
---

 drivers/remoteproc/stm32_rproc.c | 23 +++++++++++++----------
 1 file changed, 13 insertions(+), 10 deletions(-)

Comments

Arnaud POULIQUEN Feb. 9, 2021, 8:35 a.m. UTC | #1 
Hi,

Gentle reminder, in case it has been forgotten.

Thanks,
Arnaud

On 12/17/20 3:41 PM, Arnaud Pouliquen wrote:
> From: Arnaud Pouliquen <arnaud.pouliquen@foss-st.com>
> 
> When possible use dev_err_probe help to properly deal with the
> PROBE_DEFER error.
> The benefit is that DEFER issue will be logged in the devices_deferred
> debugfs file.
> 
> Signed-off-by: Arnaud Pouliquen <arnaud.pouliquen@foss-st.com>
> ---
> V1 to V2: As suggested by Ahmad Fatoum use dev_err_probe to deal with
>           deferred cases
> 
> V1: https://www.spinics.net/lists/kernel/msg3765884.html
> ---
> 
>  drivers/remoteproc/stm32_rproc.c | 23 +++++++++++++----------
>  1 file changed, 13 insertions(+), 10 deletions(-)
> 
> diff --git a/drivers/remoteproc/stm32_rproc.c b/drivers/remoteproc/stm32_rproc.c
> index a180aeae9675..ccb3c14a0023 100644
> --- a/drivers/remoteproc/stm32_rproc.c
> +++ b/drivers/remoteproc/stm32_rproc.c
> @@ -370,8 +370,13 @@ static int stm32_rproc_request_mbox(struct rproc *rproc)
>  
>  		ddata->mb[i].chan = mbox_request_channel_byname(cl, name);
>  		if (IS_ERR(ddata->mb[i].chan)) {
> -			if (PTR_ERR(ddata->mb[i].chan) == -EPROBE_DEFER)
> +			if (PTR_ERR(ddata->mb[i].chan) == -EPROBE_DEFER) {
> +				dev_err_probe(dev->parent,
> +					      PTR_ERR(ddata->mb[i].chan),
> +					      "failed to request mailbox %s\n",
> +					      name);
>  				goto err_probe;
> +			}
>  			dev_warn(dev, "cannot get %s mbox\n", name);
>  			ddata->mb[i].chan = NULL;
>  		}
> @@ -592,15 +597,14 @@ static int stm32_rproc_parse_dt(struct platform_device *pdev,
>  
>  	irq = platform_get_irq(pdev, 0);
>  	if (irq == -EPROBE_DEFER)
> -		return -EPROBE_DEFER;
> +		return dev_err_probe(dev, irq, "failed to get interrupt\n");
>  
>  	if (irq > 0) {
>  		err = devm_request_irq(dev, irq, stm32_rproc_wdg, 0,
>  				       dev_name(dev), pdev);
> -		if (err) {
> -			dev_err(dev, "failed to request wdg irq\n");
> -			return err;
> -		}
> +		if (err)
> +			return dev_err_probe(dev, err,
> +					     "failed to request wdg irq\n");
>  
>  		ddata->wdg_irq = irq;
>  
> @@ -613,10 +617,9 @@ static int stm32_rproc_parse_dt(struct platform_device *pdev,
>  	}
>  
>  	ddata->rst = devm_reset_control_get_by_index(dev, 0);
> -	if (IS_ERR(ddata->rst)) {
> -		dev_err(dev, "failed to get mcu reset\n");
> -		return PTR_ERR(ddata->rst);
> -	}
> +	if (IS_ERR(ddata->rst))
> +		return dev_err_probe(dev, PTR_ERR(ddata->rst),
> +				     "failed to get mcu_reset\n");
>  
>  	/*
>  	 * if platform is secured the hold boot bit must be written by
>
patchwork-bot+linux-remoteproc@kernel.org Feb. 9, 2021, 5:40 p.m. UTC | #2 
Hello:

This patch was applied to andersson/remoteproc.git (refs/heads/for-next):

On Thu, 17 Dec 2020 15:41:25 +0100 you wrote:
> From: Arnaud Pouliquen <arnaud.pouliquen@foss-st.com>
> 
> When possible use dev_err_probe help to properly deal with the
> PROBE_DEFER error.
> The benefit is that DEFER issue will be logged in the devices_deferred
> debugfs file.
> 
> [...]

Here is the summary with links:
  - [v2] remoteproc: stm32: improve debug using dev_err_probe
    https://git.kernel.org/andersson/remoteproc/c/cf34838d591f

You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
diff mbox series

Patch

diff --git a/drivers/remoteproc/stm32_rproc.c b/drivers/remoteproc/stm32_rproc.c
index a180aeae9675..ccb3c14a0023 100644
--- a/drivers/remoteproc/stm32_rproc.c
+++ b/drivers/remoteproc/stm32_rproc.c
@@ -370,8 +370,13 @@  static int stm32_rproc_request_mbox(struct rproc *rproc)
 
 		ddata->mb[i].chan = mbox_request_channel_byname(cl, name);
 		if (IS_ERR(ddata->mb[i].chan)) {
-			if (PTR_ERR(ddata->mb[i].chan) == -EPROBE_DEFER)
+			if (PTR_ERR(ddata->mb[i].chan) == -EPROBE_DEFER) {
+				dev_err_probe(dev->parent,
+					      PTR_ERR(ddata->mb[i].chan),
+					      "failed to request mailbox %s\n",
+					      name);
 				goto err_probe;
+			}
 			dev_warn(dev, "cannot get %s mbox\n", name);
 			ddata->mb[i].chan = NULL;
 		}
@@ -592,15 +597,14 @@  static int stm32_rproc_parse_dt(struct platform_device *pdev,
 
 	irq = platform_get_irq(pdev, 0);
 	if (irq == -EPROBE_DEFER)
-		return -EPROBE_DEFER;
+		return dev_err_probe(dev, irq, "failed to get interrupt\n");
 
 	if (irq > 0) {
 		err = devm_request_irq(dev, irq, stm32_rproc_wdg, 0,
 				       dev_name(dev), pdev);
-		if (err) {
-			dev_err(dev, "failed to request wdg irq\n");
-			return err;
-		}
+		if (err)
+			return dev_err_probe(dev, err,
+					     "failed to request wdg irq\n");
 
 		ddata->wdg_irq = irq;
 
@@ -613,10 +617,9 @@  static int stm32_rproc_parse_dt(struct platform_device *pdev,
 	}
 
 	ddata->rst = devm_reset_control_get_by_index(dev, 0);
-	if (IS_ERR(ddata->rst)) {
-		dev_err(dev, "failed to get mcu reset\n");
-		return PTR_ERR(ddata->rst);
-	}
+	if (IS_ERR(ddata->rst))
+		return dev_err_probe(dev, PTR_ERR(ddata->rst),
+				     "failed to get mcu_reset\n");
 
 	/*
 	 * if platform is secured the hold boot bit must be written by