| Message ID | 20210601083100.130776-1-chengzhihao1@huawei.com (mailing list archive) |
|---|---|
| State | Rejected |
| Headers | show |
| Series | remoteproc: pru: Remove redundant dev_err call in pru_rproc_probe() | expand |
On Tue, Jun 01, 2021 at 04:31:00PM +0800, Zhihao Cheng wrote: > There is a error message within devm_ioremap_resource > already, so remove the dev_err call to avoid redundant > error message. > > Reported-by: Hulk Robot <hulkci@huawei.com> > Signed-off-by: Zhihao Cheng <chengzhihao1@huawei.com> > --- > drivers/remoteproc/pru_rproc.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/drivers/remoteproc/pru_rproc.c b/drivers/remoteproc/pru_rproc.c > index e5778e476245..6491c731c6e2 100644 > --- a/drivers/remoteproc/pru_rproc.c > +++ b/drivers/remoteproc/pru_rproc.c > @@ -822,8 +822,6 @@ static int pru_rproc_probe(struct platform_device *pdev) > mem_names[i]); > pru->mem_regions[i].va = devm_ioremap_resource(dev, res); > if (IS_ERR(pru->mem_regions[i].va)) { > - dev_err(dev, "failed to parse and map memory resource %d %s\n", > - i, mem_names[i]); https://patchwork.kernel.org/project/linux-remoteproc/patch/20210511120426.5834-1-thunder.leizhen@huawei.com/ > ret = PTR_ERR(pru->mem_regions[i].va); > return ret; > } > -- > 2.31.1 >
在 2021/6/1 23:20, Mathieu Poirier 写道: > On Tue, Jun 01, 2021 at 04:31:00PM +0800, Zhihao Cheng wrote: > > @@ -822,8 +822,6 @@ static int pru_rproc_probe(struct platform_device *pdev) > mem_names[i]); > pru->mem_regions[i].va = devm_ioremap_resource(dev, res); > if (IS_ERR(pru->mem_regions[i].va)) { > - dev_err(dev, "failed to parse and map memory resource %d %s\n", > - i, mem_names[i]); > https://patchwork.kernel.org/project/linux-remoteproc/patch/20210511120426.5834-1-thunder.leizhen@huawei.com/ Thanks for reminding. Ignore this patch. >> ret = PTR_ERR(pru->mem_regions[i].va); >> return ret; >> } >> -- >> 2.31.1 >> > .
diff --git a/drivers/remoteproc/pru_rproc.c b/drivers/remoteproc/pru_rproc.c index e5778e476245..6491c731c6e2 100644 --- a/drivers/remoteproc/pru_rproc.c +++ b/drivers/remoteproc/pru_rproc.c @@ -822,8 +822,6 @@ static int pru_rproc_probe(struct platform_device *pdev) mem_names[i]); pru->mem_regions[i].va = devm_ioremap_resource(dev, res); if (IS_ERR(pru->mem_regions[i].va)) { - dev_err(dev, "failed to parse and map memory resource %d %s\n", - i, mem_names[i]); ret = PTR_ERR(pru->mem_regions[i].va); return ret; }
There is a error message within devm_ioremap_resource already, so remove the dev_err call to avoid redundant error message. Reported-by: Hulk Robot <hulkci@huawei.com> Signed-off-by: Zhihao Cheng <chengzhihao1@huawei.com> --- drivers/remoteproc/pru_rproc.c | 2 -- 1 file changed, 2 deletions(-)