| Message ID | 20210817152005.21575-1-sinthu.raja@ti.com (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
| Series | dt-bindings: remoteproc: k3-dsp: Update example to remove board specific | expand |
On Tue, 17 Aug 2021 20:50:05 +0530, Sinthu Raja wrote: > From: Sinthu Raja <sinthu.raja@ti.com> > > The example includes a board-specific compatible property, but developers > need to add the board name each time when a new board is added to the K3 > J721E SoC list. This grows the compatible string-list. So, drop the > board-specific compatible string and add cbass_main as a parent node to > avoid parent node and child node address-cells mismatch error. > > Signed-off-by: Sinthu Raja <sinthu.raja@ti.com> > --- > .../devicetree/bindings/remoteproc/ti,k3-dsp-rproc.yaml | 6 ++---- > 1 file changed, 2 insertions(+), 4 deletions(-) > My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check' on your patch (DT_CHECKER_FLAGS is new in v5.13): yamllint warnings/errors: dtschema/dtc warnings/errors: make[1]: *** Deleting file 'Documentation/devicetree/bindings/remoteproc/ti,k3-dsp-rproc.example.dts' Traceback (most recent call last): File "/usr/local/bin/dt-extract-example", line 45, in <module> binding = yaml.load(open(args.yamlfile, encoding='utf-8').read()) File "/usr/local/lib/python3.8/dist-packages/ruamel/yaml/main.py", line 434, in load return constructor.get_single_data() File "/usr/local/lib/python3.8/dist-packages/ruamel/yaml/constructor.py", line 120, in get_single_data node = self.composer.get_single_node() File "_ruamel_yaml.pyx", line 706, in _ruamel_yaml.CParser.get_single_node File "_ruamel_yaml.pyx", line 724, in _ruamel_yaml.CParser._compose_document File "_ruamel_yaml.pyx", line 775, in _ruamel_yaml.CParser._compose_node File "_ruamel_yaml.pyx", line 889, in _ruamel_yaml.CParser._compose_mapping_node File "_ruamel_yaml.pyx", line 773, in _ruamel_yaml.CParser._compose_node File "_ruamel_yaml.pyx", line 852, in _ruamel_yaml.CParser._compose_sequence_node File "_ruamel_yaml.pyx", line 904, in _ruamel_yaml.CParser._parse_next_event ruamel.yaml.parser.ParserError: while parsing a block collection in "<unicode string>", line 135, column 3 did not find expected '-' indicator in "<unicode string>", line 182, column 5 make[1]: *** [Documentation/devicetree/bindings/Makefile:20: Documentation/devicetree/bindings/remoteproc/ti,k3-dsp-rproc.example.dts] Error 1 make[1]: *** Waiting for unfinished jobs.... Traceback (most recent call last): File "/usr/bin/yamllint", line 11, in <module> load_entry_point('yamllint==1.20.0', 'console_scripts', 'yamllint')() File "/usr/lib/python3/dist-packages/yamllint/cli.py", line 184, in run prob_level = show_problems(problems, file, args_format=args.format, File "/usr/lib/python3/dist-packages/yamllint/cli.py", line 91, in show_problems for problem in problems: File "/usr/lib/python3/dist-packages/yamllint/linter.py", line 200, in _run for problem in get_cosmetic_problems(buffer, conf, filepath): File "/usr/lib/python3/dist-packages/yamllint/linter.py", line 137, in get_cosmetic_problems for problem in rule.check(rule_conf, File "/usr/lib/python3/dist-packages/yamllint/rules/indentation.py", line 570, in check for problem in _check(conf, token, prev, next, nextnext, context): File "/usr/lib/python3/dist-packages/yamllint/rules/indentation.py", line 336, in _check 'wrong indentation: expected %d but found %d' % TypeError: %d format: a number is required, not NoneType ./Documentation/devicetree/bindings/remoteproc/ti,k3-dsp-rproc.yaml: while parsing a block collection in "<unicode string>", line 135, column 3 did not find expected '-' indicator in "<unicode string>", line 182, column 5 /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/remoteproc/ti,k3-dsp-rproc.yaml: ignoring, error parsing file warning: no schema found in file: ./Documentation/devicetree/bindings/remoteproc/ti,k3-dsp-rproc.yaml make: *** [Makefile:1419: dt_binding_check] Error 2 doc reference errors (make refcheckdocs): See https://patchwork.ozlabs.org/patch/1517765 This check can fail if there are any dependencies. The base for a patch series is generally the most recent rc1. If you already ran 'make dt_binding_check' and didn't see the above error(s), then make sure 'yamllint' is installed and dt-schema is up to date: pip3 install dtschema --upgrade Please check and re-submit.
diff --git a/Documentation/devicetree/bindings/remoteproc/ti,k3-dsp-rproc.yaml b/Documentation/devicetree/bindings/remoteproc/ti,k3-dsp-rproc.yaml index 6070456a7b67..905b8798d4c4 100644 --- a/Documentation/devicetree/bindings/remoteproc/ti,k3-dsp-rproc.yaml +++ b/Documentation/devicetree/bindings/remoteproc/ti,k3-dsp-rproc.yaml @@ -132,10 +132,8 @@ required: unevaluatedProperties: false examples: - - | - / { - model = "Texas Instruments K3 J721E SoC"; - compatible = "ti,j721e"; + - |+ + cbass_main { #address-cells = <2>; #size-cells = <2>;