diff mbox series

[V2] remoteproc: imx_rproc: Ignore create mem entry for resource table

Message ID 20220308065754.3355-1-peng.fan@oss.nxp.com (mailing list archive)
State Superseded
Headers show
Series [V2] remoteproc: imx_rproc: Ignore create mem entry for resource table | expand

Commit Message

Peng Fan (OSS) March 8, 2022, 6:57 a.m. UTC 
From: Peng Fan <peng.fan@nxp.com>

Resource table will not be used for memory allocation, no need to create
rproc mem entry.

Fixes: b29b4249f8f0c ("remoteproc: imx_rproc: add i.MX specific parse fw hook")
Signed-off-by: Peng Fan <peng.fan@nxp.com>
---

V2:
 Add Fixes tag
 Separate the patch from https://patchwork.kernel.org/project/linux-remoteproc/patch/20220111033333.403448-7-peng.fan@oss.nxp.com/
 Address typo

 drivers/remoteproc/imx_rproc.c | 3 +++
 1 file changed, 3 insertions(+)

Comments

Bjorn Andersson March 11, 2022, 6:20 p.m. UTC | #1 
On Tue 08 Mar 00:57 CST 2022, Peng Fan (OSS) wrote:

> From: Peng Fan <peng.fan@nxp.com>
> 
> Resource table will not be used for memory allocation, no need to create
> rproc mem entry.

Can you please expand this to cover why the "resource table will not be
used for memory allocation"?

Regards,
Bjorn

> 
> Fixes: b29b4249f8f0c ("remoteproc: imx_rproc: add i.MX specific parse fw hook")
> Signed-off-by: Peng Fan <peng.fan@nxp.com>
> ---
> 
> V2:
>  Add Fixes tag
>  Separate the patch from https://patchwork.kernel.org/project/linux-remoteproc/patch/20220111033333.403448-7-peng.fan@oss.nxp.com/
>  Address typo
> 
>  drivers/remoteproc/imx_rproc.c | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/drivers/remoteproc/imx_rproc.c b/drivers/remoteproc/imx_rproc.c
> index 7a096f1891e6..f2bfc9077c19 100644
> --- a/drivers/remoteproc/imx_rproc.c
> +++ b/drivers/remoteproc/imx_rproc.c
> @@ -423,6 +423,9 @@ static int imx_rproc_prepare(struct rproc *rproc)
>  		if (!strcmp(it.node->name, "vdev0buffer"))
>  			continue;
>  
> +		if (!strncmp(it.node->name, "rsc-table", strlen("rsc-table")))
> +			continue;
> +
>  		rmem = of_reserved_mem_lookup(it.node);
>  		if (!rmem) {
>  			dev_err(priv->dev, "unable to acquire memory-region\n");
> -- 
> 2.30.0
>
Mathieu Poirier March 24, 2022, 3:11 p.m. UTC | #2 
On Tue, Mar 08, 2022 at 02:57:54PM +0800, Peng Fan (OSS) wrote:
> From: Peng Fan <peng.fan@nxp.com>
> 
> Resource table will not be used for memory allocation, no need to create
> rproc mem entry.
> 
> Fixes: b29b4249f8f0c ("remoteproc: imx_rproc: add i.MX specific parse fw hook")


https://elixir.bootlin.com/linux/v5.17/source/Documentation/process/submitting-patches.rst


> Signed-off-by: Peng Fan <peng.fan@nxp.com>
> ---
> 
> V2:
>  Add Fixes tag
>  Separate the patch from https://patchwork.kernel.org/project/linux-remoteproc/patch/20220111033333.403448-7-peng.fan@oss.nxp.com/
>  Address typo
> 
>  drivers/remoteproc/imx_rproc.c | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/drivers/remoteproc/imx_rproc.c b/drivers/remoteproc/imx_rproc.c
> index 7a096f1891e6..f2bfc9077c19 100644
> --- a/drivers/remoteproc/imx_rproc.c
> +++ b/drivers/remoteproc/imx_rproc.c
> @@ -423,6 +423,9 @@ static int imx_rproc_prepare(struct rproc *rproc)
>  		if (!strcmp(it.node->name, "vdev0buffer"))
>  			continue;
>  
> +		if (!strncmp(it.node->name, "rsc-table", strlen("rsc-table")))
> +			continue;
> +
>  		rmem = of_reserved_mem_lookup(it.node);
>  		if (!rmem) {
>  			dev_err(priv->dev, "unable to acquire memory-region\n");
> -- 
> 2.30.0
>
Peng Fan March 25, 2022, 2:02 a.m. UTC | #3 
Hi Mathieu,

> Subject: Re: [PATCH V2] remoteproc: imx_rproc: Ignore create mem entry for
> resource table
> 
> On Tue, Mar 08, 2022 at 02:57:54PM +0800, Peng Fan (OSS) wrote:
> > From: Peng Fan <peng.fan@nxp.com>
> >
> > Resource table will not be used for memory allocation, no need to
> > create rproc mem entry.
> >
> > Fixes: b29b4249f8f0c ("remoteproc: imx_rproc: add i.MX specific parse
> > fw hook")
> 
> 
> https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Felixir.b
> ootlin.com%2Flinux%2Fv5.17%2Fsource%2FDocumentation%2Fprocess%2Fsu
> bmitting-patches.rst&amp;data=04%7C01%7Cpeng.fan%40nxp.com%7Cae62
> e633010048f972db08da0da89836%7C686ea1d3bc2b4c6fa92cd99c5c301635
> %7C0%7C1%7C637837315009092474%7CUnknown%7CTWFpbGZsb3d8eyJW
> IjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C
> 3000&amp;sdata=Xod3YxSRW8h2WXdnpu1WX4DzRpCTnYE9gVlt9HXMlnU%3
> D&amp;reserved=0

Sorry, I could not get your point of which part conflicts with the patch rules.
Please clarify and I'll improve.

Thanks,
Peng.


> 
> 
> > Signed-off-by: Peng Fan <peng.fan@nxp.com>
> > ---
> >
> > V2:
> >  Add Fixes tag
> >  Separate the patch from
> > https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fpatc
> >
> hwork.kernel.org%2Fproject%2Flinux-remoteproc%2Fpatch%2F20220111033
> 333
> > .403448-7-peng.fan%40oss.nxp.com%2F&amp;data=04%7C01%7Cpeng.fan
> %40nxp.
> >
> com%7Cae62e633010048f972db08da0da89836%7C686ea1d3bc2b4c6fa92cd
> 99c5c301
> >
> 635%7C0%7C1%7C637837315009092474%7CUnknown%7CTWFpbGZsb3d8e
> yJWIjoiMC4wL
> >
> jAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000&am
> p;sdata
> >
> =CYL9grwXHpUud4qpzFAEijOWv%2BehvefwyZ4aU02wJnw%3D&amp;reserv
> ed=0
> >  Address typo
> >
> >  drivers/remoteproc/imx_rproc.c | 3 +++
> >  1 file changed, 3 insertions(+)
> >
> > diff --git a/drivers/remoteproc/imx_rproc.c
> > b/drivers/remoteproc/imx_rproc.c index 7a096f1891e6..f2bfc9077c19
> > 100644
> > --- a/drivers/remoteproc/imx_rproc.c
> > +++ b/drivers/remoteproc/imx_rproc.c
> > @@ -423,6 +423,9 @@ static int imx_rproc_prepare(struct rproc *rproc)
> >  		if (!strcmp(it.node->name, "vdev0buffer"))
> >  			continue;
> >
> > +		if (!strncmp(it.node->name, "rsc-table", strlen("rsc-table")))
> > +			continue;
> > +
> >  		rmem = of_reserved_mem_lookup(it.node);
> >  		if (!rmem) {
> >  			dev_err(priv->dev, "unable to acquire memory-region\n");
> > --
> > 2.30.0
> >
Mathieu Poirier March 25, 2022, 4:02 p.m. UTC | #4 
On Thu, 24 Mar 2022 at 20:02, Peng Fan <peng.fan@nxp.com> wrote:
>
> Hi Mathieu,
>
> > Subject: Re: [PATCH V2] remoteproc: imx_rproc: Ignore create mem entry for
> > resource table
> >
> > On Tue, Mar 08, 2022 at 02:57:54PM +0800, Peng Fan (OSS) wrote:
> > > From: Peng Fan <peng.fan@nxp.com>
> > >
> > > Resource table will not be used for memory allocation, no need to
> > > create rproc mem entry.
> > >
> > > Fixes: b29b4249f8f0c ("remoteproc: imx_rproc: add i.MX specific parse
> > > fw hook")
> >
> >
> > https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Felixir.b
> > ootlin.com%2Flinux%2Fv5.17%2Fsource%2FDocumentation%2Fprocess%2Fsu
> > bmitting-patches.rst&amp;data=04%7C01%7Cpeng.fan%40nxp.com%7Cae62
> > e633010048f972db08da0da89836%7C686ea1d3bc2b4c6fa92cd99c5c301635
> > %7C0%7C1%7C637837315009092474%7CUnknown%7CTWFpbGZsb3d8eyJW
> > IjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C
> > 3000&amp;sdata=Xod3YxSRW8h2WXdnpu1WX4DzRpCTnYE9gVlt9HXMlnU%3
> > D&amp;reserved=0
>
> Sorry, I could not get your point of which part conflicts with the patch rules.
> Please clarify and I'll improve.

The commitID in the "Fixes" tag should be 12 characters rather than 13
as you have above.

>
> Thanks,
> Peng.
>
>
> >
> >
> > > Signed-off-by: Peng Fan <peng.fan@nxp.com>
> > > ---
> > >
> > > V2:
> > >  Add Fixes tag
> > >  Separate the patch from
> > > https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fpatc
> > >
> > hwork.kernel.org%2Fproject%2Flinux-remoteproc%2Fpatch%2F20220111033
> > 333
> > > .403448-7-peng.fan%40oss.nxp.com%2F&amp;data=04%7C01%7Cpeng.fan
> > %40nxp.
> > >
> > com%7Cae62e633010048f972db08da0da89836%7C686ea1d3bc2b4c6fa92cd
> > 99c5c301
> > >
> > 635%7C0%7C1%7C637837315009092474%7CUnknown%7CTWFpbGZsb3d8e
> > yJWIjoiMC4wL
> > >
> > jAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000&am
> > p;sdata
> > >
> > =CYL9grwXHpUud4qpzFAEijOWv%2BehvefwyZ4aU02wJnw%3D&amp;reserv
> > ed=0
> > >  Address typo
> > >
> > >  drivers/remoteproc/imx_rproc.c | 3 +++
> > >  1 file changed, 3 insertions(+)
> > >
> > > diff --git a/drivers/remoteproc/imx_rproc.c
> > > b/drivers/remoteproc/imx_rproc.c index 7a096f1891e6..f2bfc9077c19
> > > 100644
> > > --- a/drivers/remoteproc/imx_rproc.c
> > > +++ b/drivers/remoteproc/imx_rproc.c
> > > @@ -423,6 +423,9 @@ static int imx_rproc_prepare(struct rproc *rproc)
> > >             if (!strcmp(it.node->name, "vdev0buffer"))
> > >                     continue;
> > >
> > > +           if (!strncmp(it.node->name, "rsc-table", strlen("rsc-table")))
> > > +                   continue;
> > > +
> > >             rmem = of_reserved_mem_lookup(it.node);
> > >             if (!rmem) {
> > >                     dev_err(priv->dev, "unable to acquire memory-region\n");
> > > --
> > > 2.30.0
> > >
diff mbox series

Patch

diff --git a/drivers/remoteproc/imx_rproc.c b/drivers/remoteproc/imx_rproc.c
index 7a096f1891e6..f2bfc9077c19 100644
--- a/drivers/remoteproc/imx_rproc.c
+++ b/drivers/remoteproc/imx_rproc.c
@@ -423,6 +423,9 @@  static int imx_rproc_prepare(struct rproc *rproc)
 		if (!strcmp(it.node->name, "vdev0buffer"))
 			continue;
 
+		if (!strncmp(it.node->name, "rsc-table", strlen("rsc-table")))
+			continue;
+
 		rmem = of_reserved_mem_lookup(it.node);
 		if (!rmem) {
 			dev_err(priv->dev, "unable to acquire memory-region\n");