diff mbox series

rpmsg: qcom_smd: Fix returning 0 if irq_of_parse_and_map() fails

Message ID 20220423093932.32136-1-krzysztof.kozlowski@linaro.org (mailing list archive)
State New
Headers show
Series rpmsg: qcom_smd: Fix returning 0 if irq_of_parse_and_map() fails | expand

Commit Message

Krzysztof Kozlowski April 23, 2022, 9:39 a.m. UTC
irq_of_parse_and_map() returns 0 on failure, so this should not be
passed further as error return code.

Fixes: 1a358d350664 ("rpmsg: qcom_smd: Fix irq_of_parse_and_map() return value")
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>

---

A fix for: https://lore.kernel.org/all/20220422105326.78713-1-krzysztof.kozlowski@linaro.org/
Commit sha from Bjorn's email, so might not be stable/correct.

Consider squashing it.
---
 drivers/rpmsg/qcom_smd.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Krzysztof Kozlowski April 28, 2022, 9:47 a.m. UTC | #1
On 23/04/2022 11:39, Krzysztof Kozlowski wrote:
> irq_of_parse_and_map() returns 0 on failure, so this should not be
> passed further as error return code.
> 
> Fixes: 1a358d350664 ("rpmsg: qcom_smd: Fix irq_of_parse_and_map() return value")
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> 
> ---
> 
> A fix for: https://lore.kernel.org/all/20220422105326.78713-1-krzysztof.kozlowski@linaro.org/
> Commit sha from Bjorn's email, so might not be stable/correct.
> 

Bjorn,

Can you pick up this one? It's for an issue in your tree, introduced
with my previous patch.

Best regards,
Krzysztof
diff mbox series

Patch

diff --git a/drivers/rpmsg/qcom_smd.c b/drivers/rpmsg/qcom_smd.c
index 6ccfa12abd10..1957b27c4cf3 100644
--- a/drivers/rpmsg/qcom_smd.c
+++ b/drivers/rpmsg/qcom_smd.c
@@ -1409,7 +1409,7 @@  static int qcom_smd_parse_edge(struct device *dev,
 	irq = irq_of_parse_and_map(node, 0);
 	if (!irq) {
 		dev_err(dev, "required smd interrupt missing\n");
-		ret = irq;
+		ret = -EINVAL;
 		goto put_node;
 	}