diff mbox series

remoteproc: qcom: using pm_runtime_resume_and_get to simplify the code

Message ID 20220428064545.3850057-1-ran.jianping@zte.com.cn (mailing list archive)
State Accepted
Headers show
Series remoteproc: qcom: using pm_runtime_resume_and_get to simplify the code | expand

Commit Message

CGEL April 28, 2022, 6:45 a.m. UTC 
From: ran jianping <ran.jianping@zte.com.cn>

Using pm_runtime_resume_and_get() to replace pm_runtime_get_sync and
pm_runtime_put_noidle. This change is just to simplify the code, no
actual functional changes.

Reported-by: Zeal Robot <zealci@zte.com.cn>
Signed-off-by: ran jianping <ran.jianping@zte.com.cn>
---
 drivers/remoteproc/qcom_q6v5_adsp.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

Comments

Bjorn Andersson July 18, 2022, 10:59 p.m. UTC | #1 
On Thu, 28 Apr 2022 06:45:45 +0000, cgel.zte@gmail.com wrote:
> From: ran jianping <ran.jianping@zte.com.cn>
> 
> Using pm_runtime_resume_and_get() to replace pm_runtime_get_sync and
> pm_runtime_put_noidle. This change is just to simplify the code, no
> actual functional changes.
> 
> 
> [...]

Applied, thanks!

[1/1] remoteproc: qcom: using pm_runtime_resume_and_get to simplify the code
      commit: f2ac69165dd78fb905187736e65b25151377ed89

Best regards,
diff mbox series

Patch

diff --git a/drivers/remoteproc/qcom_q6v5_adsp.c b/drivers/remoteproc/qcom_q6v5_adsp.c
index 2f3b9f54251e..366e1d4a839a 100644
--- a/drivers/remoteproc/qcom_q6v5_adsp.c
+++ b/drivers/remoteproc/qcom_q6v5_adsp.c
@@ -175,9 +175,8 @@  static int qcom_rproc_pds_enable(struct qcom_adsp *adsp, struct device **pds,
 
 	for (i = 0; i < pd_count; i++) {
 		dev_pm_genpd_set_performance_state(pds[i], INT_MAX);
-		ret = pm_runtime_get_sync(pds[i]);
+		ret = pm_runtime_resume_and_get(pds[i])
 		if (ret < 0) {
-			pm_runtime_put_noidle(pds[i]);
 			dev_pm_genpd_set_performance_state(pds[i], 0);
 			goto unroll_pd_votes;
 		}