| Message ID | 20220501103520.111561-1-krzysztof.kozlowski@linaro.org (mailing list archive) |
|---|---|
| State | Not Applicable |
| Headers | show |
| Series | [1/8] clk: qcom: alpha-pll: correct kerneldoc | expand |
On 01/05/2022 12:35, Krzysztof Kozlowski wrote: > Correct kerneldoc warning: > > drivers/clk/qcom/clk-alpha-pll.c:1450: > warning: expecting prototype for clk_lucid_pll_configure(). Prototype was for clk_trion_pll_configure() instead > > Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> Any comments on entire set? They are on the lists for more than two weeks and it's getting late to apply it before merge window. Best regards, Krzysztof
Quoting Krzysztof Kozlowski (2022-05-01 03:35:13) > diff --git a/drivers/clk/qcom/clk-alpha-pll.c b/drivers/clk/qcom/clk-alpha-pll.c > index 4406cf609aae..969d98fca5df 100644 > --- a/drivers/clk/qcom/clk-alpha-pll.c > +++ b/drivers/clk/qcom/clk-alpha-pll.c > @@ -1439,7 +1439,7 @@ const struct clk_ops clk_alpha_pll_postdiv_fabia_ops = { > EXPORT_SYMBOL_GPL(clk_alpha_pll_postdiv_fabia_ops); > > /** > - * clk_lucid_pll_configure - configure the lucid pll > + * clk_trion_pll_configure - configure the lucid pll configure the trion pll? > * > * @pll: clk alpha pll > * @regmap: register map
Quoting Krzysztof Kozlowski (2022-05-17 09:46:49) > On 01/05/2022 12:35, Krzysztof Kozlowski wrote: > > Correct kerneldoc warning: > > > > drivers/clk/qcom/clk-alpha-pll.c:1450: > > warning: expecting prototype for clk_lucid_pll_configure(). Prototype was for clk_trion_pll_configure() instead > > > > Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > > Any comments on entire set? Please send a cover letter next time. Also they're simply "qcom" related but otherwise I'm not sure why they aren't sent to individual subsystem lists. They don't depend on each other to build, right?
Hi Krzysztof, On 5/1/22 13:35, Krzysztof Kozlowski wrote: > Correct kerneldoc warning: > > drivers/clk/qcom/clk-alpha-pll.c:1450: > warning: expecting prototype for clk_lucid_pll_configure(). Prototype was for clk_trion_pll_configure() instead > > Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > --- > drivers/clk/qcom/clk-alpha-pll.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/clk/qcom/clk-alpha-pll.c b/drivers/clk/qcom/clk-alpha-pll.c > index 4406cf609aae..969d98fca5df 100644 > --- a/drivers/clk/qcom/clk-alpha-pll.c > +++ b/drivers/clk/qcom/clk-alpha-pll.c > @@ -1439,7 +1439,7 @@ const struct clk_ops clk_alpha_pll_postdiv_fabia_ops = { > EXPORT_SYMBOL_GPL(clk_alpha_pll_postdiv_fabia_ops); > > /** > - * clk_lucid_pll_configure - configure the lucid pll > + * clk_trion_pll_configure - configure the lucid pll > * > * @pll: clk alpha pll > * @regmap: register map this fix is done earlier, unfortunately the inclusion is still pending, in v5 series: https://lore.kernel.org/linux-clk/20220509090143.4140999-1-vladimir.zapolskiy@linaro.org/ -- Best wishes, Vladimir
On 19/05/2022 02:02, Stephen Boyd wrote: > Quoting Krzysztof Kozlowski (2022-05-01 03:35:13) >> diff --git a/drivers/clk/qcom/clk-alpha-pll.c b/drivers/clk/qcom/clk-alpha-pll.c >> index 4406cf609aae..969d98fca5df 100644 >> --- a/drivers/clk/qcom/clk-alpha-pll.c >> +++ b/drivers/clk/qcom/clk-alpha-pll.c >> @@ -1439,7 +1439,7 @@ const struct clk_ops clk_alpha_pll_postdiv_fabia_ops = { >> EXPORT_SYMBOL_GPL(clk_alpha_pll_postdiv_fabia_ops); >> >> /** >> - * clk_lucid_pll_configure - configure the lucid pll >> + * clk_trion_pll_configure - configure the lucid pll > > configure the trion pll? Ah, copy paste :/ Best regards, Krzysztof
On 19/05/2022 02:14, Stephen Boyd wrote: > Quoting Krzysztof Kozlowski (2022-05-17 09:46:49) >> On 01/05/2022 12:35, Krzysztof Kozlowski wrote: >>> Correct kerneldoc warning: >>> >>> drivers/clk/qcom/clk-alpha-pll.c:1450: >>> warning: expecting prototype for clk_lucid_pll_configure(). Prototype was for clk_trion_pll_configure() instead >>> >>> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> >> >> Any comments on entire set? > > Please send a cover letter next time. Also they're simply "qcom" related > but otherwise I'm not sure why they aren't sent to individual subsystem > lists. They don't depend on each other to build, right? Indeed, they can go via separate subsystems. I'll split the series in v2. Best regards, Krzysztof
On 19/05/2022 06:30, Vladimir Zapolskiy wrote: > Hi Krzysztof, > > On 5/1/22 13:35, Krzysztof Kozlowski wrote: >> Correct kerneldoc warning: >> >> drivers/clk/qcom/clk-alpha-pll.c:1450: >> warning: expecting prototype for clk_lucid_pll_configure(). Prototype was for clk_trion_pll_configure() instead >> >> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> >> --- >> drivers/clk/qcom/clk-alpha-pll.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/drivers/clk/qcom/clk-alpha-pll.c b/drivers/clk/qcom/clk-alpha-pll.c >> index 4406cf609aae..969d98fca5df 100644 >> --- a/drivers/clk/qcom/clk-alpha-pll.c >> +++ b/drivers/clk/qcom/clk-alpha-pll.c >> @@ -1439,7 +1439,7 @@ const struct clk_ops clk_alpha_pll_postdiv_fabia_ops = { >> EXPORT_SYMBOL_GPL(clk_alpha_pll_postdiv_fabia_ops); >> >> /** >> - * clk_lucid_pll_configure - configure the lucid pll >> + * clk_trion_pll_configure - configure the lucid pll >> * >> * @pll: clk alpha pll >> * @regmap: register map > > this fix is done earlier, unfortunately the inclusion is still pending, in v5 series: > > https://lore.kernel.org/linux-clk/20220509090143.4140999-1-vladimir.zapolskiy@linaro.org/ > I'll skip this one. Best regards, Krzysztof
diff --git a/drivers/clk/qcom/clk-alpha-pll.c b/drivers/clk/qcom/clk-alpha-pll.c index 4406cf609aae..969d98fca5df 100644 --- a/drivers/clk/qcom/clk-alpha-pll.c +++ b/drivers/clk/qcom/clk-alpha-pll.c @@ -1439,7 +1439,7 @@ const struct clk_ops clk_alpha_pll_postdiv_fabia_ops = { EXPORT_SYMBOL_GPL(clk_alpha_pll_postdiv_fabia_ops); /** - * clk_lucid_pll_configure - configure the lucid pll + * clk_trion_pll_configure - configure the lucid pll * * @pll: clk alpha pll * @regmap: register map
Correct kerneldoc warning: drivers/clk/qcom/clk-alpha-pll.c:1450: warning: expecting prototype for clk_lucid_pll_configure(). Prototype was for clk_trion_pll_configure() instead Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> --- drivers/clk/qcom/clk-alpha-pll.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)