diff mbox series

[5/8] rpmsg: qcom: glink: remove unused name

Message ID 20220501103520.111561-5-krzysztof.kozlowski@linaro.org (mailing list archive)
State New
Headers show
Series [1/8] clk: qcom: alpha-pll: correct kerneldoc | expand

Commit Message

Krzysztof Kozlowski May 1, 2022, 10:35 a.m. UTC
The qcom_glink.name is read from DTS but never used further, never
referenced, so drop it.  This also fixes kerneldoc warning:

  drivers/rpmsg/qcom_glink_native.c:125:
    warning: Function parameter or member 'name' not described in 'qcom_glink'

Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
 drivers/rpmsg/qcom_glink_native.c | 6 ------
 1 file changed, 6 deletions(-)

Comments

Stephen Boyd May 19, 2022, 12:09 a.m. UTC | #1
Quoting Krzysztof Kozlowski (2022-05-01 03:35:17)
> The qcom_glink.name is read from DTS but never used further, never
> referenced, so drop it.  This also fixes kerneldoc warning:
> 
>   drivers/rpmsg/qcom_glink_native.c:125:
>     warning: Function parameter or member 'name' not described in 'qcom_glink'
> 
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> ---

Reviewed-by: Stephen Boyd <sboyd@kernel.org>
diff mbox series

Patch

diff --git a/drivers/rpmsg/qcom_glink_native.c b/drivers/rpmsg/qcom_glink_native.c
index 5bc5a0a6a8a7..72a1c0fd091d 100644
--- a/drivers/rpmsg/qcom_glink_native.c
+++ b/drivers/rpmsg/qcom_glink_native.c
@@ -98,8 +98,6 @@  struct glink_core_rx_intent {
 struct qcom_glink {
 	struct device *dev;
 
-	const char *name;
-
 	struct mbox_client mbox_client;
 	struct mbox_chan *mbox_chan;
 
@@ -1755,10 +1753,6 @@  struct qcom_glink *qcom_glink_native_probe(struct device *dev,
 	if (ret)
 		dev_err(dev, "failed to add groups\n");
 
-	ret = of_property_read_string(dev->of_node, "label", &glink->name);
-	if (ret < 0)
-		glink->name = dev->of_node->name;
-
 	glink->mbox_client.dev = dev;
 	glink->mbox_client.knows_txdone = true;
 	glink->mbox_chan = mbox_request_channel(&glink->mbox_client, 0);