| Message ID | 20220707102040.1859-2-ansuelsmth@gmail.com (mailing list archive) |
|---|---|
| State | Not Applicable |
| Headers | show |
| Series | [v2,1/3] hwspinlock: qcom: Add support for mmio usage to sfpb-mutex | expand |
On Thu 07 Jul 05:20 CDT 2022, Christian Marangi wrote: > Add missing hwlock for ipq8064 dtsi provided by qcom,sfpb-mutex. > > Signed-off-by: Christian Marangi <ansuelsmth@gmail.com> > Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > --- > arch/arm/boot/dts/qcom-ipq8064.dtsi | 7 +++++++ > 1 file changed, 7 insertions(+) > > diff --git a/arch/arm/boot/dts/qcom-ipq8064.dtsi b/arch/arm/boot/dts/qcom-ipq8064.dtsi > index 4b475d98343c..cd1b43e2cab4 100644 > --- a/arch/arm/boot/dts/qcom-ipq8064.dtsi > +++ b/arch/arm/boot/dts/qcom-ipq8064.dtsi > @@ -1224,4 +1224,11 @@ sdcc3: mmc@12180000 { > }; > }; > }; > + > + sfpb_mutex: hwlock@1200600 { This is an mmio device, so it should live under /soc, so I moved it there while applying the patch. But it would be nice if this file followed others and kept all nodes sorted by address (or name if they don't have an address). Also if addresses were padded to 8 digits, to make sorting easier. I would much appreciate if you could find the time to prepare such a patch. Thank you, Bjorn > + compatible = "qcom,sfpb-mutex"; > + reg = <0x01200600 0x100>; > + > + #hwlock-cells = <1>; > + }; > }; > -- > 2.36.1 >
On Sat, Jul 16, 2022 at 10:04:39PM -0500, Bjorn Andersson wrote: > On Thu 07 Jul 05:20 CDT 2022, Christian Marangi wrote: > > > Add missing hwlock for ipq8064 dtsi provided by qcom,sfpb-mutex. > > > > Signed-off-by: Christian Marangi <ansuelsmth@gmail.com> > > Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > > --- > > arch/arm/boot/dts/qcom-ipq8064.dtsi | 7 +++++++ > > 1 file changed, 7 insertions(+) > > > > diff --git a/arch/arm/boot/dts/qcom-ipq8064.dtsi b/arch/arm/boot/dts/qcom-ipq8064.dtsi > > index 4b475d98343c..cd1b43e2cab4 100644 > > --- a/arch/arm/boot/dts/qcom-ipq8064.dtsi > > +++ b/arch/arm/boot/dts/qcom-ipq8064.dtsi > > @@ -1224,4 +1224,11 @@ sdcc3: mmc@12180000 { > > }; > > }; > > }; > > + > > + sfpb_mutex: hwlock@1200600 { > > This is an mmio device, so it should live under /soc, so I moved it > there while applying the patch. > > > But it would be nice if this file followed others and kept all nodes > sorted by address (or name if they don't have an address). Also if > addresses were padded to 8 digits, to make sorting easier. > > I would much appreciate if you could find the time to prepare such a > patch. That will take tons of changes, but yes will make a patch to reorder all the nodes. > > > + compatible = "qcom,sfpb-mutex"; > > + reg = <0x01200600 0x100>; > > + > > + #hwlock-cells = <1>; > > + }; > > }; > > -- > > 2.36.1 > >
diff --git a/arch/arm/boot/dts/qcom-ipq8064.dtsi b/arch/arm/boot/dts/qcom-ipq8064.dtsi index 4b475d98343c..cd1b43e2cab4 100644 --- a/arch/arm/boot/dts/qcom-ipq8064.dtsi +++ b/arch/arm/boot/dts/qcom-ipq8064.dtsi @@ -1224,4 +1224,11 @@ sdcc3: mmc@12180000 { }; }; }; + + sfpb_mutex: hwlock@1200600 { + compatible = "qcom,sfpb-mutex"; + reg = <0x01200600 0x100>; + + #hwlock-cells = <1>; + }; };