| Message ID | 20221005081317.3411684-1-arnaud.pouliquen@foss.st.com (mailing list archive) |
|---|---|
| State | Accepted |
| Headers | show |
| Series | [v2] remoteproc: virtio: Fix warning on bindings by removing the of_match_table | expand |
On Wed, Oct 05, 2022 at 10:13:17AM +0200, Arnaud Pouliquen wrote: > The checkpatch tool complains that "virtio,rproc" is not documented. > But it is not possible to probe the device "rproc-virtio" by declaring > it in the device tree. So documenting it in the bindings does not make > sense. > This commit solves the checkpatch warning by suppressing the useless > of_match_table. > > Suggested-by: Rob Herring <robh@kernel.org> > Fixes: 1d7b61c06dc3 ("remoteproc: virtio: Create platform device for the remoteproc_virtio") > > Signed-off-by: Arnaud Pouliquen <arnaud.pouliquen@foss.st.com> > Reviewed-by: Rob Herring <robh@kernel.org> > > --- > Updates vs previous revision: > - replace the "of_platform.h" include by "platform_device.h", > - replace "Fix-suggested-by" by "Suggested-by", > - add Rob's Reviewed-by. > --- > drivers/remoteproc/remoteproc_virtio.c | 8 +------- > 1 file changed, 1 insertion(+), 7 deletions(-) > > diff --git a/drivers/remoteproc/remoteproc_virtio.c b/drivers/remoteproc/remoteproc_virtio.c > index a29e3b8ff69c..0e95525c1158 100644 > --- a/drivers/remoteproc/remoteproc_virtio.c > +++ b/drivers/remoteproc/remoteproc_virtio.c > @@ -13,8 +13,8 @@ > #include <linux/dma-map-ops.h> > #include <linux/dma-mapping.h> > #include <linux/export.h> > -#include <linux/of_platform.h> > #include <linux/of_reserved_mem.h> > +#include <linux/platform_device.h> > #include <linux/remoteproc.h> > #include <linux/virtio.h> > #include <linux/virtio_config.h> > @@ -593,17 +593,11 @@ static int rproc_virtio_remove(struct platform_device *pdev) > } > > /* Platform driver */ > -static const struct of_device_id rproc_virtio_match[] = { > - { .compatible = "virtio,rproc" }, > - {}, > -}; > - > static struct platform_driver rproc_virtio_driver = { > .probe = rproc_virtio_probe, > .remove = rproc_virtio_remove, > .driver = { > .name = "rproc-virtio", > - .of_match_table = rproc_virtio_match, Applied. Thanks, Mathieu > }, > }; > builtin_platform_driver(rproc_virtio_driver); > -- > 2.24.3 >
On 5/10/22 10:13, Arnaud Pouliquen wrote: > The checkpatch tool complains that "virtio,rproc" is not documented. > But it is not possible to probe the device "rproc-virtio" by declaring > it in the device tree. So documenting it in the bindings does not make > sense. Perhaps reworded a bit as: "Since it is not possible to probe the device "rproc-virtio" by declaring it in the device tree, documenting it in the bindings does not make sense." Otherwise: Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org> > This commit solves the checkpatch warning by suppressing the useless > of_match_table. > > Suggested-by: Rob Herring <robh@kernel.org> > Fixes: 1d7b61c06dc3 ("remoteproc: virtio: Create platform device for the remoteproc_virtio") > > Signed-off-by: Arnaud Pouliquen <arnaud.pouliquen@foss.st.com> > Reviewed-by: Rob Herring <robh@kernel.org> > > --- > Updates vs previous revision: > - replace the "of_platform.h" include by "platform_device.h", > - replace "Fix-suggested-by" by "Suggested-by", > - add Rob's Reviewed-by. > --- > drivers/remoteproc/remoteproc_virtio.c | 8 +------- > 1 file changed, 1 insertion(+), 7 deletions(-)
diff --git a/drivers/remoteproc/remoteproc_virtio.c b/drivers/remoteproc/remoteproc_virtio.c index a29e3b8ff69c..0e95525c1158 100644 --- a/drivers/remoteproc/remoteproc_virtio.c +++ b/drivers/remoteproc/remoteproc_virtio.c @@ -13,8 +13,8 @@ #include <linux/dma-map-ops.h> #include <linux/dma-mapping.h> #include <linux/export.h> -#include <linux/of_platform.h> #include <linux/of_reserved_mem.h> +#include <linux/platform_device.h> #include <linux/remoteproc.h> #include <linux/virtio.h> #include <linux/virtio_config.h> @@ -593,17 +593,11 @@ static int rproc_virtio_remove(struct platform_device *pdev) } /* Platform driver */ -static const struct of_device_id rproc_virtio_match[] = { - { .compatible = "virtio,rproc" }, - {}, -}; - static struct platform_driver rproc_virtio_driver = { .probe = rproc_virtio_probe, .remove = rproc_virtio_remove, .driver = { .name = "rproc-virtio", - .of_match_table = rproc_virtio_match, }, }; builtin_platform_driver(rproc_virtio_driver);
The checkpatch tool complains that "virtio,rproc" is not documented. But it is not possible to probe the device "rproc-virtio" by declaring it in the device tree. So documenting it in the bindings does not make sense. This commit solves the checkpatch warning by suppressing the useless of_match_table. Suggested-by: Rob Herring <robh@kernel.org> Fixes: 1d7b61c06dc3 ("remoteproc: virtio: Create platform device for the remoteproc_virtio") Signed-off-by: Arnaud Pouliquen <arnaud.pouliquen@foss.st.com> Reviewed-by: Rob Herring <robh@kernel.org> --- Updates vs previous revision: - replace the "of_platform.h" include by "platform_device.h", - replace "Fix-suggested-by" by "Suggested-by", - add Rob's Reviewed-by. --- drivers/remoteproc/remoteproc_virtio.c | 8 +------- 1 file changed, 1 insertion(+), 7 deletions(-)