| Message ID | 20230316084011.99613-1-yang.lee@linux.alibaba.com (mailing list archive) |
|---|---|
| State | Accepted |
| Headers | show |
| Series | [-next] remoteproc/mtk_scp: Fix one kernel-doc comment | expand |
Il 16/03/23 09:40, Yang Li ha scritto: > Fixs the function name in kernel-doc comments to clear the below > warning: > > drivers/remoteproc/mtk_scp_ipi.c:136: warning: expecting prototype for scp_ipi_lock(). Prototype was for scp_ipi_unlock() instead > > Reported-by: Abaci Robot <abaci@linux.alibaba.com> > Link: https://bugzilla.openanolis.cn/show_bug.cgi?id=4544 > Signed-off-by: Yang Li <yang.lee@linux.alibaba.com> Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
On 3/16/2023 2:10 PM, Yang Li wrote: > Fixs the function name in kernel-doc comments to clear the below nit: Fix > warning: > > drivers/remoteproc/mtk_scp_ipi.c:136: warning: expecting prototype for scp_ipi_lock(). Prototype was for scp_ipi_unlock() instead > > Reported-by: Abaci Robot <abaci@linux.alibaba.com> > Link: https://bugzilla.openanolis.cn/show_bug.cgi?id=4544 > Signed-off-by: Yang Li <yang.lee@linux.alibaba.com> > --- > drivers/remoteproc/mtk_scp_ipi.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/remoteproc/mtk_scp_ipi.c b/drivers/remoteproc/mtk_scp_ipi.c > index fc55df649b40..9c7c17b9d181 100644 > --- a/drivers/remoteproc/mtk_scp_ipi.c > +++ b/drivers/remoteproc/mtk_scp_ipi.c > @@ -125,7 +125,7 @@ void scp_ipi_lock(struct mtk_scp *scp, u32 id) > EXPORT_SYMBOL_GPL(scp_ipi_lock); > > /** > - * scp_ipi_lock() - Unlock after operations of an IPI ID > + * scp_ipi_unlock() - Unlock after operations of an IPI ID > * > * @scp: mtk_scp structure > * @id: IPI ID Otherwise LGTM. Reviewed-by: Mukesh Ojha <quic_mojha@quicinc.com> -- Mukesh
On Thu, Mar 16, 2023 at 04:40:11PM +0800, Yang Li wrote: > Fixs the function name in kernel-doc comments to clear the below > warning: > > drivers/remoteproc/mtk_scp_ipi.c:136: warning: expecting prototype for scp_ipi_lock(). Prototype was for scp_ipi_unlock() instead > > Reported-by: Abaci Robot <abaci@linux.alibaba.com> > Link: https://bugzilla.openanolis.cn/show_bug.cgi?id=4544 > Signed-off-by: Yang Li <yang.lee@linux.alibaba.com> > --- > drivers/remoteproc/mtk_scp_ipi.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/remoteproc/mtk_scp_ipi.c b/drivers/remoteproc/mtk_scp_ipi.c > index fc55df649b40..9c7c17b9d181 100644 > --- a/drivers/remoteproc/mtk_scp_ipi.c > +++ b/drivers/remoteproc/mtk_scp_ipi.c > @@ -125,7 +125,7 @@ void scp_ipi_lock(struct mtk_scp *scp, u32 id) > EXPORT_SYMBOL_GPL(scp_ipi_lock); > > /** > - * scp_ipi_lock() - Unlock after operations of an IPI ID > + * scp_ipi_unlock() - Unlock after operations of an IPI ID I have applied this patch. Thanks, Mathieu > * > * @scp: mtk_scp structure > * @id: IPI ID > -- > 2.20.1.7.g153144c >
diff --git a/drivers/remoteproc/mtk_scp_ipi.c b/drivers/remoteproc/mtk_scp_ipi.c index fc55df649b40..9c7c17b9d181 100644 --- a/drivers/remoteproc/mtk_scp_ipi.c +++ b/drivers/remoteproc/mtk_scp_ipi.c @@ -125,7 +125,7 @@ void scp_ipi_lock(struct mtk_scp *scp, u32 id) EXPORT_SYMBOL_GPL(scp_ipi_lock); /** - * scp_ipi_lock() - Unlock after operations of an IPI ID + * scp_ipi_unlock() - Unlock after operations of an IPI ID * * @scp: mtk_scp structure * @id: IPI ID
Fixs the function name in kernel-doc comments to clear the below warning: drivers/remoteproc/mtk_scp_ipi.c:136: warning: expecting prototype for scp_ipi_lock(). Prototype was for scp_ipi_unlock() instead Reported-by: Abaci Robot <abaci@linux.alibaba.com> Link: https://bugzilla.openanolis.cn/show_bug.cgi?id=4544 Signed-off-by: Yang Li <yang.lee@linux.alibaba.com> --- drivers/remoteproc/mtk_scp_ipi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)