diff mbox series

remoteproc: qcom: pas: mark adsp_segment_dump() static

Message ID 20230516202332.560123-1-arnd@kernel.org (mailing list archive)
State Superseded
Headers show
Series remoteproc: qcom: pas: mark adsp_segment_dump() static | expand

Commit Message

Arnd Bergmann May 16, 2023, 8:23 p.m. UTC 
From: Arnd Bergmann <arnd@arndb.de>

The function has no other callers and should not be globally defined.
Making it static avoids this warning:

drivers/remoteproc/qcom_q6v5_pas.c:108:6: error: no previous prototype for 'adsp_segment_dump'

Fixes: a376c10d45a8 ("remoteproc: qcom: pas: Adjust the phys addr wrt the mem region")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
 drivers/remoteproc/qcom_q6v5_pas.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

Comments

Mukesh Ojha May 18, 2023, 7:47 a.m. UTC | #1 
On 5/17/2023 1:53 AM, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@arndb.de>
> 
> The function has no other callers and should not be globally defined.
> Making it static avoids this warning:
> 
> drivers/remoteproc/qcom_q6v5_pas.c:108:6: error: no previous prototype for 'adsp_segment_dump'
> 
> Fixes: a376c10d45a8 ("remoteproc: qcom: pas: Adjust the phys addr wrt the mem region")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>

This seems to be posted already

https://lore.kernel.org/lkml/20230507144826.193067-1-krzysztof.kozlowski@linaro.org/

-- Mukesh

> ---
>   drivers/remoteproc/qcom_q6v5_pas.c | 5 +++--
>   1 file changed, 3 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/remoteproc/qcom_q6v5_pas.c b/drivers/remoteproc/qcom_q6v5_pas.c
> index e34d82b18a67..a1d69721a0e7 100644
> --- a/drivers/remoteproc/qcom_q6v5_pas.c
> +++ b/drivers/remoteproc/qcom_q6v5_pas.c
> @@ -105,8 +105,9 @@ struct qcom_adsp {
>   	struct qcom_scm_pas_metadata dtb_pas_metadata;
>   };
>   
> -void adsp_segment_dump(struct rproc *rproc, struct rproc_dump_segment *segment,
> -		       void *dest, size_t offset, size_t size)
> +static void adsp_segment_dump(struct rproc *rproc,
> +			      struct rproc_dump_segment *segment,
> +			      void *dest, size_t offset, size_t size)
>   {
>   	struct qcom_adsp *adsp = rproc->priv;
>   	int total_offset;
diff mbox series

Patch

diff --git a/drivers/remoteproc/qcom_q6v5_pas.c b/drivers/remoteproc/qcom_q6v5_pas.c
index e34d82b18a67..a1d69721a0e7 100644
--- a/drivers/remoteproc/qcom_q6v5_pas.c
+++ b/drivers/remoteproc/qcom_q6v5_pas.c
@@ -105,8 +105,9 @@  struct qcom_adsp {
 	struct qcom_scm_pas_metadata dtb_pas_metadata;
 };
 
-void adsp_segment_dump(struct rproc *rproc, struct rproc_dump_segment *segment,
-		       void *dest, size_t offset, size_t size)
+static void adsp_segment_dump(struct rproc *rproc,
+			      struct rproc_dump_segment *segment,
+			      void *dest, size_t offset, size_t size)
 {
 	struct qcom_adsp *adsp = rproc->priv;
 	int total_offset;