| Message ID | 20230817083336.404635-1-chenjiahao16@huawei.com (mailing list archive) |
|---|---|
| State | Accepted |
| Headers | show |
| Series | [-next,v2] remoteproc: stm32: Clean up redundant dev_err_probe() | expand |
Hi chen On 8/17/23 10:33, Chen Jiahao wrote: > Referring to platform_get_irq()'s definition, the return value has > already been checked if ret < 0, and printed via dev_err_probe(). > Calling dev_err_probe() one more time outside platform_get_irq() > is obviously redundant. Removing outside dev_err_probe() to > clean it up. > > Besides, switch to use platform_get_irq_optional() since the irq > is optional here. > > Signed-off-by: Chen Jiahao <chenjiahao16@huawei.com> Sorry for the late answer, my company's mail server drop the email :( Acked-by: Arnaud Pouliquen <arnaud.pouliquen@foss.st.com> Thanks! Arnaud > --- > drivers/remoteproc/stm32_rproc.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/remoteproc/stm32_rproc.c b/drivers/remoteproc/stm32_rproc.c > index 98234b44f038..1f53c672c66b 100644 > --- a/drivers/remoteproc/stm32_rproc.c > +++ b/drivers/remoteproc/stm32_rproc.c > @@ -712,9 +712,9 @@ static int stm32_rproc_parse_dt(struct platform_device *pdev, > unsigned int tzen; > int err, irq; > > - irq = platform_get_irq(pdev, 0); > + irq = platform_get_irq_optional(pdev, 0); > if (irq == -EPROBE_DEFER) > - return dev_err_probe(dev, irq, "failed to get interrupt\n"); > + return irq; > > if (irq > 0) { > err = devm_request_irq(dev, irq, stm32_rproc_wdg, 0,
On Thu, Aug 17, 2023 at 04:33:36PM +0800, Chen Jiahao wrote: > Referring to platform_get_irq()'s definition, the return value has > already been checked if ret < 0, and printed via dev_err_probe(). > Calling dev_err_probe() one more time outside platform_get_irq() > is obviously redundant. Removing outside dev_err_probe() to > clean it up. > > Besides, switch to use platform_get_irq_optional() since the irq > is optional here. > > Signed-off-by: Chen Jiahao <chenjiahao16@huawei.com> > --- > drivers/remoteproc/stm32_rproc.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > Applied. Thanks, Mathieu > diff --git a/drivers/remoteproc/stm32_rproc.c b/drivers/remoteproc/stm32_rproc.c > index 98234b44f038..1f53c672c66b 100644 > --- a/drivers/remoteproc/stm32_rproc.c > +++ b/drivers/remoteproc/stm32_rproc.c > @@ -712,9 +712,9 @@ static int stm32_rproc_parse_dt(struct platform_device *pdev, > unsigned int tzen; > int err, irq; > > - irq = platform_get_irq(pdev, 0); > + irq = platform_get_irq_optional(pdev, 0); > if (irq == -EPROBE_DEFER) > - return dev_err_probe(dev, irq, "failed to get interrupt\n"); > + return irq; > > if (irq > 0) { > err = devm_request_irq(dev, irq, stm32_rproc_wdg, 0, > -- > 2.34.1 >
diff --git a/drivers/remoteproc/stm32_rproc.c b/drivers/remoteproc/stm32_rproc.c index 98234b44f038..1f53c672c66b 100644 --- a/drivers/remoteproc/stm32_rproc.c +++ b/drivers/remoteproc/stm32_rproc.c @@ -712,9 +712,9 @@ static int stm32_rproc_parse_dt(struct platform_device *pdev, unsigned int tzen; int err, irq; - irq = platform_get_irq(pdev, 0); + irq = platform_get_irq_optional(pdev, 0); if (irq == -EPROBE_DEFER) - return dev_err_probe(dev, irq, "failed to get interrupt\n"); + return irq; if (irq > 0) { err = devm_request_irq(dev, irq, stm32_rproc_wdg, 0,
Referring to platform_get_irq()'s definition, the return value has already been checked if ret < 0, and printed via dev_err_probe(). Calling dev_err_probe() one more time outside platform_get_irq() is obviously redundant. Removing outside dev_err_probe() to clean it up. Besides, switch to use platform_get_irq_optional() since the irq is optional here. Signed-off-by: Chen Jiahao <chenjiahao16@huawei.com> --- drivers/remoteproc/stm32_rproc.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)