| Message ID | 20240924044741.3078097-1-andersson@kernel.org (mailing list archive) |
|---|---|
| State | Not Applicable |
| Headers | show |
| Series | [GIT,PULL] remoteproc updates for v6.12 | expand |
On Mon, 23 Sept 2024 at 21:44, Bjorn Andersson <andersson@kernel.org> wrote: > > remoteproc updates for v6.12 Grr. I didn't immediately notice this new Kconfig warning, so now it's in my tree: WARNING: unmet direct dependencies detected for OMAP2PLUS_MBOX Depends on [n]: MAILBOX [=y] && (ARCH_OMAP2PLUS || ARCH_K3) Selected by [m]: - TI_K3_M4_REMOTEPROC [=m] && REMOTEPROC [=y] && (ARCH_K3 || COMPILE_TEST [=y]) this happens with a regular "make allmodconfig" on x86-64. This seems to have been introduced in commit ebcf9008a895 ("remoteproc: k3-m4: Add a remoteproc driver for M4F subsystem") that added the TI K3 M4 remoteproc support, which does select OMAP2PLUS_MBOX but does not actually contain the proper dependencies that OMAP2PLUS_MBOX requires.. It's in my tree now, but please fix asap. Linus
The pull request you sent on Mon, 23 Sep 2024 21:47:40 -0700:
> https://git.kernel.org/pub/scm/linux/kernel/git/remoteproc/linux.git tags/rproc-v6.12
has been merged into torvalds/linux.git:
https://git.kernel.org/torvalds/c/5c480f1da82c15f635a2b663740cb2bb241cc416
Thank you!
On Tue, 24 Sept 2024 at 12:31, Linus Torvalds <torvalds@linux-foundation.org> wrote: > > It's in my tree now, but please fix asap. Argh, now that I noticed it, I can no longer unsee it. So I did this - depends on ARCH_K3 || COMPILE_TEST + depends on ARCH_OMAP2PLUS || ARCH_K3 to the TI_K3_M4_REMOTEPROC entry so that it wouldn't try to select OMAP2PLUS_MBOX in conditions where it isn't valid. Linus
On Tue, Sep 24, 2024 at 12:52:42PM -0700, Linus Torvalds wrote: > On Tue, 24 Sept 2024 at 12:31, Linus Torvalds > <torvalds@linux-foundation.org> wrote: > > > > It's in my tree now, but please fix asap. > > Argh, now that I noticed it, I can no longer unsee it. > > So I did this > > - depends on ARCH_K3 || COMPILE_TEST > + depends on ARCH_OMAP2PLUS || ARCH_K3 > Thank you for doing this and apologies for the late reply. Mathieu > to the TI_K3_M4_REMOTEPROC entry so that it wouldn't try to select > OMAP2PLUS_MBOX in conditions where it isn't valid. > > Linus
On Tue, 2024-09-24 at 12:31 -0700, Linus Torvalds wrote: > On Mon, 23 Sept 2024 at 21:44, Bjorn Andersson <andersson@kernel.org> > wrote: > > > > remoteproc updates for v6.12 > > Grr. I didn't immediately notice this new Kconfig warning, so now > it's > in my tree: > > WARNING: unmet direct dependencies detected for OMAP2PLUS_MBOX > Depends on [n]: MAILBOX [=y] && (ARCH_OMAP2PLUS || ARCH_K3) > Selected by [m]: > - TI_K3_M4_REMOTEPROC [=m] && REMOTEPROC [=y] && (ARCH_K3 || > COMPILE_TEST [=y]) > > this happens with a regular "make allmodconfig" on x86-64. > > This seems to have been introduced in commit ebcf9008a895 > ("remoteproc: k3-m4: Add a remoteproc driver for M4F subsystem") that > added the TI K3 M4 remoteproc support, which does > > select OMAP2PLUS_MBOX > > but does not actually contain the proper dependencies that > OMAP2PLUS_MBOX requires.. > > It's in my tree now, but please fix asap. > > Linus Both myself and Arnd have submitted patches to fix this. It seems that either have been applied... 29 Aug 2024 - [PATCH] mailbox: omap: Enable COMPILE_TEST for OMAP2+ Mailbox framework support https://lore.kernel.org/all/010201919d8b298f-dd1585dd-7c4d-4865-9483-ff6cd7399a90-000000@eu-west-1.amazonses.com/ 9 Sep 2024 - [PATCH] mailbox, remoteproc: omap2+: fix compile testing https://lore.kernel.org/all/20240909203825.1666947-1-arnd@kernel.org/ Martyn
The following changes since commit 8400291e289ee6b2bf9779ff1c83a291501f017b: Linux 6.11-rc1 (2024-07-28 14:19:55 -0700) are available in the Git repository at: https://git.kernel.org/pub/scm/linux/kernel/git/remoteproc/linux.git tags/rproc-v6.12 for you to fetch changes up to 38a0e38b31d3f967525f6414711bed6f14dfa15e: remoteporc: ingenic: Use devm_platform_ioremap_resource_byname() (2024-09-09 09:50:54 -0600) ---------------------------------------------------------------- remoteproc updates for v6.12 This adds remoteproc support for the Cortex M4F found in AM62x and AM64x of the TI K3 family, support for the modem remoteproc in the Qualcomm SDX75, and audio, compute and general-purpose DSPs of the Qualcomm SA8775P. The i.MX remoteproc driver gains support for blocking and non-blocking mailbox transmissions, followed by the implementation of poweroff and reboot mechanisms, using the same. This is followed by a few bug fixes and minor improvements. A few cleanups and bug fixes for the TI K3 DSP and R5F drivers are introduced. Support for mapping SRAM regions into the AMD-Xilinx Zynqmp R5 cores is added. The Ingenic, TI DA8xx, TI Keystone, TI K3, ST slim drivers are simplified using devres helpers for various allocations. Uses of of_{find,get}_property() are replaced with of_property_present() where possible. ---------------------------------------------------------------- Andrew Davis (3): remoteproc: keystone: Use devm_kasprintf() to build name string remoteproc: keystone: Use devm_rproc_alloc() helper remoteproc: k3: Factor out TI-SCI processor control OF get function Beleswar Padhi (3): remoteproc: k3-r5: Use devm_rproc_alloc() helper remoteproc: k3-r5: Acquire mailbox handle during probe routine remoteproc: k3-dsp: Acquire mailbox handle during probe routine Hari Nagalla (1): dt-bindings: remoteproc: k3-m4f: Add K3 AM64x SoCs Jan Kiszka (1): remoteproc: k3-r5: Fix error handling when power-up failed Krzysztof Kozlowski (1): dt-bindings: remoteproc: xlnx,zynqmp-r5fss: Add missing "additionalProperties" on child nodes Martyn Welch (1): remoteproc: k3-m4: Add a remoteproc driver for M4F subsystem Naina Mehta (2): dt-bindings: remoteproc: qcom,sm8550-pas: document the SDX75 PAS remoteproc: qcom: pas: Add SDX75 remoteproc support Peng Fan (6): remoteproc: imx_rproc: Correct ddr alias for i.MX8M remoteproc: imx_rproc: Use imx specific hook for find_loaded_rsc_table remoteproc: imx_rproc: Initialize workqueue earlier remoteproc: imx_rproc: Merge TCML/U remoteproc: imx_rproc: Allow setting of the mailbox transmit mode remoteproc: imx_rproc: Add support for poweroff and reboot Rob Herring (Arm) (1): remoteproc: Use of_property_present() Tanmay Shah (1): remoteproc: xlnx: Add sram support Tengfei Fan (1): remoteproc: qcom: pas: Add support for SA8775p ADSP, CDSP and GPDSP Udit Kumar (1): remoteproc: k3-r5: Delay notification of wakeup event Zhang Zekun (3): remoteproc: st_slim: Use devm_platform_ioremap_resource_byname() remoteproc: da8xx: Use devm_platform_ioremap_resource_byname() remoteporc: ingenic: Use devm_platform_ioremap_resource_byname() .../bindings/remoteproc/qcom,sm8550-pas.yaml | 3 + .../bindings/remoteproc/ti,k3-m4f-rproc.yaml | 125 ++++ .../bindings/remoteproc/xlnx,zynqmp-r5fss.yaml | 1 + drivers/remoteproc/Kconfig | 13 + drivers/remoteproc/Makefile | 1 + drivers/remoteproc/da8xx_remoteproc.c | 10 +- drivers/remoteproc/imx_dsp_rproc.c | 2 +- drivers/remoteproc/imx_rproc.c | 93 ++- drivers/remoteproc/imx_rproc.h | 4 + drivers/remoteproc/ingenic_rproc.c | 3 +- drivers/remoteproc/keystone_remoteproc.c | 21 +- drivers/remoteproc/qcom_q6v5_pas.c | 93 +++ drivers/remoteproc/st_slim_rproc.c | 6 +- drivers/remoteproc/ti_k3_dsp_remoteproc.c | 108 +--- drivers/remoteproc/ti_k3_m4_remoteproc.c | 667 +++++++++++++++++++++ drivers/remoteproc/ti_k3_r5_remoteproc.c | 130 ++-- drivers/remoteproc/ti_sci_proc.h | 26 + drivers/remoteproc/xlnx_r5_remoteproc.c | 141 ++++- 18 files changed, 1225 insertions(+), 222 deletions(-) create mode 100644 Documentation/devicetree/bindings/remoteproc/ti,k3-m4f-rproc.yaml create mode 100644 drivers/remoteproc/ti_k3_m4_remoteproc.c