From patchwork Thu Mar 8 09:36:08 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arvind Yadav X-Patchwork-Id: 10267351 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 99E866016D for ; Thu, 8 Mar 2018 09:37:38 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 89931297AE for ; Thu, 8 Mar 2018 09:37:38 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 7CD6E297B9; Thu, 8 Mar 2018 09:37:38 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=2.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, FREEMAIL_FROM, RCVD_IN_DNSWL_HI, T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 34F86297AE for ; Thu, 8 Mar 2018 09:37:38 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933352AbeCHJhU (ORCPT ); Thu, 8 Mar 2018 04:37:20 -0500 Received: from mail-io0-f196.google.com ([209.85.223.196]:40580 "EHLO mail-io0-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755238AbeCHJhD (ORCPT ); Thu, 8 Mar 2018 04:37:03 -0500 Received: by mail-io0-f196.google.com with SMTP id v6so6365895iog.7; Thu, 08 Mar 2018 01:37:03 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :in-reply-to:references; bh=iaaFwkp2zPB8scgN6Ep0ztvv+d3n0Ni1wZ7rm67Yojc=; b=RR7GQSJuNfrKy6MF259fl8sPKZsiE4TgfUs2m1uU2ftTsBMIGrWGeauoeud6Df9ikT zPd1iRe2eHVkVGTj+5ap478SZuJk6HV/0JZf41tIy6oi2LQtibE1GfG4zXhPFOaXqvEp e9pb/u+ZlGgoQBMN1fxkBV2Mg7qIB0krLZ4V09JGTq54posEqODgw3ZIh2WqJGAmi5KZ QhWmijjuavTW6zPZFgnx4d/VER+yLpsg8XOhDsMgbookITQ/q559fI9aQ8JcLkM/ev3r XqcjQ3EWjQG1rtdiaIWyOm11lSFrlXdtlqV95tQ8stFV1gZZn3j7f+u1rX1BvDcz79oA gJJw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:in-reply-to:references; bh=iaaFwkp2zPB8scgN6Ep0ztvv+d3n0Ni1wZ7rm67Yojc=; b=PqQTVOG8engKx+W/DxKLMk9IkfKckuN4Cr77i72ElCNqhFOLx8iBZO1yZ5CL1oECEI 81nByxnHjFIoqARp/o3c+JpKhn1IQ/zhkcf7QIzP/YT+V5YaSjZXQ1jl3e4iCdqlK28c VgJXPeHGb1t8q+XX3J+5UyjmyiszB62dqVZuU8QszuT2v48kE3q9/lkfVs8A0ZJIhIS5 /Fl59RK9U+WZVXz7l2L4Xg4BJ5UZJEn4IZfoAB4dTtJ/k8Ta+HTQn04VLTBfQKzMGFqx TLx9Pl+h4lsZEAWHg8MqBGHZasYkY297ibTSSbXNwaEeNzYO7URKphbIvSxtHYw9h7ke IMJg== X-Gm-Message-State: APf1xPAvEhWomkIxsC8MLP8lrFSrPNmVekdWKuF5Kbfpj7ZImNEBshiE 3KOFH4ibTeWS4c4zE+0LsYs= X-Google-Smtp-Source: AG47ELsX4NNGOYXV3pfj58HSaNfg+FdHJhe1YAfIowlERZY8TAcZHEpDkWAV/2Nu1LYOYCcdwxwEmA== X-Received: by 10.107.133.42 with SMTP id h42mr29669070iod.227.1520501822743; Thu, 08 Mar 2018 01:37:02 -0800 (PST) Received: from symbol-HP-Z420-Workstation.zebra.lan ([149.23.17.254]) by smtp.googlemail.com with ESMTPSA id w37sm13977310ioi.1.2018.03.08.01.37.00 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Thu, 08 Mar 2018 01:37:02 -0800 (PST) From: Arvind Yadav To: ohad@wizery.com, bjorn.andersson@linaro.org Cc: linux-kernel@vger.kernel.org, linux-remoteproc@vger.kernel.org Subject: [PATCH 2/2] rpmsg: smd: use put_device() if device_register fail Date: Thu, 8 Mar 2018 15:06:08 +0530 Message-Id: <340cac8a81a84cf3054f8adcdb169f740b212c34.1520501519.git.arvind.yadav.cs@gmail.com> X-Mailer: git-send-email 1.9.1 In-Reply-To: References: In-Reply-To: References: Sender: linux-remoteproc-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-remoteproc@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP if device_register() returned an error! Always use put_device() to give up the reference initialized. unregister device for other return error. Signed-off-by: Arvind Yadav --- drivers/rpmsg/qcom_smd.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/rpmsg/qcom_smd.c b/drivers/rpmsg/qcom_smd.c index 92d0c6a..ff8101a 100644 --- a/drivers/rpmsg/qcom_smd.c +++ b/drivers/rpmsg/qcom_smd.c @@ -1408,6 +1408,7 @@ struct qcom_smd_edge *qcom_smd_register_edge(struct device *parent, ret = device_register(&edge->dev); if (ret) { pr_err("failed to register smd edge\n"); + put_device(&edge->dev); return ERR_PTR(ret); } @@ -1428,7 +1429,7 @@ struct qcom_smd_edge *qcom_smd_register_edge(struct device *parent, return edge; unregister_dev: - put_device(&edge->dev); + device_unregister(&edge->dev); return ERR_PTR(ret); } EXPORT_SYMBOL(qcom_smd_register_edge);