| Message ID | 6f457246-6446-42cb-81ae-d37221d726b1@kili.mountain (mailing list archive) |
|---|---|
| State | Accepted |
| Headers | show |
| Series | remoteproc: stm32: Fix error code in stm32_rproc_parse_dt() | expand |
Hello Dan, On 5/22/23 09:46, Dan Carpenter wrote: > There is a cut and paste bug so this code was returning the wrong > variable. It should have been "ddata->hold_boot_rst" instead of > "ddata->rst". > > Fixes: de598695a2ad ("remoteproc: stm32: Allow hold boot management by the SCMI reset controller") > Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org> > --- > drivers/remoteproc/stm32_rproc.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/remoteproc/stm32_rproc.c b/drivers/remoteproc/stm32_rproc.c > index 0e322697d210..a7457777aae4 100644 > --- a/drivers/remoteproc/stm32_rproc.c > +++ b/drivers/remoteproc/stm32_rproc.c > @@ -755,7 +755,7 @@ static int stm32_rproc_parse_dt(struct platform_device *pdev, > > ddata->hold_boot_rst = devm_reset_control_get_optional(dev, "hold_boot"); > if (IS_ERR(ddata->hold_boot_rst)) > - return dev_err_probe(dev, PTR_ERR(ddata->rst), > + return dev_err_probe(dev, PTR_ERR(ddata->hold_boot_rst), > "failed to get hold_boot reset\n"); Good catch! Reviewed-by: Arnaud Pouliquen <arnaud.pouliquen@foss.st.com> Thanks, Arnaud > > if (!ddata->hold_boot_rst && IS_ENABLED(CONFIG_HAVE_ARM_SMCCC)) {
On Mon, May 22, 2023 at 10:46:11AM +0300, Dan Carpenter wrote: > There is a cut and paste bug so this code was returning the wrong > variable. It should have been "ddata->hold_boot_rst" instead of > "ddata->rst". > > Fixes: de598695a2ad ("remoteproc: stm32: Allow hold boot management by the SCMI reset controller") > Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org> > --- > drivers/remoteproc/stm32_rproc.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/remoteproc/stm32_rproc.c b/drivers/remoteproc/stm32_rproc.c > index 0e322697d210..a7457777aae4 100644 > --- a/drivers/remoteproc/stm32_rproc.c > +++ b/drivers/remoteproc/stm32_rproc.c > @@ -755,7 +755,7 @@ static int stm32_rproc_parse_dt(struct platform_device *pdev, > > ddata->hold_boot_rst = devm_reset_control_get_optional(dev, "hold_boot"); > if (IS_ERR(ddata->hold_boot_rst)) > - return dev_err_probe(dev, PTR_ERR(ddata->rst), > + return dev_err_probe(dev, PTR_ERR(ddata->hold_boot_rst), > "failed to get hold_boot reset\n"); I have applied this patch. Thanks, Mathieu > > if (!ddata->hold_boot_rst && IS_ENABLED(CONFIG_HAVE_ARM_SMCCC)) { > -- > 2.39.2 >
diff --git a/drivers/remoteproc/stm32_rproc.c b/drivers/remoteproc/stm32_rproc.c index 0e322697d210..a7457777aae4 100644 --- a/drivers/remoteproc/stm32_rproc.c +++ b/drivers/remoteproc/stm32_rproc.c @@ -755,7 +755,7 @@ static int stm32_rproc_parse_dt(struct platform_device *pdev, ddata->hold_boot_rst = devm_reset_control_get_optional(dev, "hold_boot"); if (IS_ERR(ddata->hold_boot_rst)) - return dev_err_probe(dev, PTR_ERR(ddata->rst), + return dev_err_probe(dev, PTR_ERR(ddata->hold_boot_rst), "failed to get hold_boot reset\n"); if (!ddata->hold_boot_rst && IS_ENABLED(CONFIG_HAVE_ARM_SMCCC)) {
There is a cut and paste bug so this code was returning the wrong variable. It should have been "ddata->hold_boot_rst" instead of "ddata->rst". Fixes: de598695a2ad ("remoteproc: stm32: Allow hold boot management by the SCMI reset controller") Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org> --- drivers/remoteproc/stm32_rproc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)