| Message ID | PA4P189MB14210AA95DCA3715AFA7F4A68BB59@PA4P189MB1421.EURP189.PROD.OUTLOOK.COM (mailing list archive) |
|---|---|
| State | Accepted |
| Headers | show |
| Series | [v1] rpmsg: strcpy is not safe, use strscpy_pad() instead | expand |
On Thu, Jun 23, 2022 at 02:20:47PM +0500, Saud Farooqui wrote: > Replace strcpy() with strscpy_pad() for copying the rpmsg > device name in rpmsg_register_device_override(). > > Reported-by: kernel test robot <lkp@intel.com> > Signed-off-by: Saud Farooqui <farooqui_saud@hotmail.com> > --- > drivers/rpmsg/rpmsg_core.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/rpmsg/rpmsg_core.c b/drivers/rpmsg/rpmsg_core.c > index 290c1f02da10..a4bad4b00414 100644 > --- a/drivers/rpmsg/rpmsg_core.c > +++ b/drivers/rpmsg/rpmsg_core.c > @@ -604,7 +604,7 @@ int rpmsg_register_device_override(struct rpmsg_device *rpdev, > int ret; > > if (driver_override) > - strcpy(rpdev->id.name, driver_override); > + strscpy_pad(rpdev->id.name, driver_override, RPMSG_NAME_SIZE); Applied. Thanks, Mathieu > > dev_set_name(dev, "%s.%s.%d.%d", dev_name(dev->parent), > rpdev->id.name, rpdev->src, rpdev->dst); > -- > 2.25.1 >
diff --git a/drivers/rpmsg/rpmsg_core.c b/drivers/rpmsg/rpmsg_core.c index 290c1f02da10..a4bad4b00414 100644 --- a/drivers/rpmsg/rpmsg_core.c +++ b/drivers/rpmsg/rpmsg_core.c @@ -604,7 +604,7 @@ int rpmsg_register_device_override(struct rpmsg_device *rpdev, int ret; if (driver_override) - strcpy(rpdev->id.name, driver_override); + strscpy_pad(rpdev->id.name, driver_override, RPMSG_NAME_SIZE); dev_set_name(dev, "%s.%s.%d.%d", dev_name(dev->parent), rpdev->id.name, rpdev->src, rpdev->dst);
Replace strcpy() with strscpy_pad() for copying the rpmsg device name in rpmsg_register_device_override(). Reported-by: kernel test robot <lkp@intel.com> Signed-off-by: Saud Farooqui <farooqui_saud@hotmail.com> --- drivers/rpmsg/rpmsg_core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)