mbox series

[v2,0/4] I2C0/3/5 pin control for H3 and M3-W

Message ID 1542352851-25393-1-git-send-email-uli+renesas@fpond.eu (mailing list archive)
Headers show
Series I2C0/3/5 pin control for H3 and M3-W | expand

Message

Ulrich Hecht Nov. 16, 2018, 7:20 a.m. UTC
This is an up-port from the BSP. Unfortunately I could not test these
because none of those pins seem to be accessible on Salvator boards (not on
ULCB either, AFAICT), so the best thing I can say is that they don't seem to
break anything.

This revision incorporates the suggestions made by Geert; see below for
details.

CU
Uli


Changes since v1:
- factor out identical macros to sh_pfc.h, comment them
- sort pin groups
- adjust for common/automotive split in r8a7796


Takeshi Kihara (3):
  pinctrl: sh-pfc: r8a7795: Add I2C{0,3,5} pins, groups and functions
  pinctrl: sh-pfc: r8a7795-es1: Add I2C{0,3,5} pins, groups and
    functions
  pinctrl: sh-pfc: r8a7796: Add I2C{0,3,5} pins, groups and functions

Ulrich Hecht (1):
  pinctrl: sh-pfc: Add physical pin multiplexing helper macros

 drivers/pinctrl/sh-pfc/pfc-r8a7795-es1.c | 97 ++++++++++++++++++++++++-------
 drivers/pinctrl/sh-pfc/pfc-r8a7795.c     | 95 ++++++++++++++++++++++++-------
 drivers/pinctrl/sh-pfc/pfc-r8a7796.c     | 98 +++++++++++++++++++++++++-------
 drivers/pinctrl/sh-pfc/sh_pfc.h          | 22 +++++++
 4 files changed, 248 insertions(+), 64 deletions(-)

Comments

Geert Uytterhoeven Nov. 16, 2018, 8:30 a.m. UTC | #1
Hi Uli,

On Fri, Nov 16, 2018 at 8:21 AM Ulrich Hecht <uli+renesas@fpond.eu> wrote:
> This is an up-port from the BSP. Unfortunately I could not test these
> because none of those pins seem to be accessible on Salvator boards (not on
> ULCB either, AFAICT), so the best thing I can say is that they don't seem to
> break anything.

I think I replied before...

For Salvator-X(S):
  1. If you set SW5 and SW6 to their center positions, you can access I2C3 on
     EXIO Connector D.
  2. I2C5 is available on test points CP45/46.

> This revision incorporates the suggestions made by Geert; see below for
> details.

Thanks for the update!

Gr{oetje,eeting}s,

                        Geert
Wolfram Sang Dec. 5, 2018, 9:23 p.m. UTC | #2
Hi Uli,

>   pinctrl: sh-pfc: r8a7795: Add I2C{0,3,5} pins, groups and functions
>   pinctrl: sh-pfc: r8a7795-es1: Add I2C{0,3,5} pins, groups and
>     functions
>   pinctrl: sh-pfc: r8a7796: Add I2C{0,3,5} pins, groups and functions

The BSP also has a similar patch for r8a77965. Could you also take care
of that?

Happy hacking,

   Wolfram