From patchwork Wed Nov 21 11:21:08 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Magnus Damm X-Patchwork-Id: 10692439 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 08C8A16B1 for ; Wed, 21 Nov 2018 11:20:52 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id EB6012B80C for ; Wed, 21 Nov 2018 11:20:51 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id DF3412B96D; Wed, 21 Nov 2018 11:20:51 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.7 required=2.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, DKIM_INVALID,DKIM_SIGNED,FREEMAIL_FROM,MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 80F122B80C for ; Wed, 21 Nov 2018 11:20:51 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730188AbeKUVyv (ORCPT ); Wed, 21 Nov 2018 16:54:51 -0500 Received: from mail-pl1-f193.google.com ([209.85.214.193]:41385 "EHLO mail-pl1-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726016AbeKUVyv (ORCPT ); Wed, 21 Nov 2018 16:54:51 -0500 Received: by mail-pl1-f193.google.com with SMTP id u6so5110665plm.8; Wed, 21 Nov 2018 03:20:50 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:date:message-id:subject; bh=nw6dc5iZbSCPR03grqUq+UNCgBQdZ4fARGVnrZPG1Kw=; b=En1k98HdNtd3kRcWX2E33XTbSmzakcaDsYhFBVollVQtb3H0NGZ0cl7ARgqWwDNTqf H1LaidqbITEf0HZA8Fatak3j+QPbvxy5wZxCs7Epv0h2yZi0y2xB5kl+vy2YOAiIKM0x MKzqzDa8sTcM8GZkv7d3RGWTn6Ct/tRO5vyMnvxsyy8b/rElQRdAC0vfOLfoXcc595o8 cD34Oc35Ls83X8RzCzDzaeLS6+pVxdiDJJdfW5WG8YeMJoHjoZxucal7CmGlNtz+nCz3 Fh4QC62upVIOOiwfrOl+OzWIsnoytJM5BVXoAgqsxDxbR//0Ov5Ss9rK70Q9NOfApv12 Wx+w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:date:message-id:subject; bh=nw6dc5iZbSCPR03grqUq+UNCgBQdZ4fARGVnrZPG1Kw=; b=g0mBYFVHT1sb9zXyoqPJVq5wppja65DKV0l82eIPNzX5JaI9buN31RshVRKVg+Jv3O WbTzPR2ABtZEGA0Qc3g/yxdHezAQm1pzHJczRzxuDLRIm6XRQk8zjb0VvJcnV8ReKYAi E00qh7SstmAmi1qY3xqa6FkFwQvG6h1WVAMs8z/6qTx5Ml/unG5h4IbXxi9l9ocHunUb 1dPfnbZeIoIAcrtA2ysrH/T5anO83pAbw4QIkKOMxwzirStXZclVI8TGLhUCLvTJIrne UeoxuGrwliyS10GUV5b4kKwitwc3zD8hCtQmmeSWXBS055pn3etYSMDNsICM2mgpCoFW ZQbQ== X-Gm-Message-State: AA+aEWbBGGY9T9S461rn6oizrLxiwS8xZuioV4r9GDbKBqlXnISApsul f2Vbu5FhD5xEcThAEGHzrHNyBSDf X-Google-Smtp-Source: AFSGD/Vs4iIIpoTJzPgaV8BVzwRY1BDvQdqhNSWniH2jHVGhHIZ9ZYd0RubMeFCYamZr4oQfnpFJag== X-Received: by 2002:a63:d208:: with SMTP id a8mr5477835pgg.77.1542799250131; Wed, 21 Nov 2018 03:20:50 -0800 (PST) Received: from [127.0.0.1] (l193216.ppp.asahi-net.or.jp. [218.219.193.216]) by smtp.gmail.com with ESMTPSA id v9sm19598438pfe.49.2018.11.21.03.20.47 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 21 Nov 2018 03:20:48 -0800 (PST) From: Magnus Damm To: netdev@vger.kernel.org Cc: linux-renesas-soc@vger.kernel.org, Magnus Damm , davem@davemloft.net, sergei.shtylyov@cogentembedded.com Date: Wed, 21 Nov 2018 20:21:08 +0900 Message-Id: <154279926877.10272.700833429936129422.sendpatchset@octo> Subject: [PATCH v3 00/02] ravb: Duplex handling update V3 Sender: linux-renesas-soc-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-renesas-soc@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP ravb: Duplex handling update V3 [PATCH v3 01/02] ravb: Do not announce HDX as supported [PATCH v3 02/02] ravb: Clean up duplex handling This series is V3 of duplex handling improvements for the Ethernet-AVB driver. Previous versions of this series have been posted to linux-renesas-soc as RFC so V3 is the first actual version to make it to netdev. Based on the latest data sheet for R-Car Gen3 [1] and R-Car Gen2 [2] the following information is part of the EthernetAVB-IF overview page: Transfer speed: Supports transfer at 100 and 1000 Mbps Mode: Full-duplex mode It seems that the driver implementation is not matching the information provided in the friendly data sheet, and on top of this during run-time when changing PHY configuration of the link partner the Ethernet-AVB PHY seems to want to announce unsupported modes. [1] R-Car Series, 3rd Generation Rev.1.00 (Apr 2018) [2] R-Car Series, 2nd Generation Rev.2.00 (Feb 2016) Changes since V2: - Updated patch 1/2 to make use of phy_remove_link_mode() - Added Reviewed-by from Sergei - thanks! Changes since V1: - Updated patches to reflect input from Sergei and Geert - thanks! Fixes: c156633f1353 ("Renesas Ethernet AVB driver proper") Signed-off-by: Magnus Damm Reviewed-by: Sergei Shtylyov --- Applies on top of next-20181121 drivers/net/ethernet/renesas/ravb.h | 1 - drivers/net/ethernet/renesas/ravb_main.c | 23 +++++------------------ 2 files changed, 5 insertions(+), 19 deletions(-)