mbox series

[v2,0/4] media: i2c: ov5640 feature enhancement and fixes

Message ID 1596465107-14251-1-git-send-email-prabhakar.mahadev-lad.rj@bp.renesas.com (mailing list archive)
Headers show
Series media: i2c: ov5640 feature enhancement and fixes | expand

Message

Lad Prabhakar Aug. 3, 2020, 2:31 p.m. UTC 
Hi All,

This patch series fixes DVP support and enables BT656 mode in
the driver.

@Jacopo Mondi - patch 1/4 will collide with your patch series [1],
feel free to merge it as part of your v2.

[1] https://www.spinics.net/lists/linux-renesas-soc/msg51236.html

Cheers,
Prabhakar

Changes for v2:
* Added support to fallback in parallel mode
* Documented bus-type property
* Added descriptive commit message for patch 2/4 as pointed
  by Sakari
* Fixed review comments pointed by Laurent to have separate functions
  for mipi and dvp setup
* Made sure the sensor is in power down mode during startup too for
  DVP mode

Lad Prabhakar (4):
  dt-bindings: media: i2c: ov5640: Document bus-type property
  media: i2c: ov5640: Enable data pins on poweron for DVP mode
  media: i2c: ov5640: Add support for BT656 mode
  media: i2c: ov5640: Fallback to parallel mode

 .../devicetree/bindings/media/i2c/ov5640.txt  |   9 +-
 drivers/media/i2c/ov5640.c                    | 333 ++++++++++--------
 2 files changed, 198 insertions(+), 144 deletions(-)

Comments

Jacopo Mondi Aug. 6, 2020, 2:48 p.m. UTC | #1 
Hello,

On Mon, Aug 03, 2020 at 03:31:43PM +0100, Lad Prabhakar wrote:
> Hi All,
>
> This patch series fixes DVP support and enables BT656 mode in
> the driver.
>
> @Jacopo Mondi - patch 1/4 will collide with your patch series [1],
> feel free to merge it as part of your v2.

This would actually make my life simpler, as one of the issues I had
was trying to make bus-type required to be able to differentiate
between different properties.

>
> [1] https://www.spinics.net/lists/linux-renesas-soc/msg51236.html
>
> Cheers,
> Prabhakar
>
> Changes for v2:
> * Added support to fallback in parallel mode
> * Documented bus-type property
> * Added descriptive commit message for patch 2/4 as pointed
>   by Sakari
> * Fixed review comments pointed by Laurent to have separate functions
>   for mipi and dvp setup
> * Made sure the sensor is in power down mode during startup too for
>   DVP mode
>
> Lad Prabhakar (4):
>   dt-bindings: media: i2c: ov5640: Document bus-type property
>   media: i2c: ov5640: Enable data pins on poweron for DVP mode
>   media: i2c: ov5640: Add support for BT656 mode
>   media: i2c: ov5640: Fallback to parallel mode
>
>  .../devicetree/bindings/media/i2c/ov5640.txt  |   9 +-
>  drivers/media/i2c/ov5640.c                    | 333 ++++++++++--------
>  2 files changed, 198 insertions(+), 144 deletions(-)
>
> --
> 2.17.1
>
Prabhakar Aug. 10, 2020, 7:25 a.m. UTC | #2 
Hi Jacopo,


On Thu, Aug 6, 2020 at 3:44 PM Jacopo Mondi <jacopo@jmondi.org> wrote:
>
> Hello,
>
> On Mon, Aug 03, 2020 at 03:31:43PM +0100, Lad Prabhakar wrote:
> > Hi All,
> >
> > This patch series fixes DVP support and enables BT656 mode in
> > the driver.
> >
> > @Jacopo Mondi - patch 1/4 will collide with your patch series [1],
> > feel free to merge it as part of your v2.
>
> This would actually make my life simpler, as one of the issues I had
> was trying to make bus-type required to be able to differentiate
> between different properties.
>
Thank you for taking care of it.

Cheers,
Prabhakar

> >
> > [1] https://www.spinics.net/lists/linux-renesas-soc/msg51236.html
> >
> > Cheers,
> > Prabhakar
> >
> > Changes for v2:
> > * Added support to fallback in parallel mode
> > * Documented bus-type property
> > * Added descriptive commit message for patch 2/4 as pointed
> >   by Sakari
> > * Fixed review comments pointed by Laurent to have separate functions
> >   for mipi and dvp setup
> > * Made sure the sensor is in power down mode during startup too for
> >   DVP mode
> >
> > Lad Prabhakar (4):
> >   dt-bindings: media: i2c: ov5640: Document bus-type property
> >   media: i2c: ov5640: Enable data pins on poweron for DVP mode
> >   media: i2c: ov5640: Add support for BT656 mode
> >   media: i2c: ov5640: Fallback to parallel mode
> >
> >  .../devicetree/bindings/media/i2c/ov5640.txt  |   9 +-
> >  drivers/media/i2c/ov5640.c                    | 333 ++++++++++--------
> >  2 files changed, 198 insertions(+), 144 deletions(-)
> >
> > --
> > 2.17.1
> >