| Message ID | 162416647337.11444.4467438519249633023.sendpatchset@octo (mailing list archive) |
|---|---|
| Headers | show |
| Series | SoftSW DIP switch support for Draak, Eagle and Ebisu | expand |
Hi Magnus, On Sun, Jun 20, 2021 at 8:01 AM Magnus Damm <damm@opensource.se> wrote: > SoftSW DIP switch support for Draak, Eagle and Ebisu > > [PATCH 1/3] arm64: dts: renesas: r8a77995: draak: Add SW56 support > [PATCH 2/3] arm64: dts: renesas: r8a77970: eagle: Add SW2 support > [PATCH 3/3] arm64: dts: renesas: r8a77990: ebisu: Add SW4 support > > These patches add support for on-board SoftSW DIP switches to the > Draak, Eagle and Ebisu boards via board specific DTS changes. Thanks for your series! > The GPIOs connecting the DIP switches to the SoC are board specific. There > are no on-board pull-ups mounted so internal resistors need to be enabled as > pull-ups for these boards. As expected 2k resistors are used to tie the > signals to ground for the case the DIP switch is set to ON. > > All keys have been tested by toggling each DIP switch and making sure the > interrupt count in /proc/interrupts is changing as expected. The voltage level > of each signal has not been measured at this point so there is a small risk > that the internal pull-up isn't enabled and the signal is floating. Fortunately the reset state of the PUEN/PUD registers has all pull-ups enabled for all GPIO lines connected to these DIP switches. To make sure Linux enforces this configuration, you need to apply "[PATCH 00/12] pinctrl: renesas: Add more bias pinconf support" https://lore.kernel.org/linux-gpio/cover.1619785375.git.geert+renesas@glider.be/ Gr{oetje,eeting}s, Geert
SoftSW DIP switch support for Draak, Eagle and Ebisu [PATCH 1/3] arm64: dts: renesas: r8a77995: draak: Add SW56 support [PATCH 2/3] arm64: dts: renesas: r8a77970: eagle: Add SW2 support [PATCH 3/3] arm64: dts: renesas: r8a77990: ebisu: Add SW4 support These patches add support for on-board SoftSW DIP switches to the Draak, Eagle and Ebisu boards via board specific DTS changes. The GPIOs connecting the DIP switches to the SoC are board specific. There are no on-board pull-ups mounted so internal resistors need to be enabled as pull-ups for these boards. As expected 2k resistors are used to tie the signals to ground for the case the DIP switch is set to ON. All keys have been tested by toggling each DIP switch and making sure the interrupt count in /proc/interrupts is changing as expected. The voltage level of each signal has not been measured at this point so there is a small risk that the internal pull-up isn't enabled and the signal is floating. Signed-off-by: Magnus Damm <damm+renesas@opensource.se> --- Developed on top of renesas-drivers-2021-06-08-v5.13-rc5 arch/arm64/boot/dts/renesas/r8a77970-eagle.dts | 43 ++++++++++++++++++++++++ arch/arm64/boot/dts/renesas/r8a77990-ebisu.dts | 42 +++++++++++++++++++++++ arch/arm64/boot/dts/renesas/r8a77995-draak.dts | 42 +++++++++++++++++++++++ 3 files changed, 127 insertions(+)