| Message ID | 20191016085548.105703-1-jacopo+renesas@jmondi.org (mailing list archive) |
|---|---|
| Headers | show |
| Series | drm: rcar-du: Add Color Management Module (CMM) | expand |
Hi Jacopo, Thank you for your work. On Wed, Oct 16, 2019 at 10:55:40AM +0200, Jacopo Mondi wrote: > Minimal increment to the CMM series, this time should really be the last one. > > Just missing Rob's ack on [1/8] and Laurent's one on [5/8]. > > Changelog is minimal: > CMM > - Remove the cmm_config.enable flag. The cmm_config.table field validity is > used to enable/disable the LUT operations > - Expand comments as suggested by Laurent > > CRTC > - use drm_color_lut_size() to check the LUT table size > - Inline calls to rcar_cmm_enable()/disable() > - Add TODO entries as suggested by Laurent > > For the record, the full series changelog is available at: > https://paste.debian.net/1107427/ > > v5 from yesterday with informations on testing is available at: > https://lkml.org/lkml/2019/10/15/337 > > Geert will you collect for DTS patches for the next release? > I assume the DU changes go through Laurent instead ? I've taken patch 1/8 to 6/8 and 8/8 in my tree. I expected Geert to take 7/8. > Jacopo Mondi (8): > dt-bindings: display: renesas,cmm: Add R-Car CMM documentation > dt-bindings: display, renesas,du: Document cmms property > drm: rcar-du: Add support for CMM > drm: rcar-du: kms: Initialize CMM instances > drm: rcar-du: crtc: Control CMM operations > drm: rcar-du: crtc: Register GAMMA_LUT properties > arm64: dts: renesas: Add CMM units to Gen3 SoCs > drm: rcar-du: kms: Expand comment in vsps parsing routine > > .../bindings/display/renesas,cmm.yaml | 67 ++++++ > .../bindings/display/renesas,du.txt | 5 + > arch/arm64/boot/dts/renesas/r8a7795.dtsi | 39 ++++ > arch/arm64/boot/dts/renesas/r8a7796.dtsi | 31 ++- > arch/arm64/boot/dts/renesas/r8a77965.dtsi | 31 ++- > arch/arm64/boot/dts/renesas/r8a77990.dtsi | 21 ++ > arch/arm64/boot/dts/renesas/r8a77995.dtsi | 21 ++ > drivers/gpu/drm/rcar-du/Kconfig | 7 + > drivers/gpu/drm/rcar-du/Makefile | 1 + > drivers/gpu/drm/rcar-du/rcar_cmm.c | 212 ++++++++++++++++++ > drivers/gpu/drm/rcar-du/rcar_cmm.h | 58 +++++ > drivers/gpu/drm/rcar-du/rcar_du_crtc.c | 65 ++++++ > drivers/gpu/drm/rcar-du/rcar_du_crtc.h | 2 + > drivers/gpu/drm/rcar-du/rcar_du_drv.h | 2 + > drivers/gpu/drm/rcar-du/rcar_du_group.c | 10 + > drivers/gpu/drm/rcar-du/rcar_du_group.h | 2 + > drivers/gpu/drm/rcar-du/rcar_du_kms.c | 82 ++++++- > drivers/gpu/drm/rcar-du/rcar_du_regs.h | 5 + > 18 files changed, 658 insertions(+), 3 deletions(-) > create mode 100644 Documentation/devicetree/bindings/display/renesas,cmm.yaml > create mode 100644 drivers/gpu/drm/rcar-du/rcar_cmm.c > create mode 100644 drivers/gpu/drm/rcar-du/rcar_cmm.h >
Hi Laurent, On Thu, Oct 17, 2019 at 9:14 PM Laurent Pinchart <laurent.pinchart@ideasonboard.com> wrote: > On Wed, Oct 16, 2019 at 10:55:40AM +0200, Jacopo Mondi wrote: > > Minimal increment to the CMM series, this time should really be the last one. > > > > Just missing Rob's ack on [1/8] and Laurent's one on [5/8]. > > > > Changelog is minimal: > > CMM > > - Remove the cmm_config.enable flag. The cmm_config.table field validity is > > used to enable/disable the LUT operations > > - Expand comments as suggested by Laurent > > > > CRTC > > - use drm_color_lut_size() to check the LUT table size > > - Inline calls to rcar_cmm_enable()/disable() > > - Add TODO entries as suggested by Laurent > > > > For the record, the full series changelog is available at: > > https://paste.debian.net/1107427/ > > > > v5 from yesterday with informations on testing is available at: > > https://lkml.org/lkml/2019/10/15/337 > > > > Geert will you collect for DTS patches for the next release? > > I assume the DU changes go through Laurent instead ? > > I've taken patch 1/8 to 6/8 and 8/8 in my tree. I expected Geert to take > 7/8. And so I did. 7/8 is now in arm-soc/for-next. However, your drm/du/next branch seems to contain 7/8 instead of 8/8? Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds
Hi Geert, On Tue, Nov 05, 2019 at 05:14:20PM +0100, Geert Uytterhoeven wrote: > On Thu, Oct 17, 2019 at 9:14 PM Laurent Pinchart wrote: > > On Wed, Oct 16, 2019 at 10:55:40AM +0200, Jacopo Mondi wrote: > > > Minimal increment to the CMM series, this time should really be the last one. > > > > > > Just missing Rob's ack on [1/8] and Laurent's one on [5/8]. > > > > > > Changelog is minimal: > > > CMM > > > - Remove the cmm_config.enable flag. The cmm_config.table field validity is > > > used to enable/disable the LUT operations > > > - Expand comments as suggested by Laurent > > > > > > CRTC > > > - use drm_color_lut_size() to check the LUT table size > > > - Inline calls to rcar_cmm_enable()/disable() > > > - Add TODO entries as suggested by Laurent > > > > > > For the record, the full series changelog is available at: > > > https://paste.debian.net/1107427/ > > > > > > v5 from yesterday with informations on testing is available at: > > > https://lkml.org/lkml/2019/10/15/337 > > > > > > Geert will you collect for DTS patches for the next release? > > > I assume the DU changes go through Laurent instead ? > > > > I've taken patch 1/8 to 6/8 and 8/8 in my tree. I expected Geert to take > > 7/8. > > And so I did. 7/8 is now in arm-soc/for-next. > > However, your drm/du/next branch seems to contain 7/8 instead of 8/8? That was a mistake that I fixed in a second pull request (see https://lists.freedesktop.org/archives/dri-devel/2019-October/241110.html), I forgot to update the drm/du/next branch, but the tag should be correct. I've now fixed the problem in the branch as well.