| Message ID | 20201106072549.1495-1-wsa+renesas@sang-engineering.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | tmio/sdhi: fix workaround for a regression | expand |
Hi Wolfram, Thanks for your work. On 2020-11-06 08:25:46 +0100, Wolfram Sang wrote: > After some refactoring, I had to insert a workaround because a > regression was discovered when re-inserting SD cards. Now, this series > implements the proper fixes and finally reverts the workaround. Nice. > > This has been tested on Salvator-XS (M3N and H3 ES2.0). These patches > were already discussed with Shimoda-san and the BSP team internally. > However, I'd appreciate Shimoda-san's tags be given here to make sure > the patches are exactly that what we discussed. > > Thanks and happy hacking! Tested on M3-N and for the whole series, Tested-by: Niklas Söderlund <niklas.soderlund+renesas@ragnatech.se> > > > Wolfram Sang (3): > mmc: tmio: when resetting, reset DMA controller, too > mmc: tmio: bring tuning HW to a sane state with MMC_POWER_OFF > Revert "mmc: renesas_sdhi: workaround a regression when reinserting SD > cards" > > drivers/mmc/host/renesas_sdhi_core.c | 13 ------------- > drivers/mmc/host/tmio_mmc_core.c | 7 +++++-- > 2 files changed, 5 insertions(+), 15 deletions(-) > > -- > 2.28.0 >
Hi Wolfram-san, > From: Wolfram Sang, Sent: Friday, November 6, 2020 4:26 PM > > After some refactoring, I had to insert a workaround because a > regression was discovered when re-inserting SD cards. Now, this series > implements the proper fixes and finally reverts the workaround. > > This has been tested on Salvator-XS (M3N and H3 ES2.0). These patches > were already discussed with Shimoda-san and the BSP team internally. > However, I'd appreciate Shimoda-san's tags be given here to make sure > the patches are exactly that what we discussed. Thank you for the patches! Reviewed-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com> And, I tested on the R-Car H3 ES3.0 Salvator-XS. So, Tested-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com> Best regards, Yoshihiro Shimoda
On Fri, 6 Nov 2020 at 08:26, Wolfram Sang <wsa+renesas@sang-engineering.com> wrote: > > After some refactoring, I had to insert a workaround because a > regression was discovered when re-inserting SD cards. Now, this series > implements the proper fixes and finally reverts the workaround. > > This has been tested on Salvator-XS (M3N and H3 ES2.0). These patches > were already discussed with Shimoda-san and the BSP team internally. > However, I'd appreciate Shimoda-san's tags be given here to make sure > the patches are exactly that what we discussed. > > Thanks and happy hacking! > > > Wolfram Sang (3): > mmc: tmio: when resetting, reset DMA controller, too > mmc: tmio: bring tuning HW to a sane state with MMC_POWER_OFF > Revert "mmc: renesas_sdhi: workaround a regression when reinserting SD > cards" > > drivers/mmc/host/renesas_sdhi_core.c | 13 ------------- > drivers/mmc/host/tmio_mmc_core.c | 7 +++++-- > 2 files changed, 5 insertions(+), 15 deletions(-) > Applied for next, thanks! Kind regards Uffe
On Tue, Nov 10, 2020 at 01:26:08PM +0100, Ulf Hansson wrote: > On Fri, 6 Nov 2020 at 08:26, Wolfram Sang > <wsa+renesas@sang-engineering.com> wrote: > > > > After some refactoring, I had to insert a workaround because a > > regression was discovered when re-inserting SD cards. Now, this series > > implements the proper fixes and finally reverts the workaround. > > > > This has been tested on Salvator-XS (M3N and H3 ES2.0). These patches > > were already discussed with Shimoda-san and the BSP team internally. > > However, I'd appreciate Shimoda-san's tags be given here to make sure > > the patches are exactly that what we discussed. > > > > Thanks and happy hacking! > > > > > > Wolfram Sang (3): > > mmc: tmio: when resetting, reset DMA controller, too > > mmc: tmio: bring tuning HW to a sane state with MMC_POWER_OFF > > Revert "mmc: renesas_sdhi: workaround a regression when reinserting SD > > cards" > > > > drivers/mmc/host/renesas_sdhi_core.c | 13 ------------- > > drivers/mmc/host/tmio_mmc_core.c | 7 +++++-- > > 2 files changed, 5 insertions(+), 15 deletions(-) > > > > Applied for next, thanks! Can we have this in 5.10, too?
On Tue, 10 Nov 2020 at 13:40, Wolfram Sang <wsa+renesas@sang-engineering.com> wrote: > > On Tue, Nov 10, 2020 at 01:26:08PM +0100, Ulf Hansson wrote: > > On Fri, 6 Nov 2020 at 08:26, Wolfram Sang > > <wsa+renesas@sang-engineering.com> wrote: > > > > > > After some refactoring, I had to insert a workaround because a > > > regression was discovered when re-inserting SD cards. Now, this series > > > implements the proper fixes and finally reverts the workaround. > > > > > > This has been tested on Salvator-XS (M3N and H3 ES2.0). These patches > > > were already discussed with Shimoda-san and the BSP team internally. > > > However, I'd appreciate Shimoda-san's tags be given here to make sure > > > the patches are exactly that what we discussed. > > > > > > Thanks and happy hacking! > > > > > > > > > Wolfram Sang (3): > > > mmc: tmio: when resetting, reset DMA controller, too > > > mmc: tmio: bring tuning HW to a sane state with MMC_POWER_OFF > > > Revert "mmc: renesas_sdhi: workaround a regression when reinserting SD > > > cards" > > > > > > drivers/mmc/host/renesas_sdhi_core.c | 13 ------------- > > > drivers/mmc/host/tmio_mmc_core.c | 7 +++++-- > > > 2 files changed, 5 insertions(+), 15 deletions(-) > > > > > > > Applied for next, thanks! > > Can we have this in 5.10, too? Of course, thanks for the reminder! I have moved these to my fixes branch. Kind regards Uffe
> > Can we have this in 5.10, too? > > Of course, thanks for the reminder! I have moved these to my fixes branch. Thanks for your support, as always, Ulf!
After some refactoring, I had to insert a workaround because a regression was discovered when re-inserting SD cards. Now, this series implements the proper fixes and finally reverts the workaround. This has been tested on Salvator-XS (M3N and H3 ES2.0). These patches were already discussed with Shimoda-san and the BSP team internally. However, I'd appreciate Shimoda-san's tags be given here to make sure the patches are exactly that what we discussed. Thanks and happy hacking! Wolfram Sang (3): mmc: tmio: when resetting, reset DMA controller, too mmc: tmio: bring tuning HW to a sane state with MMC_POWER_OFF Revert "mmc: renesas_sdhi: workaround a regression when reinserting SD cards" drivers/mmc/host/renesas_sdhi_core.c | 13 ------------- drivers/mmc/host/tmio_mmc_core.c | 7 +++++-- 2 files changed, 5 insertions(+), 15 deletions(-)