| Message ID | 20201126191146.8753-1-prabhakar.mahadev-lad.rj@bp.renesas.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | memory: renesas-rpc-if: Trivial fixes | expand |
On 11/26/20 10:11 PM, Lad Prabhakar wrote: > This patch series fixes trivial issues in RPC-IF driver. > > Changes for v2: > * Balanced PM in rpcif_disable_rpm > * Fixed typo in patch 4/5 > * Dropped C++ style fixes patch The part that fixed the comment style wasd good, you should\ve kept it... > * Included RB tags from Sergei > > Cheers, > Prabhakar [...] MBR, Sergei
Hi Krzysztof, On Thu, Nov 26, 2020 at 7:11 PM Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com> wrote: > > Hi All, > > This patch series fixes trivial issues in RPC-IF driver. > > Changes for v2: > * Balanced PM in rpcif_disable_rpm > * Fixed typo in patch 4/5 > * Dropped C++ style fixes patch > * Included RB tags from Sergei > > Cheers, > Prabhakar > > Lad Prabhakar (5): > memory: renesas-rpc-if: Return correct value to the caller of > rpcif_manual_xfer() > memory: renesas-rpc-if: Fix unbalanced pm_runtime_enable in > rpcif_{enable,disable}_rpm > memory: renesas-rpc-if: Fix a reference leak in rpcif_probe() > memory: renesas-rpc-if: Make rpcif_enable/disable_rpm() as static > inline > memory: renesas-rpc-if: Export symbols as GPL > As these are fixes to the existing driver will these be part of v5.10 release ? Cheers, Prabhakar > drivers/memory/renesas-rpc-if.c | 28 +++++++++------------------- > include/memory/renesas-rpc-if.h | 13 +++++++++++-- > 2 files changed, 20 insertions(+), 21 deletions(-) > > -- > 2.25.1 >
Hi Prabhakar, On Thu, Dec 3, 2020 at 11:42 AM Lad, Prabhakar <prabhakar.csengg@gmail.com> wrote: > On Thu, Nov 26, 2020 at 7:11 PM Lad Prabhakar > <prabhakar.mahadev-lad.rj@bp.renesas.com> wrote: > > This patch series fixes trivial issues in RPC-IF driver. > > > > Changes for v2: > > * Balanced PM in rpcif_disable_rpm > > * Fixed typo in patch 4/5 > > * Dropped C++ style fixes patch > > * Included RB tags from Sergei > > > > Cheers, > > Prabhakar > > > > Lad Prabhakar (5): > > memory: renesas-rpc-if: Return correct value to the caller of > > rpcif_manual_xfer() > > memory: renesas-rpc-if: Fix unbalanced pm_runtime_enable in > > rpcif_{enable,disable}_rpm > > memory: renesas-rpc-if: Fix a reference leak in rpcif_probe() > > memory: renesas-rpc-if: Make rpcif_enable/disable_rpm() as static > > inline > > memory: renesas-rpc-if: Export symbols as GPL > > > As these are fixes to the existing driver will these be part of v5.10 release ? IIUIC, only the first one[*] is a fix for an issue that could happen during normal operation? [*] -EPROBE_DEFER would be eaten, causing no reprobe to happen. Gr{oetje,eeting}s, Geert
Hi Geert, > -----Original Message----- > From: Geert Uytterhoeven <geert@linux-m68k.org> > Sent: 03 December 2020 10:52 > To: Lad, Prabhakar <prabhakar.csengg@gmail.com> > Cc: Krzysztof Kozlowski <krzk@kernel.org>; Sergei Shtylyov <sergei.shtylyov@gmail.com>; Prabhakar > Mahadev Lad <prabhakar.mahadev-lad.rj@bp.renesas.com>; Philipp Zabel <p.zabel@pengutronix.de>; Jiri > Kosina <trivial@kernel.org>; Mark Brown <broonie@kernel.org>; Linux-Renesas <linux-renesas- > soc@vger.kernel.org>; Pavel Machek <pavel@denx.de>; Geert Uytterhoeven <geert+renesas@glider.be>; LKML > <linux-kernel@vger.kernel.org> > Subject: Re: [PATCH v2 0/5] memory: renesas-rpc-if: Trivial fixes > > Hi Prabhakar, > > On Thu, Dec 3, 2020 at 11:42 AM Lad, Prabhakar > <prabhakar.csengg@gmail.com> wrote: > > On Thu, Nov 26, 2020 at 7:11 PM Lad Prabhakar > > <prabhakar.mahadev-lad.rj@bp.renesas.com> wrote: > > > This patch series fixes trivial issues in RPC-IF driver. > > > > > > Changes for v2: > > > * Balanced PM in rpcif_disable_rpm > > > * Fixed typo in patch 4/5 > > > * Dropped C++ style fixes patch > > > * Included RB tags from Sergei > > > > > > Cheers, > > > Prabhakar > > > > > > Lad Prabhakar (5): > > > memory: renesas-rpc-if: Return correct value to the caller of > > > rpcif_manual_xfer() > > > memory: renesas-rpc-if: Fix unbalanced pm_runtime_enable in > > > rpcif_{enable,disable}_rpm > > > memory: renesas-rpc-if: Fix a reference leak in rpcif_probe() > > > memory: renesas-rpc-if: Make rpcif_enable/disable_rpm() as static > > > inline > > > memory: renesas-rpc-if: Export symbols as GPL > > > > > As these are fixes to the existing driver will these be part of v5.10 release ? > > IIUIC, only the first one[*] is a fix for an issue that could happen during > normal operation? > Agreed (Btw I was referring to top 3 patches). Cheers, Prabhakar > [*] -EPROBE_DEFER would be eaten, causing no reprobe to happen. > > Gr{oetje,eeting}s, > > Geert > > -- > Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org > > In personal conversations with technical people, I call myself a hacker. But > when I'm talking to journalists I just say "programmer" or something like that. > -- Linus Torvalds
On Thu, Dec 03, 2020 at 10:41:54AM +0000, Lad, Prabhakar wrote: > Hi Krzysztof, > > On Thu, Nov 26, 2020 at 7:11 PM Lad Prabhakar > <prabhakar.mahadev-lad.rj@bp.renesas.com> wrote: > > > > Hi All, > > > > This patch series fixes trivial issues in RPC-IF driver. > > > > Changes for v2: > > * Balanced PM in rpcif_disable_rpm > > * Fixed typo in patch 4/5 > > * Dropped C++ style fixes patch > > * Included RB tags from Sergei > > > > Cheers, > > Prabhakar > > > > Lad Prabhakar (5): > > memory: renesas-rpc-if: Return correct value to the caller of > > rpcif_manual_xfer() > > memory: renesas-rpc-if: Fix unbalanced pm_runtime_enable in > > rpcif_{enable,disable}_rpm > > memory: renesas-rpc-if: Fix a reference leak in rpcif_probe() > > memory: renesas-rpc-if: Make rpcif_enable/disable_rpm() as static > > inline > > memory: renesas-rpc-if: Export symbols as GPL > > > As these are fixes to the existing driver will these be part of v5.10 release ? Quick look with: git lg v5.9..v5.10-rc1 -- drivers/memory/ did not show that this driver was added in v5.10-rc1, so the fixes are not planned to be for v5.10 release never. Why they should be? Maybe I missed something here? Best regards, Krzysztof
Hi Krzysztof, On Thu, Dec 3, 2020 at 1:19 PM Krzysztof Kozlowski <krzk@kernel.org> wrote: > > On Thu, Dec 03, 2020 at 10:41:54AM +0000, Lad, Prabhakar wrote: > > Hi Krzysztof, > > > > On Thu, Nov 26, 2020 at 7:11 PM Lad Prabhakar > > <prabhakar.mahadev-lad.rj@bp.renesas.com> wrote: > > > > > > Hi All, > > > > > > This patch series fixes trivial issues in RPC-IF driver. > > > > > > Changes for v2: > > > * Balanced PM in rpcif_disable_rpm > > > * Fixed typo in patch 4/5 > > > * Dropped C++ style fixes patch > > > * Included RB tags from Sergei > > > > > > Cheers, > > > Prabhakar > > > > > > Lad Prabhakar (5): > > > memory: renesas-rpc-if: Return correct value to the caller of > > > rpcif_manual_xfer() > > > memory: renesas-rpc-if: Fix unbalanced pm_runtime_enable in > > > rpcif_{enable,disable}_rpm > > > memory: renesas-rpc-if: Fix a reference leak in rpcif_probe() > > > memory: renesas-rpc-if: Make rpcif_enable/disable_rpm() as static > > > inline > > > memory: renesas-rpc-if: Export symbols as GPL > > > > > As these are fixes to the existing driver will these be part of v5.10 release ? > > Quick look with: > git lg v5.9..v5.10-rc1 -- drivers/memory/ > did not show that this driver was added in v5.10-rc1, so the fixes are > not planned to be for v5.10 release never. Why they should be? Maybe I > missed something here? > My bad the fixes can go into v5.11. Cheers, Prabhakar
Hi All, This patch series fixes trivial issues in RPC-IF driver. Changes for v2: * Balanced PM in rpcif_disable_rpm * Fixed typo in patch 4/5 * Dropped C++ style fixes patch * Included RB tags from Sergei Cheers, Prabhakar Lad Prabhakar (5): memory: renesas-rpc-if: Return correct value to the caller of rpcif_manual_xfer() memory: renesas-rpc-if: Fix unbalanced pm_runtime_enable in rpcif_{enable,disable}_rpm memory: renesas-rpc-if: Fix a reference leak in rpcif_probe() memory: renesas-rpc-if: Make rpcif_enable/disable_rpm() as static inline memory: renesas-rpc-if: Export symbols as GPL drivers/memory/renesas-rpc-if.c | 28 +++++++++------------------- include/memory/renesas-rpc-if.h | 13 +++++++++++-- 2 files changed, 20 insertions(+), 21 deletions(-)