| Message ID | 20210125142431.1049668-1-geert+renesas@glider.be (mailing list archive) |
|---|---|
| Headers | show |
| Series | dmaengine: rcar-dmac: Add support for R-Car V3U | expand |
On Mon, Jan 25, 2021 at 03:24:29PM +0100, Geert Uytterhoeven wrote: > Add and helper macro for iterating over all DMAC channels, taking into > account the channel mask. Use it where appropriate, to simplify code. > > Restore "reverse Christmas tree" order of local variables while adding a > new variable. > > Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be> Looks good and works fine with I2C + DMA on V3U: Reviewed-by: Wolfram Sang <wsa+renesas@sang-engineering.com> Tested-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
On Mon, Jan 25, 2021 at 03:24:30PM +0100, Geert Uytterhoeven wrote: > Extract the code to clear the status of one or all channels into their > own helpers, to prepare for the different handling of the R-Car V3U SoC. > > Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be> Looks good and works fine with I2C + DMA on V3U: Reviewed-by: Wolfram Sang <wsa+renesas@sang-engineering.com> Tested-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
Hi Vinod, This patch series adds support for the Direct Memory Access Controller variant in the Renesas R-Car V3U (R8A779A0) SoC, to both DT bindings and driver. Changes compared to v1: - Add Reviewed-by, - Put the full loop control of for_each_rcar_dmac_chan() on a single line, to improve readability, - Use two separate named regions instead of array, - Drop rcar_dmac_of_data.chan_reg_block, check for !rcar_dmac_of_data.chan_offset_base instead, - Precalculate chan_base in rcar_dmac_probe(). This has been tested on the Renesas Falcon board, using external SPI loopback (spi-loopback-test) on MSIOF1 and MSIOF2. Thanks! Geert Uytterhoeven (4): dt-bindings: renesas,rcar-dmac: Add r8a779a0 support dmaengine: rcar-dmac: Add for_each_rcar_dmac_chan() helper dmaengine: rcar-dmac: Add helpers for clearing DMA channel status dmaengine: rcar-dmac: Add support for R-Car V3U .../bindings/dma/renesas,rcar-dmac.yaml | 76 ++++++++----- drivers/dma/sh/rcar-dmac.c | 105 +++++++++++++----- 2 files changed, 123 insertions(+), 58 deletions(-)