mbox series

[0/2] media: mc: Simplify media pipeline start/stop

Message ID 20220113150042.15630-1-laurent.pinchart+renesas@ideasonboard.com (mailing list archive)
Headers show
Series media: mc: Simplify media pipeline start/stop | expand

Message

Laurent Pinchart Jan. 13, 2022, 3 p.m. UTC
Hello,

This small series simplifies the implementation of the
media_pipeline_start() function (and to a lesser extend, the
media_pipeline_stop() function as well) by avoiding unnecessary graph
walks.

Patch 1/2 adds a small inline helper function to avoid direct access to
the media_entity.stream_count field in drivers, making it easier in
patch 2/2 to rework the implementation (dropping the stream_count field)
without disturbing drivers. Please see patch 2/2 for a detailed
explanation of the simplification.

Laurent Pinchart (2):
  media: media-entity: Add media_pad_is_streaming() helper function
  media: media-entity: Simplify media_pipeline_start()

 drivers/media/mc/mc-entity.c                  | 55 ++++++++-----------
 drivers/media/platform/exynos4-is/common.c    |  5 +-
 drivers/media/platform/exynos4-is/fimc-isp.c  |  2 +-
 drivers/media/platform/exynos4-is/fimc-lite.c |  6 +-
 drivers/media/platform/rcar-vin/rcar-core.c   |  2 +-
 include/media/media-entity.h                  | 21 +++++--
 6 files changed, 48 insertions(+), 43 deletions(-)


base-commit: 68b9bcc8a534cd11fe55f8bc82f948aae7d81b3c

Comments

Laurent Pinchart Jan. 13, 2022, 3:28 p.m. UTC | #1
On Thu, Jan 13, 2022 at 05:00:40PM +0200, Laurent Pinchart wrote:
> Hello,
> 
> This small series simplifies the implementation of the
> media_pipeline_start() function (and to a lesser extend, the
> media_pipeline_stop() function as well) by avoiding unnecessary graph
> walks.
> 
> Patch 1/2 adds a small inline helper function to avoid direct access to
> the media_entity.stream_count field in drivers, making it easier in
> patch 2/2 to rework the implementation (dropping the stream_count field)
> without disturbing drivers. Please see patch 2/2 for a detailed
> explanation of the simplification.

I forgot to mention that I've tested this with the Renesas R-Car VSP1
test suite that has pipeline with multiple output and capture video
nodes, as well on a Xilinx platform with a pipeline that has two capture
video nodes.

> Laurent Pinchart (2):
>   media: media-entity: Add media_pad_is_streaming() helper function
>   media: media-entity: Simplify media_pipeline_start()
> 
>  drivers/media/mc/mc-entity.c                  | 55 ++++++++-----------
>  drivers/media/platform/exynos4-is/common.c    |  5 +-
>  drivers/media/platform/exynos4-is/fimc-isp.c  |  2 +-
>  drivers/media/platform/exynos4-is/fimc-lite.c |  6 +-
>  drivers/media/platform/rcar-vin/rcar-core.c   |  2 +-
>  include/media/media-entity.h                  | 21 +++++--
>  6 files changed, 48 insertions(+), 43 deletions(-)
> 
> 
> base-commit: 68b9bcc8a534cd11fe55f8bc82f948aae7d81b3c