mbox series

[RESEND,v3,0/2] ARM: r9a06g032: add support for the watchdogs

Message ID 20220318182625.16182-1-jjhiblot@traphandler.com (mailing list archive)
Headers show
Series ARM: r9a06g032: add support for the watchdogs | expand

Message

Jean-Jacques Hiblot March 18, 2022, 6:26 p.m. UTC 
Hi,

I did not receive any feedback for those 2 patches of the v3 of this
series, so resending them. The rest of the patches (dt-stuff) have
already been queued in renesas/renesas-arm-dt-for-v5.18.

cheers,
Jean-Jacques


Jean-Jacques Hiblot (1):
  dt-bindings: watchdog: renesas,wdt: Add support for RZ/N1

Phil Edworthy (1):
  watchdog: Add Renesas RZ/N1 Watchdog driver

 .../bindings/watchdog/renesas,wdt.yaml        |   6 +
 drivers/watchdog/Kconfig                      |   8 +
 drivers/watchdog/Makefile                     |   1 +
 drivers/watchdog/rzn1_wdt.c                   | 206 ++++++++++++++++++
 4 files changed, 221 insertions(+)
 create mode 100644 drivers/watchdog/rzn1_wdt.c

Comments

Guenter Roeck March 18, 2022, 7:38 p.m. UTC | #1 
On 3/18/22 11:26, Jean-Jacques Hiblot wrote:
> Hi,
> 
> I did not receive any feedback for those 2 patches of the v3 of this
> series, so resending them. The rest of the patches (dt-stuff) have


Well, yes, you didn't send it to linux-watchdog@vger.kernel.org, which
I use as base for reviews, to collect review feedback, and as source
for applying the patches. On top of that, you didn't provide change logs
either, meaning I'd have to dig on the web to find older versions of
your patches (since they won't be in watchdog patchwork either) and
compare those. All that takes a lot of time, and you really should not
expect fast turnaround (if any - your v2 got completely lost for me).

Also, FWIW, after doing just that right now I still disagree that it makes
sense to have a watchdog interrupt do nothing. That is just as good as no
watchdog.

Guenter
Jean-Jacques Hiblot March 20, 2022, 3:04 p.m. UTC | #2 
On 18/03/2022 20:38, Guenter Roeck wrote:
> On 3/18/22 11:26, Jean-Jacques Hiblot wrote:
>> Hi,
>>
>> I did not receive any feedback for those 2 patches of the v3 of this
>> series, so resending them. The rest of the patches (dt-stuff) have
>
>
> Well, yes, you didn't send it to linux-watchdog@vger.kernel.org, which

yes I see now that linux-watchdog@vger.kernel.org is missing from the 
send list.

I'll make sure to include it next time. Sorry about that.

> I use as base for reviews, to collect review feedback, and as source
> for applying the patches. On top of that, you didn't provide change logs
> either, meaning I'd have to dig on the web to find older versions of
> your patches (since they won't be in watchdog patchwork either) and
> compare those. All that takes a lot of time, and you really should not
> expect fast turnaround (if any - your v2 got completely lost for me).
>
> Also, FWIW, after doing just that right now I still disagree that it 
> makes
> sense to have a watchdog interrupt do nothing. That is just as good as no
> watchdog.

if it's okay, I can add a call to emergency_restart() in the interrupt 
handler

as it is done in other drivers (sama5d4.c, wdt.c).


Thanks,

Jean-Jacques

>
> Guenter