mbox series

[v2,0/6] arm64: dts: renesas: move I2C aliases to board files

Message ID 20220825071022.7864-1-wsa+renesas@sang-engineering.com (mailing list archive)
Headers show
Series arm64: dts: renesas: move I2C aliases to board files | expand

Message

Wolfram Sang Aug. 25, 2022, 7:10 a.m. UTC
Change since v1:
* converted r8a774a1 boards, too (Thanks, Geert!)

Old coverletter follows:

For R-Car Gen3 and Gen4, we had I2C aliases in per-SoC DTS include
files. That doesn't really fit as bus naming is a board property. This
series moves the aliases to the board files. The following procedure has
been applied to avoid regressions:

1) move the aliases from SoC files to board files. Keep the empty
   alias-nodes in the SoC file and add the new aliases before existing
   ones. This ensured that identical binaries[1] were created.

2) Once all aliases were moved and all binaries[1] stayed identical,
   then the empty alias nodes from the SoC files were removed.

The result is this series based on the renesas-drivers tag
'renesas-drivers-2022-08-16-v6.0-rc1'.

It could be discussed if the aliases should be sorted alphabetically,
but I'd think this is a seperate series then.

I also leave it to Geert, if the commits should be squashed. At least
for reviewing, I think this separation makes sense, though.

Looking forward to comments,

   Wolfram

[1] For desired binaries, of course. For r8a77961 boards, the binaries
did change. This was intended, though, because I wanted to add I2C
aliases there which were not present before. Also, the r8a779m* boards
now have I2C aliases, too.

Wolfram Sang (6):
  arm64: dts: renesas: r8a779{51|60|65}: put I2C aliases to board files
  arm64: dts: renesas: r8a77970: put I2C aliases to board files
  arm64: dts: renesas: r8a77980: put I2C aliases to board files
  arm64: dts: renesas: r8a77990: put I2C aliases to board files
  arm64: dts: renesas: r8a779a0: put I2C aliases to board files
  arm64: dts: renesas: r8a774a1: put I2C aliases to board files

 arch/arm64/boot/dts/renesas/ebisu.dtsi                |  8 ++++++++
 arch/arm64/boot/dts/renesas/hihope-common.dtsi        |  8 ++++++++
 .../boot/dts/renesas/r8a774a1-beacon-rzg2m-kit.dts    |  8 ++++++++
 arch/arm64/boot/dts/renesas/r8a774a1.dtsi             | 11 -----------
 arch/arm64/boot/dts/renesas/r8a77951.dtsi             | 11 -----------
 arch/arm64/boot/dts/renesas/r8a77960.dtsi             | 11 -----------
 arch/arm64/boot/dts/renesas/r8a77965.dtsi             | 11 -----------
 arch/arm64/boot/dts/renesas/r8a77970-eagle.dts        |  5 +++++
 arch/arm64/boot/dts/renesas/r8a77970-v3msk.dts        |  5 +++++
 arch/arm64/boot/dts/renesas/r8a77970.dtsi             |  8 --------
 arch/arm64/boot/dts/renesas/r8a77980-condor.dts       |  6 ++++++
 arch/arm64/boot/dts/renesas/r8a77980-v3hsk.dts        |  6 ++++++
 arch/arm64/boot/dts/renesas/r8a77980.dtsi             |  9 ---------
 arch/arm64/boot/dts/renesas/r8a77990.dtsi             | 11 -----------
 arch/arm64/boot/dts/renesas/r8a779a0-falcon-cpu.dtsi  |  7 +++++++
 arch/arm64/boot/dts/renesas/r8a779a0.dtsi             | 10 ----------
 arch/arm64/boot/dts/renesas/salvator-common.dtsi      |  8 ++++++++
 arch/arm64/boot/dts/renesas/ulcb.dtsi                 |  8 ++++++++
 18 files changed, 69 insertions(+), 82 deletions(-)

Comments

Geert Uytterhoeven Aug. 26, 2022, 2:54 p.m. UTC | #1
Hi Wolfram.

On Thu, Aug 25, 2022 at 9:11 AM Wolfram Sang
<wsa+renesas@sang-engineering.com> wrote:
> Change since v1:
> * converted r8a774a1 boards, too (Thanks, Geert!)
>
> Old coverletter follows:
>
> For R-Car Gen3 and Gen4, we had I2C aliases in per-SoC DTS include
> files. That doesn't really fit as bus naming is a board property. This
> series moves the aliases to the board files. The following procedure has
> been applied to avoid regressions:
>
> 1) move the aliases from SoC files to board files. Keep the empty
>    alias-nodes in the SoC file and add the new aliases before existing
>    ones. This ensured that identical binaries[1] were created.
>
> 2) Once all aliases were moved and all binaries[1] stayed identical,
>    then the empty alias nodes from the SoC files were removed.
>
> The result is this series based on the renesas-drivers tag
> 'renesas-drivers-2022-08-16-v6.0-rc1'.
>
> It could be discussed if the aliases should be sorted alphabetically,
> but I'd think this is a seperate series then.
>
> I also leave it to Geert, if the commits should be squashed. At least
> for reviewing, I think this separation makes sense, though.

Thanks for the update!

Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
i.e. will queue in renesas-devel for v6.1.

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds