| Message ID | 20221221092448.741294-1-tomi.valkeinen+renesas@ideasonboard.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | media/drm: renesas: Add new pixel formats | expand |
Hi Tomi, (CC'ing Daniel and Dave) On Wed, Dec 21, 2022 at 11:24:41AM +0200, Tomi Valkeinen wrote: > From: Tomi Valkeinen <tomi.valkeinen@ideasonboard.com> > > Hi, > > These add new pixel formats for Renesas V3U and V4H SoCs. > > As the display pipeline is split between DRM and V4L2 components, this > series touches both subsystems. I'm sending all these together to > simplify review. If needed, I can later split this to V4L2 and DRM > parts, of which the V4L2 part needs to be merged first. As the changes on the DRM side are small and shouldn't conflict with anything else queued for v6.3, it would be easier to merge the whole series through the media tree. Daniel, Dave, would you be OK with that ? If so, could you please ack patches 6/7 and 7/7 ? > Changes in v3: > - Addressed all the review comments > - Added Y212 > - Updated the kernel docs for the new formats > - Changed the RGB format names to match the DRM's format names > - Updated RPF register field macros according to the comments > > Tomi > > Tomi Valkeinen (7): > media: Add 2-10-10-10 RGB formats > media: Add Y210, Y212 and Y216 formats > media: renesas: vsp1: Change V3U to be gen4 > media: renesas: vsp1: Add V4H SoC version > media: renesas: vsp1: Add new formats (2-10-10-10 ARGB, Y210, Y212) > drm: rcar-du: Bump V3U to gen 4 > drm: rcar-du: Add new formats (2-10-10-10 ARGB, Y210) > > .../media/v4l/pixfmt-packed-yuv.rst | 49 ++++- > .../userspace-api/media/v4l/pixfmt-rgb.rst | 194 ++++++++++++++++++ > drivers/gpu/drm/rcar-du/rcar_du_drv.c | 2 +- > drivers/gpu/drm/rcar-du/rcar_du_kms.c | 30 +++ > drivers/gpu/drm/rcar-du/rcar_du_vsp.c | 50 ++++- > .../media/platform/renesas/vsp1/vsp1_drv.c | 4 +- > .../media/platform/renesas/vsp1/vsp1_hgo.c | 4 +- > .../media/platform/renesas/vsp1/vsp1_lif.c | 1 + > .../media/platform/renesas/vsp1/vsp1_pipe.c | 18 ++ > .../media/platform/renesas/vsp1/vsp1_regs.h | 26 ++- > .../media/platform/renesas/vsp1/vsp1_rpf.c | 64 +++++- > .../media/platform/renesas/vsp1/vsp1_video.c | 4 +- > .../media/platform/renesas/vsp1/vsp1_wpf.c | 4 +- > drivers/media/v4l2-core/v4l2-ioctl.c | 6 + > include/uapi/linux/videodev2.h | 11 + > 15 files changed, 447 insertions(+), 20 deletions(-)
On 26/12/2022 16:56, Laurent Pinchart wrote: > Hi Tomi, > > (CC'ing Daniel and Dave) > > On Wed, Dec 21, 2022 at 11:24:41AM +0200, Tomi Valkeinen wrote: >> From: Tomi Valkeinen <tomi.valkeinen@ideasonboard.com> >> >> Hi, >> >> These add new pixel formats for Renesas V3U and V4H SoCs. >> >> As the display pipeline is split between DRM and V4L2 components, this >> series touches both subsystems. I'm sending all these together to >> simplify review. If needed, I can later split this to V4L2 and DRM >> parts, of which the V4L2 part needs to be merged first. > > As the changes on the DRM side are small and shouldn't conflict with > anything else queued for v6.3, it would be easier to merge the whole > series through the media tree. Daniel, Dave, would you be OK with that ? > If so, could you please ack patches 6/7 and 7/7 ? Note that these patches depend on the two DRM driver patches in "[PATCH v5 0/7] Renesas V4H DSI & DP output support", which are not very small (but still not big). I don't think there's a compile-time dependency between the DRM and V4L2 parts, but there's a functional side dependency, so it would be nice to merge these via a single tree. I can't say if DRM or V4L2 tree is easier, but I don't expect conflicts either way. Tomi
Hi Tomi, (CC'ing Mauro and Hans) On Tue, Jan 10, 2023 at 04:25:37PM +0200, Tomi Valkeinen wrote: > On 26/12/2022 16:56, Laurent Pinchart wrote: > > Hi Tomi, > > > > (CC'ing Daniel and Dave) > > > > On Wed, Dec 21, 2022 at 11:24:41AM +0200, Tomi Valkeinen wrote: > >> From: Tomi Valkeinen <tomi.valkeinen@ideasonboard.com> > >> > >> Hi, > >> > >> These add new pixel formats for Renesas V3U and V4H SoCs. > >> > >> As the display pipeline is split between DRM and V4L2 components, this > >> series touches both subsystems. I'm sending all these together to > >> simplify review. If needed, I can later split this to V4L2 and DRM > >> parts, of which the V4L2 part needs to be merged first. > > > > As the changes on the DRM side are small and shouldn't conflict with > > anything else queued for v6.3, it would be easier to merge the whole > > series through the media tree. Daniel, Dave, would you be OK with that ? > > If so, could you please ack patches 6/7 and 7/7 ? > > Note that these patches depend on the two DRM driver patches in "[PATCH > v5 0/7] Renesas V4H DSI & DP output support", which are not very small > (but still not big). Good point. I'm thus leaning more towards merging this through the DRM tree then. Mauro, can we get your ack on the V4L2 part of this series ? We'll create a stable branch based on v6.2-rc1 in case it also need to be merged in the media tree due to last minute conflicts (I'm mainly thinking about the new formats). Hans, as there won't be a pull request through the media tree, if you want to review the new formats, now would be a good time. > I don't think there's a compile-time dependency between the DRM and V4L2 > parts, but there's a functional side dependency, so it would be nice to > merge these via a single tree. I can't say if DRM or V4L2 tree is > easier, but I don't expect conflicts either way.
Em Tue, 17 Jan 2023 15:38:25 +0200 Laurent Pinchart <laurent.pinchart@ideasonboard.com> escreveu: > Hi Tomi, > > (CC'ing Mauro and Hans) > > On Tue, Jan 10, 2023 at 04:25:37PM +0200, Tomi Valkeinen wrote: > > On 26/12/2022 16:56, Laurent Pinchart wrote: > > > Hi Tomi, > > > > > > (CC'ing Daniel and Dave) > > > > > > On Wed, Dec 21, 2022 at 11:24:41AM +0200, Tomi Valkeinen wrote: > > >> From: Tomi Valkeinen <tomi.valkeinen@ideasonboard.com> > > >> > > >> Hi, > > >> > > >> These add new pixel formats for Renesas V3U and V4H SoCs. > > >> > > >> As the display pipeline is split between DRM and V4L2 components, this > > >> series touches both subsystems. I'm sending all these together to > > >> simplify review. If needed, I can later split this to V4L2 and DRM > > >> parts, of which the V4L2 part needs to be merged first. > > > > > > As the changes on the DRM side are small and shouldn't conflict with > > > anything else queued for v6.3, it would be easier to merge the whole > > > series through the media tree. Daniel, Dave, would you be OK with that ? > > > If so, could you please ack patches 6/7 and 7/7 ? > > > > Note that these patches depend on the two DRM driver patches in "[PATCH > > v5 0/7] Renesas V4H DSI & DP output support", which are not very small > > (but still not big). > > Good point. I'm thus leaning more towards merging this through the DRM > tree then. Mauro, can we get your ack on the V4L2 part of this series ? > We'll create a stable branch based on v6.2-rc1 in case it also need to > be merged in the media tree due to last minute conflicts (I'm mainly > thinking about the new formats). Feel free to merge the V4L2 patches via DRM tree with my ack: Acked-by: Mauro Carvalho Chehab <mchehab@kernel.org> > > Hans, as there won't be a pull request through the media tree, if you > want to review the new formats, now would be a good time. > > > I don't think there's a compile-time dependency between the DRM and V4L2 > > parts, but there's a functional side dependency, so it would be nice to > > merge these via a single tree. I can't say if DRM or V4L2 tree is > > easier, but I don't expect conflicts either way. > Thanks, Mauro
On 21/12/2022 10:24, Tomi Valkeinen wrote: > From: Tomi Valkeinen <tomi.valkeinen@ideasonboard.com> > > Hi, > > These add new pixel formats for Renesas V3U and V4H SoCs. > > As the display pipeline is split between DRM and V4L2 components, this > series touches both subsystems. I'm sending all these together to > simplify review. If needed, I can later split this to V4L2 and DRM > parts, of which the V4L2 part needs to be merged first. > > Changes in v3: > - Addressed all the review comments > - Added Y212 > - Updated the kernel docs for the new formats > - Changed the RGB format names to match the DRM's format names > - Updated RPF register field macros according to the comments For this series: Acked-by: Hans Verkuil <hverkuil-cisco@xs4all.nl> Thanks, Hans > > Tomi > > Tomi Valkeinen (7): > media: Add 2-10-10-10 RGB formats > media: Add Y210, Y212 and Y216 formats > media: renesas: vsp1: Change V3U to be gen4 > media: renesas: vsp1: Add V4H SoC version > media: renesas: vsp1: Add new formats (2-10-10-10 ARGB, Y210, Y212) > drm: rcar-du: Bump V3U to gen 4 > drm: rcar-du: Add new formats (2-10-10-10 ARGB, Y210) > > .../media/v4l/pixfmt-packed-yuv.rst | 49 ++++- > .../userspace-api/media/v4l/pixfmt-rgb.rst | 194 ++++++++++++++++++ > drivers/gpu/drm/rcar-du/rcar_du_drv.c | 2 +- > drivers/gpu/drm/rcar-du/rcar_du_kms.c | 30 +++ > drivers/gpu/drm/rcar-du/rcar_du_vsp.c | 50 ++++- > .../media/platform/renesas/vsp1/vsp1_drv.c | 4 +- > .../media/platform/renesas/vsp1/vsp1_hgo.c | 4 +- > .../media/platform/renesas/vsp1/vsp1_lif.c | 1 + > .../media/platform/renesas/vsp1/vsp1_pipe.c | 18 ++ > .../media/platform/renesas/vsp1/vsp1_regs.h | 26 ++- > .../media/platform/renesas/vsp1/vsp1_rpf.c | 64 +++++- > .../media/platform/renesas/vsp1/vsp1_video.c | 4 +- > .../media/platform/renesas/vsp1/vsp1_wpf.c | 4 +- > drivers/media/v4l2-core/v4l2-ioctl.c | 6 + > include/uapi/linux/videodev2.h | 11 + > 15 files changed, 447 insertions(+), 20 deletions(-) >
From: Tomi Valkeinen <tomi.valkeinen@ideasonboard.com> Hi, These add new pixel formats for Renesas V3U and V4H SoCs. As the display pipeline is split between DRM and V4L2 components, this series touches both subsystems. I'm sending all these together to simplify review. If needed, I can later split this to V4L2 and DRM parts, of which the V4L2 part needs to be merged first. Changes in v3: - Addressed all the review comments - Added Y212 - Updated the kernel docs for the new formats - Changed the RGB format names to match the DRM's format names - Updated RPF register field macros according to the comments Tomi Tomi Valkeinen (7): media: Add 2-10-10-10 RGB formats media: Add Y210, Y212 and Y216 formats media: renesas: vsp1: Change V3U to be gen4 media: renesas: vsp1: Add V4H SoC version media: renesas: vsp1: Add new formats (2-10-10-10 ARGB, Y210, Y212) drm: rcar-du: Bump V3U to gen 4 drm: rcar-du: Add new formats (2-10-10-10 ARGB, Y210) .../media/v4l/pixfmt-packed-yuv.rst | 49 ++++- .../userspace-api/media/v4l/pixfmt-rgb.rst | 194 ++++++++++++++++++ drivers/gpu/drm/rcar-du/rcar_du_drv.c | 2 +- drivers/gpu/drm/rcar-du/rcar_du_kms.c | 30 +++ drivers/gpu/drm/rcar-du/rcar_du_vsp.c | 50 ++++- .../media/platform/renesas/vsp1/vsp1_drv.c | 4 +- .../media/platform/renesas/vsp1/vsp1_hgo.c | 4 +- .../media/platform/renesas/vsp1/vsp1_lif.c | 1 + .../media/platform/renesas/vsp1/vsp1_pipe.c | 18 ++ .../media/platform/renesas/vsp1/vsp1_regs.h | 26 ++- .../media/platform/renesas/vsp1/vsp1_rpf.c | 64 +++++- .../media/platform/renesas/vsp1/vsp1_video.c | 4 +- .../media/platform/renesas/vsp1/vsp1_wpf.c | 4 +- drivers/media/v4l2-core/v4l2-ioctl.c | 6 + include/uapi/linux/videodev2.h | 11 + 15 files changed, 447 insertions(+), 20 deletions(-)