| Message ID | 20230307115900.2293120-1-u.kleine-koenig@pengutronix.de (mailing list archive) |
|---|---|
| Headers | show |
| Series | phy: Convert to platform remove callback returning void | expand |
On 07-03-23, 12:58, Uwe Kleine-König wrote: > Hello, > > this patch series adapts the platform drivers below drivers/phy to use the > .remove_new() callback. Compared to the traditional .remove() callback > .remove_new() returns no value. This is a good thing because the driver core > doesn't (and cannot) cope for errors during remove. The only effect of a > non-zero return value in .remove() is that the driver core emits a warning. The > device is removed anyhow and an early return from .remove() usually yields a > resource leak. > > By changing the remove callback to return void driver authors cannot > reasonably assume any more that there is some kind of cleanup later. > > All drivers in drivers/spmi returned zero unconditionally in their remove > callback, so they could all be converted trivially to .remove_new(). > > Note that this series depends on commit 5c5a7680e67b ("platform: Provide > a remove callback that returns no value") which is included in v6.3-rc1. Applied, thanks
Hello, this patch series adapts the platform drivers below drivers/phy to use the .remove_new() callback. Compared to the traditional .remove() callback .remove_new() returns no value. This is a good thing because the driver core doesn't (and cannot) cope for errors during remove. The only effect of a non-zero return value in .remove() is that the driver core emits a warning. The device is removed anyhow and an early return from .remove() usually yields a resource leak. By changing the remove callback to return void driver authors cannot reasonably assume any more that there is some kind of cleanup later. All drivers in drivers/spmi returned zero unconditionally in their remove callback, so they could all be converted trivially to .remove_new(). Note that this series depends on commit 5c5a7680e67b ("platform: Provide a remove callback that returns no value") which is included in v6.3-rc1. Best regards Uwe Uwe Kleine-König (31): phy: allwinner: phy-sun4i-usb: Convert to platform remove callback returning void phy: broadcom: phy-brcm-usb: Convert to platform remove callback returning void phy: cadence: cdns-dphy: Convert to platform remove callback returning void phy: cadence: phy-cadence-sierra: Convert to platform remove callback returning void phy: cadence: phy-cadence-torrent: Convert to platform remove callback returning void phy: freescale: phy-fsl-imx8qm-lvds-phy: Convert to platform remove callback returning void phy: intel: phy-intel-lgm-combo: Convert to platform remove callback returning void phy: mediatek: phy-mtk-mipi-dsi: Convert to platform remove callback returning void phy: motorola: phy-cpcap-usb: Convert to platform remove callback returning void phy: motorola: phy-mapphone-mdm6600: Convert to platform remove callback returning void phy: phy-lgm-usb: Convert to platform remove callback returning void phy: qualcomm: phy-qcom-apq8064-sata: Convert to platform remove callback returning void phy: qualcomm: phy-qcom-eusb2-repeater: Convert to platform remove callback returning void phy: qualcomm: phy-qcom-ipq806x-sata: Convert to platform remove callback returning void phy: renesas: phy-rcar-gen3-pcie: Convert to platform remove callback returning void phy: renesas: phy-rcar-gen3-usb2: Convert to platform remove callback returning void phy: renesas: phy-rcar-gen3-usb3: Convert to platform remove callback returning void phy: renesas: r8a779f0-ether-serdes: Convert to platform remove callback returning void phy: rockchip: phy-rockchip-inno-csidphy: Convert to platform remove callback returning void phy: rockchip: phy-rockchip-inno-dsidphy: Convert to platform remove callback returning void phy: rockchip: phy-rockchip-inno-hdmi: Convert to platform remove callback returning void phy: rockchip: phy-rockchip-typec: Convert to platform remove callback returning void phy: st: phy-stm32-usbphyc: Convert to platform remove callback returning void phy: tegra: xusb: Convert to platform remove callback returning void phy: ti: phy-am654-serdes: Convert to platform remove callback returning void phy: ti: phy-da8xx-usb: Convert to platform remove callback returning void phy: ti: phy-dm816x-usb: Convert to platform remove callback returning void phy: ti: phy-j721e-wiz: Convert to platform remove callback returning void phy: ti: phy-omap-usb2: Convert to platform remove callback returning void phy: ti: phy-ti-pipe3: Convert to platform remove callback returning void phy: ti: phy-twl4030-usb: Convert to platform remove callback returning void drivers/phy/allwinner/phy-sun4i-usb.c | 6 ++---- drivers/phy/broadcom/phy-brcm-usb.c | 6 ++---- drivers/phy/cadence/cdns-dphy.c | 6 ++---- drivers/phy/cadence/phy-cadence-sierra.c | 6 ++---- drivers/phy/cadence/phy-cadence-torrent.c | 6 ++---- drivers/phy/freescale/phy-fsl-imx8qm-lvds-phy.c | 6 ++---- drivers/phy/intel/phy-intel-lgm-combo.c | 5 ++--- drivers/phy/mediatek/phy-mtk-mipi-dsi.c | 5 ++--- drivers/phy/motorola/phy-cpcap-usb.c | 6 ++---- drivers/phy/motorola/phy-mapphone-mdm6600.c | 6 ++---- drivers/phy/phy-lgm-usb.c | 6 ++---- drivers/phy/qualcomm/phy-qcom-apq8064-sata.c | 6 ++---- drivers/phy/qualcomm/phy-qcom-eusb2-repeater.c | 8 +++----- drivers/phy/qualcomm/phy-qcom-ipq806x-sata.c | 6 ++---- drivers/phy/renesas/phy-rcar-gen3-pcie.c | 6 ++---- drivers/phy/renesas/phy-rcar-gen3-usb2.c | 6 ++---- drivers/phy/renesas/phy-rcar-gen3-usb3.c | 6 ++---- drivers/phy/renesas/r8a779f0-ether-serdes.c | 6 ++---- drivers/phy/rockchip/phy-rockchip-inno-csidphy.c | 6 ++---- drivers/phy/rockchip/phy-rockchip-inno-dsidphy.c | 6 ++---- drivers/phy/rockchip/phy-rockchip-inno-hdmi.c | 6 ++---- drivers/phy/rockchip/phy-rockchip-typec.c | 6 ++---- drivers/phy/st/phy-stm32-usbphyc.c | 6 ++---- drivers/phy/tegra/xusb.c | 6 ++---- drivers/phy/ti/phy-am654-serdes.c | 6 ++---- drivers/phy/ti/phy-da8xx-usb.c | 6 ++---- drivers/phy/ti/phy-dm816x-usb.c | 6 ++---- drivers/phy/ti/phy-j721e-wiz.c | 6 ++---- drivers/phy/ti/phy-omap-usb2.c | 6 ++---- drivers/phy/ti/phy-ti-pipe3.c | 6 ++---- drivers/phy/ti/phy-twl4030-usb.c | 6 ++---- 31 files changed, 63 insertions(+), 123 deletions(-) base-commit: fe15c26ee26efa11741a7b632e9f23b01aca4cc6