| Message ID | 20230901131711.2861283-1-yoshihiro.shimoda.uh@renesas.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | dt-bindings: PCI: Revise dwc and rcar-gen4-pcie | expand |
On Fri, Sep 01, 2023 at 10:17:08PM +0900, Yoshihiro Shimoda wrote: > This patch series is based on pci.git / controller/rcar branch > to fix dt-bindings doc patches. Krzysztof mentioned that the paches > will be squashed everything later [1]. > > [1] > https://lore.kernel.org/linux-pci/20230831140426.GA255922@rocinante/ On the basis of it being squashed: Acked-by: Conor Dooley <conor.dooley@microchip.com> Otherwise, the commit messages don't offer explanation of what the problems are etc. "Fix minor issues of rcar-gen4-pci-ep.yaml." means nothing to me, for example. A link to the comments you were addressing would have been nice. Thanks, Conor. > > Yoshihiro Shimoda (3): > dt-bindings: PCI: dwc: Update maxItems of reg and reg-names take 2 > dt-bindings: PCI: rcar-gen4-pcie: Fix minor issues > dt-bindings: PCI: rcar-gen4-pcie-ep: Fix minor issues > > .../bindings/pci/rcar-gen4-pci-ep.yaml | 39 ++++++++++++------- > .../bindings/pci/rcar-gen4-pci-host.yaml | 36 +++++++++-------- > .../bindings/pci/snps,dw-pcie-common.yaml | 4 +- > .../bindings/pci/snps,dw-pcie-ep.yaml | 4 +- > .../devicetree/bindings/pci/snps,dw-pcie.yaml | 4 +- > 5 files changed, 50 insertions(+), 37 deletions(-) > > -- > 2.25.1 >
Hi Conor, > From: Conor Dooley, Sent: Saturday, September 2, 2023 12:53 AM > > On Fri, Sep 01, 2023 at 10:17:08PM +0900, Yoshihiro Shimoda wrote: > > This patch series is based on pci.git / controller/rcar branch > > to fix dt-bindings doc patches. Krzysztof mentioned that the paches > > will be squashed everything later [1]. > > > > [1] > > https://lore.kernel.org/linux-pci/20230831140426.GA255922@rocinante/ > > On the basis of it being squashed: > Acked-by: Conor Dooley <conor.dooley@microchip.com> Thank you for your Acked-by! > Otherwise, the commit messages don't offer explanation of what the > problems are etc. "Fix minor issues of rcar-gen4-pci-ep.yaml." means > nothing to me, for example. A link to the comments you were addressing > would have been nice. Thank you for your suggestion! I understood it. I'll do that if I have next time. Best regards, Yoshihiro Shimoda > Thanks, > Conor. > > > > > Yoshihiro Shimoda (3): > > dt-bindings: PCI: dwc: Update maxItems of reg and reg-names take 2 > > dt-bindings: PCI: rcar-gen4-pcie: Fix minor issues > > dt-bindings: PCI: rcar-gen4-pcie-ep: Fix minor issues > > > > .../bindings/pci/rcar-gen4-pci-ep.yaml | 39 ++++++++++++------- > > .../bindings/pci/rcar-gen4-pci-host.yaml | 36 +++++++++-------- > > .../bindings/pci/snps,dw-pcie-common.yaml | 4 +- > > .../bindings/pci/snps,dw-pcie-ep.yaml | 4 +- > > .../devicetree/bindings/pci/snps,dw-pcie.yaml | 4 +- > > 5 files changed, 50 insertions(+), 37 deletions(-) > > > > -- > > 2.25.1 > >
Hello, > > This patch series is based on pci.git / controller/rcar branch > > to fix dt-bindings doc patches. Krzysztof mentioned that the paches > > will be squashed everything later [1]. > > > > [1] > > https://lore.kernel.org/linux-pci/20230831140426.GA255922@rocinante/ [...] > > A link to the comments you were addressing would have been nice. For posterity, so it's easier to link things together: - https://lore.kernel.org/linux-pci/20230825093219.2685912-14-yoshihiro.shimoda.uh@renesas.com - https://lore.kernel.org/linux-pci/20230825093219.2685912-15-yoshihiro.shimoda.uh@renesas.com - https://lore.kernel.org/linux-pci/20230825093219.2685912-16-yoshihiro.shimoda.uh@renesas.com Krzysztof
Hello, > This patch series is based on pci.git / controller/rcar branch > to fix dt-bindings doc patches. Krzysztof mentioned that the paches > will be squashed everything later [1]. Applied and squashed against prior patches: - https://git.kernel.org/pci/pci/c/554931ed3795 - https://git.kernel.org/pci/pci/c/d828097a0bef - https://git.kernel.org/pci/pci/c/c1ff8c2d1a8c Thank you, Shimoda-san! Krzysztof
Hello Krzysztof-san, > From: Krzysztof Wilczyński, Sent: Tuesday, September 5, 2023 1:23 PM > > Hello, > > > This patch series is based on pci.git / controller/rcar branch > > to fix dt-bindings doc patches. Krzysztof mentioned that the paches > > will be squashed everything later [1]. > > Applied and squashed against prior patches: > > - https://git.kernel.org/pci/pci/c/554931ed3795 > - https://git.kernel.org/pci/pci/c/d828097a0bef > - https://git.kernel.org/pci/pci/c/c1ff8c2d1a8c Thank you for your support! The controller/rcar branch looks good to me. However, I realized that the controller/rcar branch cannot be merged into the main branch now because conflict happened. In this case, should I send fix patches again like this time? Best regards, Yoshihiro Shimoda