[v5,0/3] gnss: ubx: support the reset pin of the Neo-M8 variant

Message

Wolfram Sang Nov. 13, 2023, 12:51 a.m. UTC

The Renesas KingFisher board includes a U-Blox Neo-M8 chip with its
reset pin wired to a GPIO. To support that, we need "reset-gpio" support
(patches 2+3). But first, simplify regulator handling with a new helper
(patch 1).

Changes since v4:

* don't touch reset during open/close. Only deassert it during probe.
  [patch 3]


Wolfram Sang (3):
  gnss: ubx: use new helper to remove open coded regulator handling
  dt-bindings: gnss: u-blox: add "reset-gpios" binding
  gnss: ubx: add support for the reset gpio

 .../bindings/gnss/u-blox,neo-6m.yaml          |  5 +++
 drivers/gnss/ubx.c                            | 31 +++++++------------
 2 files changed, 16 insertions(+), 20 deletions(-)

Comments

Wolfram Sang Dec. 12, 2023, 3:30 a.m. UTC | #1

On Sun, Nov 12, 2023 at 07:51:48PM -0500, Wolfram Sang wrote:
> The Renesas KingFisher board includes a U-Blox Neo-M8 chip with its
> reset pin wired to a GPIO. To support that, we need "reset-gpio" support
> (patches 2+3). But first, simplify regulator handling with a new helper
> (patch 1).
> 
> Changes since v4:
> 
> * don't touch reset during open/close. Only deassert it during probe.
>   [patch 3]

Johan, all good now?

Happy hacking,

   Wolfram

Wolfram Sang Dec. 14, 2023, 3:53 p.m. UTC | #2

On Tue, Dec 12, 2023 at 04:30:10AM +0100, Wolfram Sang wrote:
> On Sun, Nov 12, 2023 at 07:51:48PM -0500, Wolfram Sang wrote:
> > The Renesas KingFisher board includes a U-Blox Neo-M8 chip with its
> > reset pin wired to a GPIO. To support that, we need "reset-gpio" support
> > (patches 2+3). But first, simplify regulator handling with a new helper
> > (patch 1).
> > 
> > Changes since v4:
> > 
> > * don't touch reset during open/close. Only deassert it during probe.
> >   [patch 3]
> 
> Johan, all good now?

If there are no further comments, can we have this series in 6.8.?

Johan Hovold Dec. 15, 2023, 8:34 a.m. UTC | #3

On Thu, Dec 14, 2023 at 04:53:06PM +0100, Wolfram Sang wrote:
> On Tue, Dec 12, 2023 at 04:30:10AM +0100, Wolfram Sang wrote:
> > On Sun, Nov 12, 2023 at 07:51:48PM -0500, Wolfram Sang wrote:
> > > The Renesas KingFisher board includes a U-Blox Neo-M8 chip with its
> > > reset pin wired to a GPIO. To support that, we need "reset-gpio" support
> > > (patches 2+3). But first, simplify regulator handling with a new helper
> > > (patch 1).
> > > 
> > > Changes since v4:
> > > 
> > > * don't touch reset during open/close. Only deassert it during probe.
> > >   [patch 3]
> > 
> > Johan, all good now?
> 
> If there are no further comments, can we have this series in 6.8.?

All good. Now applied for 6.8.

Johan

Wolfram Sang Dec. 15, 2023, 8:15 p.m. UTC | #4

> All good. Now applied for 6.8.

Thank you! :)