| Message ID | 20240822162320.5084-1-biju.das.jz@bp.renesas.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | Add support for RZ/G2UL Display Unit | expand |
Hi Biju, On Thu, Aug 22, 2024 at 05:23:13PM +0100, Biju Das wrote: > This patch series aims to add support for RZ/G2UL DU. > > The LCD controller is composed of Frame Compression Processor (FCPVD), > Video Signal Processor (VSPD), and Display Unit (DU). > > The output of LCDC is connected display parallel interface (DPI) and > supports a maximum resolution of WXGA along with 2 RPFs to support the > blending of two picture layers and raster operations (ROPs) > > It is similar to LCDC IP on RZ/G2L SoCs, but does not have DSI interface. > > v3->v4: > * Restored the ports property for RZ/G2UL and described port@0 for the > DPI interface in bindings patch. > * Restored tags from Geert and Conor as the change is trivial > (Replaced port 1->0 from v2). > * Used "&" instead of "==" in rzg2l_du_start_stop() for scalability. > * Restored port variable in struct rzg2l_du_output_routing > * Updated rzg2l_du_encoders_init() to handle port based on hardware indices. > * Restored ports property in du node and used port@0 for connected > DPI interface. > v2->v3: > * Split patch series based on subsystem from DU patch series [1]. > * Replaced ports->port property for RZ/G2UL as it supports only DPI > and retained ports property for RZ/{G2L,V2L} as it supports both DSI > and DPI output interface. > * Added missing blank line before example. > * Dropped tags from Conor and Geert as there are new changes in bindings > * Avoided the line break in rzg2l_du_start_stop() for rstate. > * Replaced port->du_output in struct rzg2l_du_output_routing and > dropped using the port number to indicate the output type in > rzg2l_du_encoders_init(). > * Updated rzg2l_du_r9a07g043u_info and rzg2l_du_r9a07g044_info. > > [1] https://lore.kernel.org/all/20240709135152.185042-1-biju.das.jz@bp.renesas.com/ > v1->v2: > * Updated cover letter header "DU IP->Display Unit". > * Updated commit description related to non ABI breakage for patch#3. > * Added Ack from Conor for binding patches. > > Biju Das (4): > dt-bindings: display: renesas,rzg2l-du: Document RZ/G2UL DU bindings > drm: renesas: rz-du: Add RZ/G2UL DU Support The first two patches look good to me. Do you have access to drm-misc, will you push them yourself, or do you expect a maintainer to pick them up ? > arm64: dts: renesas: r9a07g043u: Add DU node > arm64: dts: renesas: r9a07g043u11-smarc: Enable DU > > .../bindings/display/renesas,rzg2l-du.yaml | 32 ++++- > arch/arm64/boot/dts/renesas/r9a07g043u.dtsi | 25 ++++ > .../boot/dts/renesas/r9a07g043u11-smarc.dts | 111 ++++++++++++++++++ > drivers/gpu/drm/renesas/rz-du/rzg2l_du_crtc.c | 8 +- > drivers/gpu/drm/renesas/rz-du/rzg2l_du_drv.c | 11 ++ > drivers/gpu/drm/renesas/rz-du/rzg2l_du_kms.c | 3 +- > 6 files changed, 185 insertions(+), 5 deletions(-)
Hi Laurent, > -----Original Message----- > From: Laurent Pinchart <laurent.pinchart@ideasonboard.com> > Sent: Friday, August 23, 2024 2:15 PM > Subject: Re: [PATCH v4 0/4] Add support for RZ/G2UL Display Unit > > Hi Biju, > > On Thu, Aug 22, 2024 at 05:23:13PM +0100, Biju Das wrote: > > This patch series aims to add support for RZ/G2UL DU. > > > > The LCD controller is composed of Frame Compression Processor (FCPVD), > > Video Signal Processor (VSPD), and Display Unit (DU). > > > > The output of LCDC is connected display parallel interface (DPI) and > > supports a maximum resolution of WXGA along with 2 RPFs to support the > > blending of two picture layers and raster operations (ROPs) > > > > It is similar to LCDC IP on RZ/G2L SoCs, but does not have DSI interface. > > > > v3->v4: > > * Restored the ports property for RZ/G2UL and described port@0 for the > > DPI interface in bindings patch. > > * Restored tags from Geert and Conor as the change is trivial > > (Replaced port 1->0 from v2). > > * Used "&" instead of "==" in rzg2l_du_start_stop() for scalability. > > * Restored port variable in struct rzg2l_du_output_routing > > * Updated rzg2l_du_encoders_init() to handle port based on hardware indices. > > * Restored ports property in du node and used port@0 for connected > > DPI interface. > > v2->v3: > > * Split patch series based on subsystem from DU patch series [1]. > > * Replaced ports->port property for RZ/G2UL as it supports only DPI > > and retained ports property for RZ/{G2L,V2L} as it supports both DSI > > and DPI output interface. > > * Added missing blank line before example. > > * Dropped tags from Conor and Geert as there are new changes in > > bindings > > * Avoided the line break in rzg2l_du_start_stop() for rstate. > > * Replaced port->du_output in struct rzg2l_du_output_routing and > > dropped using the port number to indicate the output type in > > rzg2l_du_encoders_init(). > > * Updated rzg2l_du_r9a07g043u_info and rzg2l_du_r9a07g044_info. > > > > [1] > > https://lore.kernel.org/all/20240709135152.185042-1-biju.das.jz@bp.ren > > esas.com/ > > v1->v2: > > * Updated cover letter header "DU IP->Display Unit". > > * Updated commit description related to non ABI breakage for patch#3. > > * Added Ack from Conor for binding patches. > > > > Biju Das (4): > > dt-bindings: display: renesas,rzg2l-du: Document RZ/G2UL DU bindings > > drm: renesas: rz-du: Add RZ/G2UL DU Support > > The first two patches look good to me. Do you have access to drm-misc, will you push them yourself, or > do you expect a maintainer to pick them up ? I don’t have access to drm-misc. I expect a maintainer to pick it up(Maybe via rcar-du tree or drm-misc tree), or else if it is ok, what is the procedure to get access for drm-misc tree?? Cheers, Biju > > > arm64: dts: renesas: r9a07g043u: Add DU node > > arm64: dts: renesas: r9a07g043u11-smarc: Enable DU > > > > .../bindings/display/renesas,rzg2l-du.yaml | 32 ++++- > > arch/arm64/boot/dts/renesas/r9a07g043u.dtsi | 25 ++++ > > .../boot/dts/renesas/r9a07g043u11-smarc.dts | 111 ++++++++++++++++++ > > drivers/gpu/drm/renesas/rz-du/rzg2l_du_crtc.c | 8 +- > > drivers/gpu/drm/renesas/rz-du/rzg2l_du_drv.c | 11 ++ > > drivers/gpu/drm/renesas/rz-du/rzg2l_du_kms.c | 3 +- > > 6 files changed, 185 insertions(+), 5 deletions(-) > > -- > Regards, > > Laurent Pinchart
Hi Biju, On Fri, Aug 23, 2024 at 01:52:14PM +0000, Biju Das wrote: > On Friday, August 23, 2024 2:15 PM, Laurent Pinchart wrote: > > On Thu, Aug 22, 2024 at 05:23:13PM +0100, Biju Das wrote: > > > This patch series aims to add support for RZ/G2UL DU. > > > > > > The LCD controller is composed of Frame Compression Processor (FCPVD), > > > Video Signal Processor (VSPD), and Display Unit (DU). > > > > > > The output of LCDC is connected display parallel interface (DPI) and > > > supports a maximum resolution of WXGA along with 2 RPFs to support the > > > blending of two picture layers and raster operations (ROPs) > > > > > > It is similar to LCDC IP on RZ/G2L SoCs, but does not have DSI interface. > > > > > > v3->v4: > > > * Restored the ports property for RZ/G2UL and described port@0 for the > > > DPI interface in bindings patch. > > > * Restored tags from Geert and Conor as the change is trivial > > > (Replaced port 1->0 from v2). > > > * Used "&" instead of "==" in rzg2l_du_start_stop() for scalability. > > > * Restored port variable in struct rzg2l_du_output_routing > > > * Updated rzg2l_du_encoders_init() to handle port based on hardware indices. > > > * Restored ports property in du node and used port@0 for connected > > > DPI interface. > > > v2->v3: > > > * Split patch series based on subsystem from DU patch series [1]. > > > * Replaced ports->port property for RZ/G2UL as it supports only DPI > > > and retained ports property for RZ/{G2L,V2L} as it supports both DSI > > > and DPI output interface. > > > * Added missing blank line before example. > > > * Dropped tags from Conor and Geert as there are new changes in bindings > > > * Avoided the line break in rzg2l_du_start_stop() for rstate. > > > * Replaced port->du_output in struct rzg2l_du_output_routing and > > > dropped using the port number to indicate the output type in > > > rzg2l_du_encoders_init(). > > > * Updated rzg2l_du_r9a07g043u_info and rzg2l_du_r9a07g044_info. > > > > > > [1] https://lore.kernel.org/all/20240709135152.185042-1-biju.das.jz@bp.renesas.com/ > > > v1->v2: > > > * Updated cover letter header "DU IP->Display Unit". > > > * Updated commit description related to non ABI breakage for patch#3. > > > * Added Ack from Conor for binding patches. > > > > > > Biju Das (4): > > > dt-bindings: display: renesas,rzg2l-du: Document RZ/G2UL DU bindings > > > drm: renesas: rz-du: Add RZ/G2UL DU Support > > > > The first two patches look good to me. Do you have access to drm-misc, will you push them yourself, or > > do you expect a maintainer to pick them up ? > > I don’t have access to drm-misc. I expect a maintainer to pick it up(Maybe via rcar-du tree or > drm-misc tree), or else if it is ok, what is the procedure to get access for drm-misc tree?? You can find instructions to request drm-misc commit access at https://drm.pages.freedesktop.org/maintainer-tools/committer/commit-access.html Tomi, to avoid delays, could you push the first two patches to drm-misc ? > > > arm64: dts: renesas: r9a07g043u: Add DU node > > > arm64: dts: renesas: r9a07g043u11-smarc: Enable DU > > > > > > .../bindings/display/renesas,rzg2l-du.yaml | 32 ++++- > > > arch/arm64/boot/dts/renesas/r9a07g043u.dtsi | 25 ++++ > > > .../boot/dts/renesas/r9a07g043u11-smarc.dts | 111 ++++++++++++++++++ > > > drivers/gpu/drm/renesas/rz-du/rzg2l_du_crtc.c | 8 +- > > > drivers/gpu/drm/renesas/rz-du/rzg2l_du_drv.c | 11 ++ > > > drivers/gpu/drm/renesas/rz-du/rzg2l_du_kms.c | 3 +- > > > 6 files changed, 185 insertions(+), 5 deletions(-)
Hi Laurent, > -----Original Message----- > From: Laurent Pinchart <laurent.pinchart@ideasonboard.com> > Sent: Friday, August 23, 2024 4:00 PM > Subject: Re: [PATCH v4 0/4] Add support for RZ/G2UL Display Unit > > Hi Biju, > > On Fri, Aug 23, 2024 at 01:52:14PM +0000, Biju Das wrote: > > On Friday, August 23, 2024 2:15 PM, Laurent Pinchart wrote: > > > On Thu, Aug 22, 2024 at 05:23:13PM +0100, Biju Das wrote: > > > > This patch series aims to add support for RZ/G2UL DU. > > > > > > > > The LCD controller is composed of Frame Compression Processor > > > > (FCPVD), Video Signal Processor (VSPD), and Display Unit (DU). > > > > > > > > The output of LCDC is connected display parallel interface (DPI) > > > > and supports a maximum resolution of WXGA along with 2 RPFs to > > > > support the blending of two picture layers and raster operations > > > > (ROPs) > > > > > > > > It is similar to LCDC IP on RZ/G2L SoCs, but does not have DSI interface. > > > > > > > > v3->v4: > > > > * Restored the ports property for RZ/G2UL and described port@0 for the > > > > DPI interface in bindings patch. > > > > * Restored tags from Geert and Conor as the change is trivial > > > > (Replaced port 1->0 from v2). > > > > * Used "&" instead of "==" in rzg2l_du_start_stop() for scalability. > > > > * Restored port variable in struct rzg2l_du_output_routing > > > > * Updated rzg2l_du_encoders_init() to handle port based on hardware indices. > > > > * Restored ports property in du node and used port@0 for connected > > > > DPI interface. > > > > v2->v3: > > > > * Split patch series based on subsystem from DU patch series [1]. > > > > * Replaced ports->port property for RZ/G2UL as it supports only DPI > > > > and retained ports property for RZ/{G2L,V2L} as it supports both DSI > > > > and DPI output interface. > > > > * Added missing blank line before example. > > > > * Dropped tags from Conor and Geert as there are new changes in > > > > bindings > > > > * Avoided the line break in rzg2l_du_start_stop() for rstate. > > > > * Replaced port->du_output in struct rzg2l_du_output_routing and > > > > dropped using the port number to indicate the output type in > > > > rzg2l_du_encoders_init(). > > > > * Updated rzg2l_du_r9a07g043u_info and rzg2l_du_r9a07g044_info. > > > > > > > > [1] > > > > https://lore.kernel.org/all/20240709135152.185042-1-biju.das.jz@bp > > > > .renesas.com/ > > > > v1->v2: > > > > * Updated cover letter header "DU IP->Display Unit". > > > > * Updated commit description related to non ABI breakage for patch#3. > > > > * Added Ack from Conor for binding patches. > > > > > > > > Biju Das (4): > > > > dt-bindings: display: renesas,rzg2l-du: Document RZ/G2UL DU bindings > > > > drm: renesas: rz-du: Add RZ/G2UL DU Support > > > > > > The first two patches look good to me. Do you have access to > > > drm-misc, will you push them yourself, or do you expect a maintainer to pick them up ? > > > > I don’t have access to drm-misc. I expect a maintainer to pick it > > up(Maybe via rcar-du tree or drm-misc tree), or else if it is ok, what is the procedure to get > access for drm-misc tree?? > > You can find instructions to request drm-misc commit access at > https://drm.pages.freedesktop.org/maintainer-tools/committer/commit-access.html Thanks for the link. Meantime, I have requested for access [1] [1] https://gitlab.freedesktop.org/drm/misc/kernel/-/issues/48 Cheers, Biju > > Tomi, to avoid delays, could you push the first two patches to drm-misc ? > > > > > arm64: dts: renesas: r9a07g043u: Add DU node > > > > arm64: dts: renesas: r9a07g043u11-smarc: Enable DU > > > > > > > > .../bindings/display/renesas,rzg2l-du.yaml | 32 ++++- > > > > arch/arm64/boot/dts/renesas/r9a07g043u.dtsi | 25 ++++ > > > > .../boot/dts/renesas/r9a07g043u11-smarc.dts | 111 ++++++++++++++++++ > > > > drivers/gpu/drm/renesas/rz-du/rzg2l_du_crtc.c | 8 +- > > > > drivers/gpu/drm/renesas/rz-du/rzg2l_du_drv.c | 11 ++ > > > > drivers/gpu/drm/renesas/rz-du/rzg2l_du_kms.c | 3 +- > > > > 6 files changed, 185 insertions(+), 5 deletions(-) > > -- > Regards, > > Laurent Pinchart
Hi, On 23/08/2024 18:00, Laurent Pinchart wrote: > Hi Biju, > > On Fri, Aug 23, 2024 at 01:52:14PM +0000, Biju Das wrote: >> On Friday, August 23, 2024 2:15 PM, Laurent Pinchart wrote: >>> On Thu, Aug 22, 2024 at 05:23:13PM +0100, Biju Das wrote: >>>> This patch series aims to add support for RZ/G2UL DU. >>>> >>>> The LCD controller is composed of Frame Compression Processor (FCPVD), >>>> Video Signal Processor (VSPD), and Display Unit (DU). >>>> >>>> The output of LCDC is connected display parallel interface (DPI) and >>>> supports a maximum resolution of WXGA along with 2 RPFs to support the >>>> blending of two picture layers and raster operations (ROPs) >>>> >>>> It is similar to LCDC IP on RZ/G2L SoCs, but does not have DSI interface. >>>> >>>> v3->v4: >>>> * Restored the ports property for RZ/G2UL and described port@0 for the >>>> DPI interface in bindings patch. >>>> * Restored tags from Geert and Conor as the change is trivial >>>> (Replaced port 1->0 from v2). >>>> * Used "&" instead of "==" in rzg2l_du_start_stop() for scalability. >>>> * Restored port variable in struct rzg2l_du_output_routing >>>> * Updated rzg2l_du_encoders_init() to handle port based on hardware indices. >>>> * Restored ports property in du node and used port@0 for connected >>>> DPI interface. >>>> v2->v3: >>>> * Split patch series based on subsystem from DU patch series [1]. >>>> * Replaced ports->port property for RZ/G2UL as it supports only DPI >>>> and retained ports property for RZ/{G2L,V2L} as it supports both DSI >>>> and DPI output interface. >>>> * Added missing blank line before example. >>>> * Dropped tags from Conor and Geert as there are new changes in bindings >>>> * Avoided the line break in rzg2l_du_start_stop() for rstate. >>>> * Replaced port->du_output in struct rzg2l_du_output_routing and >>>> dropped using the port number to indicate the output type in >>>> rzg2l_du_encoders_init(). >>>> * Updated rzg2l_du_r9a07g043u_info and rzg2l_du_r9a07g044_info. >>>> >>>> [1] https://lore.kernel.org/all/20240709135152.185042-1-biju.das.jz@bp.renesas.com/ >>>> v1->v2: >>>> * Updated cover letter header "DU IP->Display Unit". >>>> * Updated commit description related to non ABI breakage for patch#3. >>>> * Added Ack from Conor for binding patches. >>>> >>>> Biju Das (4): >>>> dt-bindings: display: renesas,rzg2l-du: Document RZ/G2UL DU bindings >>>> drm: renesas: rz-du: Add RZ/G2UL DU Support >>> >>> The first two patches look good to me. Do you have access to drm-misc, will you push them yourself, or >>> do you expect a maintainer to pick them up ? >> >> I don’t have access to drm-misc. I expect a maintainer to pick it up(Maybe via rcar-du tree or >> drm-misc tree), or else if it is ok, what is the procedure to get access for drm-misc tree?? > > You can find instructions to request drm-misc commit access at > https://drm.pages.freedesktop.org/maintainer-tools/committer/commit-access.html > > Tomi, to avoid delays, could you push the first two patches to drm-misc > ? I have pushed the first two patches. Tomi
> -----Original Message----- > From: Tomi Valkeinen <tomi.valkeinen@ideasonboard.com> > Sent: Monday, August 26, 2024 10:51 AM > Subject: Re: [PATCH v4 0/4] Add support for RZ/G2UL Display Unit > > Hi, > > On 23/08/2024 18:00, Laurent Pinchart wrote: > > Hi Biju, > > > > On Fri, Aug 23, 2024 at 01:52:14PM +0000, Biju Das wrote: > >> On Friday, August 23, 2024 2:15 PM, Laurent Pinchart wrote: > >>> On Thu, Aug 22, 2024 at 05:23:13PM +0100, Biju Das wrote: > >>>> This patch series aims to add support for RZ/G2UL DU. > >>>> > >>>> The LCD controller is composed of Frame Compression Processor > >>>> (FCPVD), Video Signal Processor (VSPD), and Display Unit (DU). > >>>> > >>>> The output of LCDC is connected display parallel interface (DPI) > >>>> and supports a maximum resolution of WXGA along with 2 RPFs to > >>>> support the blending of two picture layers and raster operations > >>>> (ROPs) > >>>> > >>>> It is similar to LCDC IP on RZ/G2L SoCs, but does not have DSI interface. > >>>> > >>>> v3->v4: > >>>> * Restored the ports property for RZ/G2UL and described port@0 for the > >>>> DPI interface in bindings patch. > >>>> * Restored tags from Geert and Conor as the change is trivial > >>>> (Replaced port 1->0 from v2). > >>>> * Used "&" instead of "==" in rzg2l_du_start_stop() for scalability. > >>>> * Restored port variable in struct rzg2l_du_output_routing > >>>> * Updated rzg2l_du_encoders_init() to handle port based on hardware indices. > >>>> * Restored ports property in du node and used port@0 for connected > >>>> DPI interface. > >>>> v2->v3: > >>>> * Split patch series based on subsystem from DU patch series [1]. > >>>> * Replaced ports->port property for RZ/G2UL as it supports only DPI > >>>> and retained ports property for RZ/{G2L,V2L} as it supports both DSI > >>>> and DPI output interface. > >>>> * Added missing blank line before example. > >>>> * Dropped tags from Conor and Geert as there are new changes in bindings > >>>> * Avoided the line break in rzg2l_du_start_stop() for rstate. > >>>> * Replaced port->du_output in struct rzg2l_du_output_routing and > >>>> dropped using the port number to indicate the output type in > >>>> rzg2l_du_encoders_init(). > >>>> * Updated rzg2l_du_r9a07g043u_info and rzg2l_du_r9a07g044_info. > >>>> > >>>> [1] > >>>> https://lore.kernel.org/all/20240709135152.185042-1-biju.das.jz@bp. > >>>> renesas.com/ > >>>> v1->v2: > >>>> * Updated cover letter header "DU IP->Display Unit". > >>>> * Updated commit description related to non ABI breakage for patch#3. > >>>> * Added Ack from Conor for binding patches. > >>>> > >>>> Biju Das (4): > >>>> dt-bindings: display: renesas,rzg2l-du: Document RZ/G2UL DU bindings > >>>> drm: renesas: rz-du: Add RZ/G2UL DU Support > >>> > >>> The first two patches look good to me. Do you have access to > >>> drm-misc, will you push them yourself, or do you expect a maintainer to pick them up ? > >> > >> I don’t have access to drm-misc. I expect a maintainer to pick it > >> up(Maybe via rcar-du tree or drm-misc tree), or else if it is ok, what is the procedure to get > access for drm-misc tree?? > > > > You can find instructions to request drm-misc commit access at > > https://drm.pages.freedesktop.org/maintainer-tools/committer/commit-ac > > cess.html > > > > Tomi, to avoid delays, could you push the first two patches to > > drm-misc ? > > I have pushed the first two patches. Thanks Tomi. Cheers, Biju
This patch series aims to add support for RZ/G2UL DU. The LCD controller is composed of Frame Compression Processor (FCPVD), Video Signal Processor (VSPD), and Display Unit (DU). The output of LCDC is connected display parallel interface (DPI) and supports a maximum resolution of WXGA along with 2 RPFs to support the blending of two picture layers and raster operations (ROPs) It is similar to LCDC IP on RZ/G2L SoCs, but does not have DSI interface. v3->v4: * Restored the ports property for RZ/G2UL and described port@0 for the DPI interface in bindings patch. * Restored tags from Geert and Conor as the change is trivial (Replaced port 1->0 from v2). * Used "&" instead of "==" in rzg2l_du_start_stop() for scalability. * Restored port variable in struct rzg2l_du_output_routing * Updated rzg2l_du_encoders_init() to handle port based on hardware indices. * Restored ports property in du node and used port@0 for connected DPI interface. v2->v3: * Split patch series based on subsystem from DU patch series [1]. * Replaced ports->port property for RZ/G2UL as it supports only DPI and retained ports property for RZ/{G2L,V2L} as it supports both DSI and DPI output interface. * Added missing blank line before example. * Dropped tags from Conor and Geert as there are new changes in bindings * Avoided the line break in rzg2l_du_start_stop() for rstate. * Replaced port->du_output in struct rzg2l_du_output_routing and dropped using the port number to indicate the output type in rzg2l_du_encoders_init(). * Updated rzg2l_du_r9a07g043u_info and rzg2l_du_r9a07g044_info. [1] https://lore.kernel.org/all/20240709135152.185042-1-biju.das.jz@bp.renesas.com/ v1->v2: * Updated cover letter header "DU IP->Display Unit". * Updated commit description related to non ABI breakage for patch#3. * Added Ack from Conor for binding patches. Biju Das (4): dt-bindings: display: renesas,rzg2l-du: Document RZ/G2UL DU bindings drm: renesas: rz-du: Add RZ/G2UL DU Support arm64: dts: renesas: r9a07g043u: Add DU node arm64: dts: renesas: r9a07g043u11-smarc: Enable DU .../bindings/display/renesas,rzg2l-du.yaml | 32 ++++- arch/arm64/boot/dts/renesas/r9a07g043u.dtsi | 25 ++++ .../boot/dts/renesas/r9a07g043u11-smarc.dts | 111 ++++++++++++++++++ drivers/gpu/drm/renesas/rz-du/rzg2l_du_crtc.c | 8 +- drivers/gpu/drm/renesas/rz-du/rzg2l_du_drv.c | 11 ++ drivers/gpu/drm/renesas/rz-du/rzg2l_du_kms.c | 3 +- 6 files changed, 185 insertions(+), 5 deletions(-)