| Message ID | 20241206212559.192705-1-john.madieu.xa@bp.renesas.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | soc: renesas: Add system controller support for RZ/G3E SoC | expand |
On Fri, Dec 06, 2024 at 10:25:54PM +0100, John Madieu wrote: > This patch series adds support for the RZ/G3E system controller and extends > the existing RZ/V2H(P) system controller to support syscon. The RZ/G3E > system controller allows detecting various SoC features like core count, > NPU availability, and CA55 PLL configuration. > > Key features: > - Syscon support for both RZ/V2H and RZ/G3E system controllers > - Detection of quad/dual core configuration > - Detection of Ethos-U55 NPU presence > - Validation of CA55 PLL frequency setting > - SoC-specific extended identification through callbacks This series and some other questions about syscon prompted me to look into syscon driver a bit. Consider this resulting series[1] in context with your changes. Rob [1] https://lore.kernel.org/all/20241211-syscon-fixes-v1-3-b5ac8c219e96@kernel.org/
Hi Rob, On Wed, Dec 11, 2024 at 10:08 PM Rob Herring <robh@kernel.org> wrote: > On Fri, Dec 06, 2024 at 10:25:54PM +0100, John Madieu wrote: > > This patch series adds support for the RZ/G3E system controller and extends > > the existing RZ/V2H(P) system controller to support syscon. The RZ/G3E > > system controller allows detecting various SoC features like core count, > > NPU availability, and CA55 PLL configuration. > > > > Key features: > > - Syscon support for both RZ/V2H and RZ/G3E system controllers > > - Detection of quad/dual core configuration > > - Detection of Ethos-U55 NPU presence > > - Validation of CA55 PLL frequency setting > > - SoC-specific extended identification through callbacks > > This series and some other questions about syscon prompted me to look > into syscon driver a bit. Consider this resulting series[1] in context > with your changes. > > Rob > > [1] https://lore.kernel.org/all/20241211-syscon-fixes-v1-3-b5ac8c219e96@kernel.org/ Thank you, not having to add a "syscon" compatible value makes perfect sense! Gr{oetje,eeting}s, Geert
Hi John, On Fri, Dec 6, 2024 at 10:26 PM John Madieu <john.madieu.xa@bp.renesas.com> wrote: > This patch series adds support for the RZ/G3E system controller and extends > the existing RZ/V2H(P) system controller to support syscon. The RZ/G3E > system controller allows detecting various SoC features like core count, > NPU availability, and CA55 PLL configuration. > > Key features: > - Syscon support for both RZ/V2H and RZ/G3E system controllers > - Detection of quad/dual core configuration > - Detection of Ethos-U55 NPU presence > - Validation of CA55 PLL frequency setting > - SoC-specific extended identification through callbacks Thanks for your series! > This patch series depends upon [1] and [2]. > > Tested: > - Example of SoC detection: > [ 0.065608] renesas-rz-sysc 10430000.system-controller: Detected Renesas Quad Core RZ/G3E r9a09g047 Rev 0 with Ethos-U55 > - Example of PLL misconfiguration warning: > [ 0.065616] renesas-rz-sysc 10430000.system-controller: CA55 PLL is not set to 1.7GHz > > [1] https://patchwork.kernel.org/project/linux-renesas-soc/list/?series=914097 > [2] https://patchwork.kernel.org/project/linux-renesas-soc/list/?series=912697 The latter points to an already-applied unrelated series. I assume you meant "[PATCH v2 00/15] Add initial USB support for the Renesas RZ/G3S SoC"[3]? [3] https://lore.kernel.org/all/20241126092050.1825607-1-claudiu.beznea.uj@bp.renesas.com/ Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds
> -----Original Message----- > From: Geert Uytterhoeven <geert@linux-m68k.org> > Sent: Friday, December 13, 2024 5:25 PM > Subject: Re: [PATCH 0/5] soc: renesas: Add system controller support for > RZ/G3E SoC > > Hi John, Hello Geert, > > On Fri, Dec 6, 2024 at 10:26 PM John Madieu > <john.madieu.xa@bp.renesas.com> wrote: > > This patch series adds support for the RZ/G3E system controller and > > extends the existing RZ/V2H(P) system controller to support syscon. > > The RZ/G3E system controller allows detecting various SoC features > > like core count, NPU availability, and CA55 PLL configuration. > > > > Key features: > > - Syscon support for both RZ/V2H and RZ/G3E system controllers > > - Detection of quad/dual core configuration > > - Detection of Ethos-U55 NPU presence > > - Validation of CA55 PLL frequency setting > > - SoC-specific extended identification through callbacks > > Thanks for your series! > > > This patch series depends upon [1] and [2]. > > > > Tested: > > - Example of SoC detection: > > [ 0.065608] renesas-rz-sysc 10430000.system-controller: Detected > Renesas Quad Core RZ/G3E r9a09g047 Rev 0 with Ethos-U55 > > - Example of PLL misconfiguration warning: > > [ 0.065616] renesas-rz-sysc 10430000.system-controller: CA55 PLL is > not set to 1.7GHz > > > > The latter points to an already-applied unrelated series. I assume you > meant "[PATCH v2 00/15] Add initial USB support for the Renesas RZ/G3S > SoC"[3]? You are right about [3], as it's the series that adds initial support for the SYSC driver. > > > Gr{oetje,eeting}s, > > Geert > > -- > Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux- > m68k.org > > In personal conversations with technical people, I call myself a hacker. > But when I'm talking to journalists I just say "programmer" or something > like that. > -- Linus Torvalds
This patch series adds support for the RZ/G3E system controller and extends the existing RZ/V2H(P) system controller to support syscon. The RZ/G3E system controller allows detecting various SoC features like core count, NPU availability, and CA55 PLL configuration. Key features: - Syscon support for both RZ/V2H and RZ/G3E system controllers - Detection of quad/dual core configuration - Detection of Ethos-U55 NPU presence - Validation of CA55 PLL frequency setting - SoC-specific extended identification through callbacks This patch series depends upon [1] and [2]. Tested: - Example of SoC detection: [ 0.065608] renesas-rz-sysc 10430000.system-controller: Detected Renesas Quad Core RZ/G3E r9a09g047 Rev 0 with Ethos-U55 - Example of PLL misconfiguration warning: [ 0.065616] renesas-rz-sysc 10430000.system-controller: CA55 PLL is not set to 1.7GHz [1] https://patchwork.kernel.org/project/linux-renesas-soc/list/?series=914097 [2] https://patchwork.kernel.org/project/linux-renesas-soc/list/?series=912697 John Madieu (5): dt-bindings: arm: renesas: Add syscon compatibility to RZ/V2H(P) SYS Controller dt-bindings: soc: renesas: Document Renesas RZ/G3E SoC variants soc: renesas: rz-sysc: Add support for RZ/G3E family arm64: dts: renesas: r9a09g047: add sys node arm64: dts: renesas: r9a09g057: Add syscon compatibility to sys node .../soc/renesas/renesas,r9a09g057-sys.yaml | 8 ++- arch/arm64/boot/dts/renesas/r9a09g047.dtsi | 7 ++ arch/arm64/boot/dts/renesas/r9a09g057.dtsi | 2 +- drivers/soc/renesas/Kconfig | 6 ++ drivers/soc/renesas/Makefile | 1 + drivers/soc/renesas/r9a09g047-sysc.c | 70 +++++++++++++++++++ drivers/soc/renesas/rz-sysc.c | 44 ++++++++---- drivers/soc/renesas/rz-sysc.h | 7 ++ 8 files changed, 128 insertions(+), 17 deletions(-) create mode 100644 drivers/soc/renesas/r9a09g047-sysc.c