[net-next,0/4] mdio support updates

Message

Nikita Yushchenko Dec. 8, 2024, 3:52 p.m. UTC

This series cleans up rswitch mdio support, and adds C22 operations.

Nikita Yushchenko (4):
  net: renesas: rswitch: do not write to MPSM register at init time
  net: renesas: rswitch: align mdio C45 operations with datasheet
  net: renesas: rswitch: use generic MPSM operation for mdio C45
  net: renesas: rswitch: add mdio C22 support

 drivers/net/ethernet/renesas/rswitch.c | 79 ++++++++++++++++----------
 drivers/net/ethernet/renesas/rswitch.h | 17 ++++--
 2 files changed, 60 insertions(+), 36 deletions(-)

Comments

Yoshihiro Shimoda Dec. 10, 2024, 12:08 p.m. UTC | #1

Hello Nikita-san,

> From: Nikita Yushchenko, Sent: Monday, December 9, 2024 12:53 AM
> 
> This series cleans up rswitch mdio support, and adds C22 operations.
> 
> Nikita Yushchenko (4):
>   net: renesas: rswitch: do not write to MPSM register at init time
>   net: renesas: rswitch: align mdio C45 operations with datasheet
>   net: renesas: rswitch: use generic MPSM operation for mdio C45
>   net: renesas: rswitch: add mdio C22 support

Thank you for the patches. They look good to me. So,

Reviewed-by: Yoshihiro Shimoda <[e-mail]>

And, I tested the patches on my environment (R-Car S4 Spider), and
it worked without any regression. So,

Tested-by: Yoshihiro Shimoda <[e-mail]>

Best regards,
Yoshihiro Shimoda


>  drivers/net/ethernet/renesas/rswitch.c | 79 ++++++++++++++++----------
>  drivers/net/ethernet/renesas/rswitch.h | 17 ++++--
>  2 files changed, 60 insertions(+), 36 deletions(-)
> 
> --
> 2.39.5

Paolo Abeni Dec. 12, 2024, 8:08 a.m. UTC | #2

On 12/8/24 16:52, Nikita Yushchenko wrote:
> This series cleans up rswitch mdio support, and adds C22 operations.
> 
> Nikita Yushchenko (4):
>   net: renesas: rswitch: do not write to MPSM register at init time
>   net: renesas: rswitch: align mdio C45 operations with datasheet
>   net: renesas: rswitch: use generic MPSM operation for mdio C45
>   net: renesas: rswitch: add mdio C22 support
> 
>  drivers/net/ethernet/renesas/rswitch.c | 79 ++++++++++++++++----------
>  drivers/net/ethernet/renesas/rswitch.h | 17 ++++--
>  2 files changed, 60 insertions(+), 36 deletions(-)

@Yoshihiro, could you please have a look here?

Thanks,

Paolo

Yoshihiro Shimoda Dec. 12, 2024, 8:21 a.m. UTC | #3

Hello Paolo,

> From: Paolo Abeni, Sent: Thursday, December 12, 2024 5:08 PM
> 
> On 12/8/24 16:52, Nikita Yushchenko wrote:
> > This series cleans up rswitch mdio support, and adds C22 operations.
> >
> > Nikita Yushchenko (4):
> >   net: renesas: rswitch: do not write to MPSM register at init time
> >   net: renesas: rswitch: align mdio C45 operations with datasheet
> >   net: renesas: rswitch: use generic MPSM operation for mdio C45
> >   net: renesas: rswitch: add mdio C22 support
> >
> >  drivers/net/ethernet/renesas/rswitch.c | 79 ++++++++++++++++----------
> >  drivers/net/ethernet/renesas/rswitch.h | 17 ++++--
> >  2 files changed, 60 insertions(+), 36 deletions(-)
> 
> @Yoshihiro, could you please have a look here?

I have already reviewed and tested these patches, and sent an email as following:

https://lore.kernel.org/all/[e-mail]/

Best regards,
Yoshihiro Shimoda


> Thanks,
> 
> Paolo

Jakub Kicinski Dec. 15, 2024, 10:38 p.m. UTC | #4

On Sun,  8 Dec 2024 20:52:32 +0500 Nikita Yushchenko wrote:
> This series cleans up rswitch mdio support, and adds C22 operations.

This series doesn't apply any more, please rebase / repost.