| Message ID | 20241217-rcar-gh-dsi-v5-0-e77421093c05@ideasonboard.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | drm: Add DSI/DP support for Renesas r8a779h0 V4M and grey-hawk board | expand |
Hi all, On 17/12/2024 07:31, Tomi Valkeinen wrote: > Add everything needed to support the DSI output on Renesas r8a779h0 > (V4M) SoC, and the DP output (via sn65dsi86 DSI to DP bridge) on the > Renesas grey-hawk board. > > Overall the DSI and the board design is almost identical to Renesas > r8a779g0 and white-hawk board. > > Note: the v4 no longer has the dts and the clk patches, as those have > been merged to renesas-devel. > I have pushed this to drm-misc-next. Thank you all for the reviews! Tomi
On 17/12/2024 14:33, Tomi Valkeinen wrote: > Hi all, > > On 17/12/2024 07:31, Tomi Valkeinen wrote: >> Add everything needed to support the DSI output on Renesas r8a779h0 >> (V4M) SoC, and the DP output (via sn65dsi86 DSI to DP bridge) on the >> Renesas grey-hawk board. >> >> Overall the DSI and the board design is almost identical to Renesas >> r8a779g0 and white-hawk board. >> >> Note: the v4 no longer has the dts and the clk patches, as those have >> been merged to renesas-devel. >> > > I have pushed this to drm-misc-next. Thank you all for the reviews! I am confused how this is supposed to work. You merged your own patches for Renesas DRM, even not being the Renesas DRM maintainer, while my much earlier patchset was "only" reviewed by Renesas DRM maintainers but not picked up by them. So maybe you are the Renesas DRM maintainer? But get_maintainers.pl is silent on that, so I don't Cc you. Can you guys clarify that so maintainers file reflect reality? Best regards, Krzysztof
Hi, On 28/01/2025 12:09, Krzysztof Kozlowski wrote: > On 17/12/2024 14:33, Tomi Valkeinen wrote: >> Hi all, >> >> On 17/12/2024 07:31, Tomi Valkeinen wrote: >>> Add everything needed to support the DSI output on Renesas r8a779h0 >>> (V4M) SoC, and the DP output (via sn65dsi86 DSI to DP bridge) on the >>> Renesas grey-hawk board. >>> >>> Overall the DSI and the board design is almost identical to Renesas >>> r8a779g0 and white-hawk board. >>> >>> Note: the v4 no longer has the dts and the clk patches, as those have >>> been merged to renesas-devel. >>> >> >> I have pushed this to drm-misc-next. Thank you all for the reviews! > I am confused how this is supposed to work. You merged your own patches > for Renesas DRM, even not being the Renesas DRM maintainer, while my > much earlier patchset was "only" reviewed by Renesas DRM maintainers but > not picked up by them. > > So maybe you are the Renesas DRM maintainer? But get_maintainers.pl is > silent on that, so I don't Cc you. > > Can you guys clarify that so maintainers file reflect reality? Yep, that's not right. Laurent has been requesting me to merge rcar-du patches via drm-misc for a while now, so in practice I have been a maintainer. But the maintainers file has not been updated. I'll do that now. Sorry about the confusion. Tomi
On 28/01/2025 11:26, Tomi Valkeinen wrote: >> >> So maybe you are the Renesas DRM maintainer? But get_maintainers.pl is >> silent on that, so I don't Cc you. >> >> Can you guys clarify that so maintainers file reflect reality? > > Yep, that's not right. Laurent has been requesting me to merge rcar-du > patches via drm-misc for a while now, so in practice I have been a > maintainer. But the maintainers file has not been updated. I'll do that now. Thanks. Best regards, Krzysztof
Add everything needed to support the DSI output on Renesas r8a779h0 (V4M) SoC, and the DP output (via sn65dsi86 DSI to DP bridge) on the Renesas grey-hawk board. Overall the DSI and the board design is almost identical to Renesas r8a779g0 and white-hawk board. Note: the v4 no longer has the dts and the clk patches, as those have been merged to renesas-devel. Signed-off-by: Tomi Valkeinen <tomi.valkeinen+renesas@ideasonboard.com> --- Changes in v5: - Add minItems/maxItems to the top level cmms & vsps properties - Drop "minItems: 1" when not needed - Link to v4: https://lore.kernel.org/r/20241213-rcar-gh-dsi-v4-0-f8e41425207b@ideasonboard.com Changes in v4: - Dropped patches merged to renesas-devel - Added new patch "dt-bindings: display: renesas,du: Add missing maxItems" to fix the bindings - Add the missing maxItems to "dt-bindings: display: renesas,du: Add r8a779h0" - Link to v3: https://lore.kernel.org/r/20241206-rcar-gh-dsi-v3-0-d74c2166fa15@ideasonboard.com Changes in v3: - Update "Write DPTSR only if there are more than one crtc" patch to "Write DPTSR only if the second source exists" - Add Laurent's Rb - Link to v2: https://lore.kernel.org/r/20241205-rcar-gh-dsi-v2-0-42471851df86@ideasonboard.com Changes in v2: - Add the DT binding with a new conditional block, so that we can set only the port@0 as required - Drop port@1 from r8a779h0.dtsi (there's no port@1) - Add a new patch to write DPTSR only if num_crtcs > 1 - Drop RCAR_DU_FEATURE_NO_DPTSR (not needed anymore) - Add Cc: stable to the fix, and move it as first patch - Added the tags from reviews - Link to v1: https://lore.kernel.org/r/20241203-rcar-gh-dsi-v1-0-738ae1a95d2a@ideasonboard.com --- Tomi Valkeinen (7): drm/rcar-du: dsi: Fix PHY lock bit check drm/rcar-du: Write DPTSR only if the second source exists dt-bindings: display: renesas,du: Add missing constraints dt-bindings: display: renesas,du: Add r8a779h0 dt-bindings: display: bridge: renesas,dsi-csi2-tx: Add r8a779h0 drm/rcar-du: dsi: Add r8a779h0 support drm/rcar-du: Add support for r8a779h0 .../display/bridge/renesas,dsi-csi2-tx.yaml | 1 + .../devicetree/bindings/display/renesas,du.yaml | 67 ++++++++++++++++++++-- drivers/gpu/drm/renesas/rcar-du/rcar_du_drv.c | 18 ++++++ drivers/gpu/drm/renesas/rcar-du/rcar_du_group.c | 24 ++++++-- drivers/gpu/drm/renesas/rcar-du/rcar_mipi_dsi.c | 4 +- .../gpu/drm/renesas/rcar-du/rcar_mipi_dsi_regs.h | 1 - 6 files changed, 102 insertions(+), 13 deletions(-) --- base-commit: adc218676eef25575469234709c2d87185ca223a change-id: 20241008-rcar-gh-dsi-9c01f5deeac8 Best regards,