| Message ID | 20250318205735.122590-1-prabhakar.mahadev-lad.rj@bp.renesas.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | Add GBETH glue layer driver for Renesas RZ/V2H(P) SoC | expand |
Hi Paolo and Jakub On Tue, Mar 18, 2025 at 8:57 PM Prabhakar <prabhakar.csengg@gmail.com> wrote: > > From: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com> > > Hi All, > > This patch series adds support for the GBETH (Gigabit Ethernet) interface > on the Renesas RZ/V2H(P) SoC. The changes include updating the device tree > bindings, documenting the GBETH bindings, and adding the DWMAC glue layer > for the Renesas GBETH. > > Note, this patch series depends on [0]. > > [0] https://lore.kernel.org/all/Z82tWYZulV12Pjir@shell.armlinux.org.uk/ > This patch series has been marked as "Changes Requested" on Patchwork, but there were no review comments on the series. If the status was marked as "Changes Requested" due to build failures reported by the kernel bots, I’d like to clarify that the failure was caused by a patch dependency, which has now been merged into net-next [0]. As a result, this series should now build successfully on net-next. Please let me know if you would like me to resend the series. [0] https://web.git.kernel.org/pub/scm/linux/kernel/git/netdev/net-next.git/commit/?id=0c1f1eb65425 Cheers, Prabhakar
On Wed, 26 Mar 2025 12:52:17 +0000 Lad, Prabhakar wrote: > This patch series has been marked as "Changes Requested" on Patchwork, > but there were no review comments on the series. If the status was > marked as "Changes Requested" due to build failures reported by the > kernel bots, I’d like to clarify that the failure was caused by a > patch dependency, which has now been merged into net-next [0]. As a > result, this series should now build successfully on net-next. > > Please let me know if you would like me to resend the series. Don't send patches which can't be immediately merged. You will have to repost, obviously, and after the merge window.
On Wed, Mar 26, 2025 at 06:21:48AM -0700, Jakub Kicinski wrote: > On Wed, 26 Mar 2025 12:52:17 +0000 Lad, Prabhakar wrote: > > This patch series has been marked as "Changes Requested" on Patchwork, > > but there were no review comments on the series. If the status was > > marked as "Changes Requested" due to build failures reported by the > > kernel bots, I’d like to clarify that the failure was caused by a > > patch dependency, which has now been merged into net-next [0]. As a > > result, this series should now build successfully on net-next. > > > > Please let me know if you would like me to resend the series. > > Don't send patches which can't be immediately merged. > You will have to repost, obviously, and after the merge window. Just expanding on that a bit. We do more than build testing of patches. Some runtime testing is also performed. So if they failed to build, they cannot be fully tested. Hence the request to only post patches which build. You can however send the patches as RFC, so we know to ignore them for merging. Andrew
Hi Andrew and Jakub, On Wed, Mar 26, 2025 at 1:29 PM Andrew Lunn <andrew@lunn.ch> wrote: > > On Wed, Mar 26, 2025 at 06:21:48AM -0700, Jakub Kicinski wrote: > > On Wed, 26 Mar 2025 12:52:17 +0000 Lad, Prabhakar wrote: > > > This patch series has been marked as "Changes Requested" on Patchwork, > > > but there were no review comments on the series. If the status was > > > marked as "Changes Requested" due to build failures reported by the > > > kernel bots, I’d like to clarify that the failure was caused by a > > > patch dependency, which has now been merged into net-next [0]. As a > > > result, this series should now build successfully on net-next. > > > > > > Please let me know if you would like me to resend the series. > > > > Don't send patches which can't be immediately merged. > > You will have to repost, obviously, and after the merge window. > Thanks, I'll resend the patches after the merge window. > Just expanding on that a bit. We do more than build testing of > patches. Some runtime testing is also performed. So if they failed to > build, they cannot be fully tested. Hence the request to only post > patches which build. > Thanks for the clarification. > You can however send the patches as RFC, so we know to ignore them for > merging. > I'll make sure to send such patches as RFC in the future to indicate that they are not ready for merging. Thanks for the clarification! Cheers, Prabhakar
From: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com> Hi All, This patch series adds support for the GBETH (Gigabit Ethernet) interface on the Renesas RZ/V2H(P) SoC. The changes include updating the device tree bindings, documenting the GBETH bindings, and adding the DWMAC glue layer for the Renesas GBETH. Note, this patch series depends on [0]. [0] https://lore.kernel.org/all/Z82tWYZulV12Pjir@shell.armlinux.org.uk/ v3->v4 - Fixed maxItems for interrupt-names property - Maintained reverse christmas tree order in renesas_gbeth_clks_config - Returned err in case of success in renesas_gbeth_probe() v2->v3 - Fixed review comments from Rob and Russell v1->v2 - Updated commit description for patch 2/3 - Updated tx/rx queue completion interrupt names - Added clks_config callback v1: https://lore.kernel.org/all/20250302181808.728734-1-prabhakar.mahadev-lad.rj@bp.renesas.com/ Cheers, Prabhakar Lad Prabhakar (3): dt-bindings: net: dwmac: Increase 'maxItems' for 'interrupts' and 'interrupt-names' dt-bindings: net: Document support for Renesas RZ/V2H(P) GBETH net: stmmac: Add DWMAC glue layer for Renesas GBETH .../bindings/net/renesas,r9a09g057-gbeth.yaml | 201 ++++++++++++++++++ .../devicetree/bindings/net/snps,dwmac.yaml | 25 ++- drivers/net/ethernet/stmicro/stmmac/Kconfig | 11 + drivers/net/ethernet/stmicro/stmmac/Makefile | 1 + .../stmicro/stmmac/dwmac-renesas-gbeth.c | 165 ++++++++++++++ 5 files changed, 394 insertions(+), 9 deletions(-) create mode 100644 Documentation/devicetree/bindings/net/renesas,r9a09g057-gbeth.yaml create mode 100644 drivers/net/ethernet/stmicro/stmmac/dwmac-renesas-gbeth.c