mbox series

[0/3] ARM: dts: renesas: Add more TMU support

Message ID cover.1710864964.git.geert+renesas@glider.be (mailing list archive)
Headers show
Series ARM: dts: renesas: Add more TMU support | expand

Message

Geert Uytterhoeven March 19, 2024, 4:29 p.m. UTC
Hi all,

This patch series adds device nodes for the Timer Units (TMU) on the
R-Mobile APE6 SoC, and on various SoCs from the RZ/G1 and R-Car Gen2
family.

All TMU instances have been tested successfully using [1] on R-Mobile
APE6 (APE6EVM), and on R-Car H2 (Lager) and M2-W (Koelsch), except for
TMU3 on M2-W, which consistently fails the CLOCK_REALTIME test (why?).

Still to be queued in renesas-devel for v6.10?

Thanks for your comments!

[1] https://elinux.org/R-Car/Tests:timers

Geert Uytterhoeven (3):
  ARM: dts: renesas: r8a73a4: Add TMU nodes
  ARM: dts: renesas: rzg1: Add TMU nodes
  ARM: dts: renesas: rcar-gen2: Add TMU nodes

 arch/arm/boot/dts/renesas/r8a73a4.dtsi    | 37 ++++++++++++++
 arch/arm/boot/dts/renesas/r8a7742.dtsi    | 58 ++++++++++++++++++++++
 arch/arm/boot/dts/renesas/r8a7743.dtsi    | 58 ++++++++++++++++++++++
 arch/arm/boot/dts/renesas/r8a7744.dtsi    | 58 ++++++++++++++++++++++
 arch/arm/boot/dts/renesas/r8a7745.dtsi    | 58 ++++++++++++++++++++++
 arch/arm/boot/dts/renesas/r8a77470.dtsi   | 44 +++++++++++++++++
 arch/arm/boot/dts/renesas/r8a7790.dtsi    | 58 ++++++++++++++++++++++
 arch/arm/boot/dts/renesas/r8a7791.dtsi    | 58 ++++++++++++++++++++++
 arch/arm/boot/dts/renesas/r8a7792.dtsi    | 59 +++++++++++++++++++++++
 arch/arm/boot/dts/renesas/r8a7793.dtsi    | 58 ++++++++++++++++++++++
 arch/arm/boot/dts/renesas/r8a7794.dtsi    | 58 ++++++++++++++++++++++
 include/dt-bindings/clock/r8a73a4-clock.h |  4 ++
 12 files changed, 608 insertions(+)

Comments

Wolfram Sang March 20, 2024, 7:08 a.m. UTC | #1
Hi Geert,

> APE6 (APE6EVM), and on R-Car H2 (Lager) and M2-W (Koelsch), except for
> TMU3 on M2-W, which consistently fails the CLOCK_REALTIME test (why?).

Huh? It works on Lager and fails on Koelsch? Do you have a log file?

> Still to be queued in renesas-devel for v6.10?

I'd say yes, it still describes the HW. Unless it turns out that M2-W
doesn't really have TMU3 ;)

Happy hacking,

   Wolfram
Geert Uytterhoeven March 20, 2024, 8:03 a.m. UTC | #2
Hi Wolfram,

On Wed, Mar 20, 2024 at 8:08 AM Wolfram Sang <wsa@kernel.org> wrote:
> > APE6 (APE6EVM), and on R-Car H2 (Lager) and M2-W (Koelsch), except for
> > TMU3 on M2-W, which consistently fails the CLOCK_REALTIME test (why?).
>
> Huh? It works on Lager and fails on Koelsch? Do you have a log file?

Of course it succeeded on the next try...

When it failed:

# Running Asynchronous Switching Tests...
TAP version 13
1..12
# Mon Mar 18 13:47:43 2024
[...]
# 1710766103:513532480
# 1710766103:513532480
# 1710766103:513532480
# --------------------
# 1710766103:513784560
# 1710766103:513784559
# --------------------
# 1710766103:513784559
# 1710766103:513784559
# 1710766103:513784559
[...]
# Delta: 1 ns
# Mon Mar 18 13:48:23 2024

not ok 1 CLOCK_REALTIE
# Planned tests != run tests (12 != 1)
# Totals: pass:0 fail:1 xfail:0 xpass:0 skip:0 error:0
TAP version 13
1..1
not ok 1 clocksource-switch
# Totals: pass:0 fail:1 xfail:0 xpass:0 skip:0 error:0

Perhaps a subtle driver issue, or an issue with the test?

Gr{oetje,eeting}s,

                        Geert
Wolfram Sang March 20, 2024, 8:34 a.m. UTC | #3
Hi Geert,

> > Huh? It works on Lager and fails on Koelsch? Do you have a log file?
> 
> Of course it succeeded on the next try...

Interesting. I will try Lager then and see if it fails there as well. It
is only TMU3, right?

> Perhaps a subtle driver issue, or an issue with the test?

My gut feeling says "the latter", but I have no real proof.

Happy hacking,

   Wolfram
Geert Uytterhoeven March 20, 2024, 10:09 a.m. UTC | #4
Hi Wolfram,

On Wed, Mar 20, 2024 at 9:34 AM Wolfram Sang <wsa@kernel.org> wrote:
> > > Huh? It works on Lager and fails on Koelsch? Do you have a log file?
> >
> > Of course it succeeded on the next try...
>
> Interesting. I will try Lager then and see if it fails there as well. It
> is only TMU3, right?

On Koelsch TMU3 is rather erratic.
On other SoCs, I did see a few sporadic test failures, even for
arch_sys_counter instead of TMUx.

Thanks!

Gr{oetje,eeting}s,

                        Geert
Geert Uytterhoeven March 21, 2024, 10:17 a.m. UTC | #5
On Tue, Mar 19, 2024 at 5:29 PM Geert Uytterhoeven
<geert+renesas@glider.be> wrote:
> This patch series adds device nodes for the Timer Units (TMU) on the
> R-Mobile APE6 SoC, and on various SoCs from the RZ/G1 and R-Car Gen2
> family.

In case you are wondering why I did not include SH-Mobile AG5: on that
SoC, the TMU interrupts are not wired to the interrupt controller for
the AP-System Core (INTCAx), only to the interrupt controller for the
AP-Realtime Core (INTCS).

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds