| Message ID | 1456885514-27466-1-git-send-email-horms+renesas@verge.net.au (mailing list archive) |
|---|---|
| State | Superseded |
| Delegated to: | Geert Uytterhoeven |
| Headers | show |
On Wed, Mar 2, 2016 at 3:25 AM, Simon Horman <horms+renesas@verge.net.au> wrote: > Make use of ARCH_RENESAS in place of ARCH_SHMOBILE. > > This is part of an ongoing process to migrate from ARCH_SHMOBILE to > ARCH_RENESAS the motivation for which being that RENESAS seems to be a more > appropriate name than SHMOBILE for the majority of Renesas ARM based SoCs. > > Signed-off-by: Simon Horman <horms+renesas@verge.net.au> Acked-by: Geert Uytterhoeven <geert+renesas@glider.be> > --- a/drivers/phy/Kconfig > +++ b/drivers/phy/Kconfig > @@ -113,14 +113,14 @@ config PHY_MIPHY365X > > config PHY_RCAR_GEN2 > tristate "Renesas R-Car generation 2 USB PHY driver" > - depends on ARCH_SHMOBILE > + depends on ARCH_RENESAS > depends on GENERIC_PHY > help > Support for USB PHY found on Renesas R-Car generation 2 SoCs. > > config PHY_RCAR_GEN3_USB2 > tristate "Renesas R-Car generation 3 USB 2.0 PHY driver" > - depends on OF && ARCH_SHMOBILE > + depends on OF && ARCH_RENESAS FWIW, you may want to drop the dependency on OF, as this is implied by ARCH_RENESAS. Or you can handle that when adding/testing COMPILE_TEST support ;-) > select GENERIC_PHY > help > Support for USB 2.0 PHY found on Renesas R-Car generation 3 SoCs. Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds
On Wed, Mar 02, 2016 at 10:36:33AM +0100, Geert Uytterhoeven wrote: > On Wed, Mar 2, 2016 at 3:25 AM, Simon Horman <horms+renesas@verge.net.au> wrote: > > Make use of ARCH_RENESAS in place of ARCH_SHMOBILE. > > > > This is part of an ongoing process to migrate from ARCH_SHMOBILE to > > ARCH_RENESAS the motivation for which being that RENESAS seems to be a more > > appropriate name than SHMOBILE for the majority of Renesas ARM based SoCs. > > > > Signed-off-by: Simon Horman <horms+renesas@verge.net.au> > > Acked-by: Geert Uytterhoeven <geert+renesas@glider.be> > > > --- a/drivers/phy/Kconfig > > +++ b/drivers/phy/Kconfig > > @@ -113,14 +113,14 @@ config PHY_MIPHY365X > > > > config PHY_RCAR_GEN2 > > tristate "Renesas R-Car generation 2 USB PHY driver" > > - depends on ARCH_SHMOBILE > > + depends on ARCH_RENESAS > > depends on GENERIC_PHY > > help > > Support for USB PHY found on Renesas R-Car generation 2 SoCs. > > > > config PHY_RCAR_GEN3_USB2 > > tristate "Renesas R-Car generation 3 USB 2.0 PHY driver" > > - depends on OF && ARCH_SHMOBILE > > + depends on OF && ARCH_RENESAS > > FWIW, you may want to drop the dependency on OF, as this is implied by > ARCH_RENESAS. > Or you can handle that when adding/testing COMPILE_TEST support ;-) So the ideal setup would be as follows? depends on ARCH_RENESAS || (OF && COMPILE_TEST) If so I think I would like to update this patch to: depends on ARCH_RENESAS And then deal with COMPILE_TEST separately: I should probably sweep the tree for Renesas related drivers that do have a COMPILE_TEST dependency. > > select GENERIC_PHY > > help > > Support for USB 2.0 PHY found on Renesas R-Car generation 3 SoCs. > > Gr{oetje,eeting}s, > > Geert > > -- > Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org > > In personal conversations with technical people, I call myself a hacker. But > when I'm talking to journalists I just say "programmer" or something like that. > -- Linus Torvalds
Hi Simon, On Thu, Mar 3, 2016 at 1:12 AM, Simon Horman <horms@verge.net.au> wrote: > On Wed, Mar 02, 2016 at 10:36:33AM +0100, Geert Uytterhoeven wrote: >> On Wed, Mar 2, 2016 at 3:25 AM, Simon Horman <horms+renesas@verge.net.au> wrote: >> > Make use of ARCH_RENESAS in place of ARCH_SHMOBILE. >> > >> > This is part of an ongoing process to migrate from ARCH_SHMOBILE to >> > ARCH_RENESAS the motivation for which being that RENESAS seems to be a more >> > appropriate name than SHMOBILE for the majority of Renesas ARM based SoCs. >> > >> > Signed-off-by: Simon Horman <horms+renesas@verge.net.au> >> >> Acked-by: Geert Uytterhoeven <geert+renesas@glider.be> >> >> > --- a/drivers/phy/Kconfig >> > +++ b/drivers/phy/Kconfig >> > @@ -113,14 +113,14 @@ config PHY_MIPHY365X >> > >> > config PHY_RCAR_GEN2 >> > tristate "Renesas R-Car generation 2 USB PHY driver" >> > - depends on ARCH_SHMOBILE >> > + depends on ARCH_RENESAS >> > depends on GENERIC_PHY >> > help >> > Support for USB PHY found on Renesas R-Car generation 2 SoCs. >> > >> > config PHY_RCAR_GEN3_USB2 >> > tristate "Renesas R-Car generation 3 USB 2.0 PHY driver" >> > - depends on OF && ARCH_SHMOBILE >> > + depends on OF && ARCH_RENESAS >> >> FWIW, you may want to drop the dependency on OF, as this is implied by >> ARCH_RENESAS. >> Or you can handle that when adding/testing COMPILE_TEST support ;-) > > So the ideal setup would be as follows? > > depends on ARCH_RENESAS || (OF && COMPILE_TEST) I would separate it in two lines: one for hard, and one for soft dependencies: depends on OF depends on ARCH_RENESAS || COMPILE_TEST > If so I think I would like to update this patch to: > > depends on ARCH_RENESAS Fine for me. > And then deal with COMPILE_TEST separately: I should probably > sweep the tree for Renesas related drivers that do have a COMPILE_TEST > dependency. OK. Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds
Hi Simon-san, > Sent: Wednesday, March 02, 2016 6:37 PM > > On Wed, Mar 2, 2016 at 3:25 AM, Simon Horman <horms+renesas@verge.net.au> wrote: > > Make use of ARCH_RENESAS in place of ARCH_SHMOBILE. > > > > This is part of an ongoing process to migrate from ARCH_SHMOBILE to > > ARCH_RENESAS the motivation for which being that RENESAS seems to be a more > > appropriate name than SHMOBILE for the majority of Renesas ARM based SoCs. > > > > Signed-off-by: Simon Horman <horms+renesas@verge.net.au> > > Acked-by: Geert Uytterhoeven <geert+renesas@glider.be> Acked-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com> Best regards, Yoshihiro Shimoda
diff --git a/drivers/phy/Kconfig b/drivers/phy/Kconfig index e7e117d5dbbe..e097ed2dfad9 100644 --- a/drivers/phy/Kconfig +++ b/drivers/phy/Kconfig @@ -113,14 +113,14 @@ config PHY_MIPHY365X config PHY_RCAR_GEN2 tristate "Renesas R-Car generation 2 USB PHY driver" - depends on ARCH_SHMOBILE + depends on ARCH_RENESAS depends on GENERIC_PHY help Support for USB PHY found on Renesas R-Car generation 2 SoCs. config PHY_RCAR_GEN3_USB2 tristate "Renesas R-Car generation 3 USB 2.0 PHY driver" - depends on OF && ARCH_SHMOBILE + depends on OF && ARCH_RENESAS select GENERIC_PHY help Support for USB 2.0 PHY found on Renesas R-Car generation 3 SoCs.
Make use of ARCH_RENESAS in place of ARCH_SHMOBILE. This is part of an ongoing process to migrate from ARCH_SHMOBILE to ARCH_RENESAS the motivation for which being that RENESAS seems to be a more appropriate name than SHMOBILE for the majority of Renesas ARM based SoCs. Signed-off-by: Simon Horman <horms+renesas@verge.net.au> --- drivers/phy/Kconfig | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) Based on v4.5-rc1