| Message ID | 1457551122-21838-3-git-send-email-geert+renesas@glider.be (mailing list archive) |
|---|---|
| State | Changes Requested |
| Delegated to: | Simon Horman |
| Headers | show |
Hi Geert, Thank you for the patch. On Wednesday 09 March 2016 20:18:37 Geert Uytterhoeven wrote: > Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be> > --- > v3: > - New. > --- > include/dt-bindings/power/r8a7779-sysc.h | 25 +++++++++++++++++++++++++ > 1 file changed, 25 insertions(+) > create mode 100644 include/dt-bindings/power/r8a7779-sysc.h > > diff --git a/include/dt-bindings/power/r8a7779-sysc.h > b/include/dt-bindings/power/r8a7779-sysc.h new file mode 100644 > index 0000000000000000..6b66612d1260d396 > --- /dev/null > +++ b/include/dt-bindings/power/r8a7779-sysc.h > @@ -0,0 +1,25 @@ > +/* > + * Copyright (C) 2016 Glider bvba > + * > + * This program is free software; you can redistribute it and/or modify > + * it under the terms of the GNU General Public License as published by > + * the Free Software Foundation; version 2 of the License. > + */ > +#ifndef __DT_BINDINGS_POWER_R8A7779_SYSC_H__ > +#define __DT_BINDINGS_POWER_R8A7779_SYSC_H__ > + > +/* > + * These power domain indices match the numbers of the interrupt bits > + * representing the power areas in the various Interrupt Registers > + * (e.g. SYSCISR, Interrupt Status Register) > + */ > + > +#define R8A7779_PD_ARM1 1 > +#define R8A7779_PD_ARM2 2 > +#define R8A7779_PD_ARM3 3 > +#define R8A7779_PD_SH 16 I don't see this power domain in version 0.6 of the datasheet, you might have a more recent version than I do. Apart from that, Reveiwed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> > +#define R8A7779_PD_SGX 20 > +#define R8A7779_PD_VDP 21 > +#define R8A7779_PD_IMP 24 > + > +#endif /* __DT_BINDINGS_POWER_R8A7779_SYSC_H__ */
Hi Laurent, On Thu, Mar 10, 2016 at 3:40 AM, Laurent Pinchart <laurent.pinchart@ideasonboard.com> wrote: > On Wednesday 09 March 2016 20:18:37 Geert Uytterhoeven wrote: >> --- /dev/null >> +++ b/include/dt-bindings/power/r8a7779-sysc.h >> +#define R8A7779_PD_SH 16 > > I don't see this power domain in version 0.6 of the datasheet, you might have > a more recent version than I do. It's indeed not in the datasheet. I based it's presence on the value written to SYSCIER, which has bit 16 set, both in upstream and in the BSP. Perhaps Magnus knows, as he's the author of that code? Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds
diff --git a/include/dt-bindings/power/r8a7779-sysc.h b/include/dt-bindings/power/r8a7779-sysc.h new file mode 100644 index 0000000000000000..6b66612d1260d396 --- /dev/null +++ b/include/dt-bindings/power/r8a7779-sysc.h @@ -0,0 +1,25 @@ +/* + * Copyright (C) 2016 Glider bvba + * + * This program is free software; you can redistribute it and/or modify + * it under the terms of the GNU General Public License as published by + * the Free Software Foundation; version 2 of the License. + */ +#ifndef __DT_BINDINGS_POWER_R8A7779_SYSC_H__ +#define __DT_BINDINGS_POWER_R8A7779_SYSC_H__ + +/* + * These power domain indices match the numbers of the interrupt bits + * representing the power areas in the various Interrupt Registers + * (e.g. SYSCISR, Interrupt Status Register) + */ + +#define R8A7779_PD_ARM1 1 +#define R8A7779_PD_ARM2 2 +#define R8A7779_PD_ARM3 3 +#define R8A7779_PD_SH 16 +#define R8A7779_PD_SGX 20 +#define R8A7779_PD_VDP 21 +#define R8A7779_PD_IMP 24 + +#endif /* __DT_BINDINGS_POWER_R8A7779_SYSC_H__ */
Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be> --- v3: - New. --- include/dt-bindings/power/r8a7779-sysc.h | 25 +++++++++++++++++++++++++ 1 file changed, 25 insertions(+) create mode 100644 include/dt-bindings/power/r8a7779-sysc.h