| Message ID | 1457551122-21838-4-git-send-email-geert+renesas@glider.be (mailing list archive) |
|---|---|
| State | Changes Requested |
| Delegated to: | Simon Horman |
| Headers | show |
Hi Geert, Thank you for the patch. On Wednesday 09 March 2016 20:18:38 Geert Uytterhoeven wrote: > Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be> > --- > v3: > - New. > --- > include/dt-bindings/power/r8a7790-sysc.h | 31 +++++++++++++++++++++++++++++ > 1 file changed, 31 insertions(+) > create mode 100644 include/dt-bindings/power/r8a7790-sysc.h > > diff --git a/include/dt-bindings/power/r8a7790-sysc.h > b/include/dt-bindings/power/r8a7790-sysc.h new file mode 100644 > index 0000000000000000..8ff5b86c12a46e85 > --- /dev/null > +++ b/include/dt-bindings/power/r8a7790-sysc.h > @@ -0,0 +1,31 @@ > +/* > + * Copyright (C) 2016 Glider bvba > + * > + * This program is free software; you can redistribute it and/or modify > + * it under the terms of the GNU General Public License as published by > + * the Free Software Foundation; version 2 of the License. > + */ > +#ifndef __DT_BINDINGS_POWER_R8A7790_SYSC_H__ > +#define __DT_BINDINGS_POWER_R8A7790_SYSC_H__ > + > +/* > + * These power domain indices match the numbers of the interrupt bits > + * representing the power areas in the various Interrupt Registers > + * (e.g. SYSCISR, Interrupt Status Register) > + */ > + > +#define R8A7790_PD_CA15_CPU0 0 > +#define R8A7790_PD_CA15_CPU1 1 > +#define R8A7790_PD_CA15_CPU2 2 > +#define R8A7790_PD_CA15_CPU3 3 > +#define R8A7790_PD_CA7_CPU0 5 > +#define R8A7790_PD_CA7_CPU1 6 > +#define R8A7790_PD_CA7_CPU2 7 > +#define R8A7790_PD_CA7_CPU3 8 > +#define R8A7790_PD_CA15_SCU 12 > +#define R8A7790_PD_SH 16 The power domain is called SH-4A in the datasheet, how about naming it R8A7790_PD_SH_4A ? Apart from that, Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> > +#define R8A7790_PD_RGX 20 > +#define R8A7790_PD_CA7_SCU 21 > +#define R8A7790_PD_IMP 24 > + > +#endif /* __DT_BINDINGS_POWER_R8A7790_SYSC_H__ */
Hi Laurent, On Thu, Mar 10, 2016 at 7:57 AM, Laurent Pinchart <laurent.pinchart@ideasonboard.com> wrote: >> --- /dev/null >> +++ b/include/dt-bindings/power/r8a7790-sysc.h >> @@ -0,0 +1,31 @@ >> +#define R8A7790_PD_SH 16 > > The power domain is called SH-4A in the datasheet, how about naming it > R8A7790_PD_SH_4A ? Thanks, wlll update (for all SoCs). > Apart from that, > > Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> > >> +#define R8A7790_PD_RGX 20 >> +#define R8A7790_PD_CA7_SCU 21 >> +#define R8A7790_PD_IMP 24 Then this has to become R8A7790_PD_IMP_X4. Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds
On Thu, Mar 10, 2016 at 9:26 AM, Geert Uytterhoeven <geert@linux-m68k.org> wrote: >>> +#define R8A7790_PD_IMP 24 > > Then this has to become R8A7790_PD_IMP_X4. Actually this bit is called IMP, so I'll keep it. Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds
diff --git a/include/dt-bindings/power/r8a7790-sysc.h b/include/dt-bindings/power/r8a7790-sysc.h new file mode 100644 index 0000000000000000..8ff5b86c12a46e85 --- /dev/null +++ b/include/dt-bindings/power/r8a7790-sysc.h @@ -0,0 +1,31 @@ +/* + * Copyright (C) 2016 Glider bvba + * + * This program is free software; you can redistribute it and/or modify + * it under the terms of the GNU General Public License as published by + * the Free Software Foundation; version 2 of the License. + */ +#ifndef __DT_BINDINGS_POWER_R8A7790_SYSC_H__ +#define __DT_BINDINGS_POWER_R8A7790_SYSC_H__ + +/* + * These power domain indices match the numbers of the interrupt bits + * representing the power areas in the various Interrupt Registers + * (e.g. SYSCISR, Interrupt Status Register) + */ + +#define R8A7790_PD_CA15_CPU0 0 +#define R8A7790_PD_CA15_CPU1 1 +#define R8A7790_PD_CA15_CPU2 2 +#define R8A7790_PD_CA15_CPU3 3 +#define R8A7790_PD_CA7_CPU0 5 +#define R8A7790_PD_CA7_CPU1 6 +#define R8A7790_PD_CA7_CPU2 7 +#define R8A7790_PD_CA7_CPU3 8 +#define R8A7790_PD_CA15_SCU 12 +#define R8A7790_PD_SH 16 +#define R8A7790_PD_RGX 20 +#define R8A7790_PD_CA7_SCU 21 +#define R8A7790_PD_IMP 24 + +#endif /* __DT_BINDINGS_POWER_R8A7790_SYSC_H__ */
Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be> --- v3: - New. --- include/dt-bindings/power/r8a7790-sysc.h | 31 +++++++++++++++++++++++++++++++ 1 file changed, 31 insertions(+) create mode 100644 include/dt-bindings/power/r8a7790-sysc.h