From patchwork Thu Mar 10 02:30:15 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Yoshihiro Shimoda X-Patchwork-Id: 8553021 X-Patchwork-Delegate: geert@linux-m68k.org Return-Path: X-Original-To: patchwork-linux-renesas-soc@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork1.web.kernel.org (Postfix) with ESMTP id 4321B9F38C for ; Thu, 10 Mar 2016 02:30:47 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id A3B57202BE for ; Thu, 10 Mar 2016 02:30:46 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id E798120295 for ; Thu, 10 Mar 2016 02:30:45 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S964895AbcCJCap (ORCPT ); Wed, 9 Mar 2016 21:30:45 -0500 Received: from relmlor4.renesas.com ([210.160.252.174]:18289 "EHLO relmlie3.idc.renesas.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S964802AbcCJCan (ORCPT ); Wed, 9 Mar 2016 21:30:43 -0500 Received: from unknown (HELO relmlir2.idc.renesas.com) ([10.200.68.152]) by relmlie3.idc.renesas.com with ESMTP; 10 Mar 2016 11:30:40 +0900 Received: from relmlac3.idc.renesas.com (relmlac3.idc.renesas.com [10.200.69.23]) by relmlir2.idc.renesas.com (Postfix) with ESMTP id C90974CB80; Thu, 10 Mar 2016 11:30:40 +0900 (JST) Received: by relmlac3.idc.renesas.com (Postfix, from userid 0) id BB7ED1800A; Thu, 10 Mar 2016 11:30:40 +0900 (JST) Received: from relmlac3.idc.renesas.com (localhost [127.0.0.1]) by relmlac3.idc.renesas.com (Postfix) with ESMTP id AF6F018070; Thu, 10 Mar 2016 11:30:40 +0900 (JST) Received: from relmlii1.idc.renesas.com [10.200.68.65] by relmlac3.idc.renesas.com with ESMTP id MAD23978; Thu, 10 Mar 2016 11:30:40 +0900 X-IronPort-AV: E=Sophos;i="5.22,559,1449500400"; d="scan'";a="206067562" Received: from mail-hk2apc01lp0207.outbound.protection.outlook.com (HELO APC01-HK2-obe.outbound.protection.outlook.com) ([65.55.88.207]) by relmlii1.idc.renesas.com with ESMTP/TLS/AES256-SHA; 10 Mar 2016 11:30:40 +0900 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=renesasgroup.onmicrosoft.com; s=selector1-renesasgroup-onmicrosoft-com; h=From:To:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=UDMNaw+GBGNFFCCjwMMO5cy0w5AZMmxgiDC9c+wI0Q4=; b=HA7izRc7E74/wkYuFYNCyDi/PlWJW69N0aALzRGwhrSBlwYjGfi4R46my2s6MV8zRwUxFPvTNvtZCSaJzKLfocl87CGkEC8bI5FzDNVm5EFJvDf+UFkDLOvFYJD58do+2GLN3/Falo+NER1bV6+u1cnoev3OZA3pTJ42qtbR28A= Authentication-Results: kernel.org; dkim=none (message not signed) header.d=none; kernel.org; dmarc=none action=none header.from=renesas.com; Received: from localhost (211.11.155.144) by SG2PR06MB0919.apcprd06.prod.outlook.com (10.162.204.152) with Microsoft SMTP Server (TLS) id 15.1.434.16; Thu, 10 Mar 2016 02:30:38 +0000 From: Yoshihiro Shimoda To: CC: , , , , Yoshihiro Shimoda Subject: [PATCH v2 2/2] usb: renesas_usbhs: disable TX IRQ before starting TX DMAC transfer Date: Thu, 10 Mar 2016 11:30:15 +0900 Message-ID: <1457577015-5364-3-git-send-email-yoshihiro.shimoda.uh@renesas.com> X-Mailer: git-send-email 1.9.4.msysgit.1 In-Reply-To: <1457577015-5364-1-git-send-email-yoshihiro.shimoda.uh@renesas.com> References: <1457577015-5364-1-git-send-email-yoshihiro.shimoda.uh@renesas.com> MIME-Version: 1.0 X-Originating-IP: [211.11.155.144] X-ClientProxiedBy: TY1PR0201CA0026.apcprd02.prod.outlook.com (25.164.90.164) To SG2PR06MB0919.apcprd06.prod.outlook.com (25.162.204.152) X-MS-Office365-Filtering-Correlation-Id: 0522ddb4-7ff3-416e-eaac-08d3488bf81f X-Microsoft-Exchange-Diagnostics: 1; SG2PR06MB0919; 2:wT85cuz3TioQ3y/8AoIiZo7AFpXAk03d5XHGbgDrEJf5Az45nGRsjEP04D2B9tVsjb84y+iRcvagokV23rEyCSe6qAS94UiQ6mVnq+lNonzdzZqu9LDMtqUm+jPC+pt1giE/3Qqezj26IRBi5cnV4NmurwwS74XIoQK8jXwm29La/KDO+IUdaXtXNHNArMD4; 3:6QrqwoRL6EkKbsqEksROuS2JKnFtkRKMhlwoUzlbNsUfk2bdH2LrfAkX82I/f9rHB2Jib5XyuXVoE7x0KFHrPzMJEGGtLoORBwYcf1JRjG1fAjQnJKzuiews+opwDHPL; 25:W47ot0+8rBlJaFijBljoZ9N9gzZsSwI621PauHgcCQP8NfqQidIgui/IndDIrc0ZItHwEaMaxzw41DGx5y9MhPEcb7Ucw3MQj70/2g7CJ9Rj4fL3soOlz0BtXtt2ql0gwmx/rcNxxLNcLyJk0hL25282HnkCpNs9L4vyxtDu29tKVdijQgdhSeNHg8LaLzbRHYANcumkCOizlc1tezA1p7Swi08dB+tRhqhqDNCweBvUCMnX8yvgBisraPKASUXxe+LwWK+rnOQCTOfn3qgBfmoVQHohqC8xom0GfIkXspbzIPM9vXtrtcy9Wj7cJ2I8hhTqJPoL3499a9GWyhgqSw== X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:SG2PR06MB0919; X-Microsoft-Exchange-Diagnostics: 1; SG2PR06MB0919; 20:APv3pMsdp/54HMvJ+5l6ZikWbebSmRPj12De+tobH1xbaL0Ix2WlY3+r34Lsmi0icVtfLayD7OQuOlko/928k9oFRawqNXUwdEQjV/tVN89qgUc67G5QbnqbxCvk4PZA+20M91AoR2UrC2KSwAt4KvtweLJGdMU1GcMvq+5s8BrruWOrqQVGqlY8UCGfa6qa2xUfNSwpFi0ZGr9WaqSOZJK6HilLAoWtDF2P86pedJGAzZQ8b3Dio5Kw1kJiNCTJjwEfWnuwow+uBdKOe+k/IlGm/0DOkePM/VoiFlF0xTzBomHpgcItgG/TjzSBxz1XsjhniIr35AuwtLD50oIHxy965z+sRRpjWqaA9KizAaI9LtCx0pmx8VZB7skd5xXaKofH3chv6nN/WidQT/SZXccVOYUaxC3bdfYS3p1ffhmC/Y8hFlkXbFsG7+qfFFZXD/pBgbV6l8IMdMgLYefKbdFtizOah8ygDf0qLk5ZkKzR87lAEf6Vu9fsCUNF+KRk; 4:62EPQgUJ4u6TPu00Od5qBbME4nPM8V3JTzEB4xQ6eFbTyziYQsqBYD6OoDhqXXuodyHB4b9GBiMKf3wmntiZWnKbX7ZxcfActiXa7mwWdqNLExis1fPXl7TN4tQ41LXmE4NTDyfSc2gi1ld7w/tBsDh6Dw8HE62G1ktEuVq4sd4Di2vqZLMdo8AhBSD/tIov1cG+0PlG85N7mDfZk7jj9y0oKdqXqySl/CrGPtz+Epd5yyciI3+B43OeW0ztwM66P+7OQ9sTI90l3CksdSuwYAOK0avI7MrqLBN9jKM5eEIJR1l30PrR17IpcyYmbvW4++1zRUnjErk+PsiEo3teYecAdZbsjp2U3oxYqrJEVAbELADC3L1iDNyU98Z+2nsC X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(601004)(2401047)(8121501046)(5005006)(10201501046)(3002001); SRVR:SG2PR06MB0919; BCL:0; PCL:0; RULEID:; SRVR:SG2PR06MB0919; X-Forefront-PRVS: 08770259B4 X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10019020)(4630300001)(6009001)(4326007)(229853001)(19580405001)(48376002)(81166005)(586003)(5004730100002)(92566002)(5003940100001)(78352003)(19580395003)(2351001)(50986999)(110136002)(107886002)(3846002)(1096002)(189998001)(76176999)(6116002)(2950100001)(36756003)(42382002)(42186005)(76506005)(4001430100002)(77096005)(2906002)(50226001)(50466002)(66066001)(47776003)(217423001)(5008740100001)(33646002); DIR:OUT; SFP:1102; SCL:1; SRVR:SG2PR06MB0919; H:localhost; FPR:; SPF:None; MLV:sfv; LANG:en; X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; SG2PR06MB0919; 23:eJyNfEP860Ge8b1hnptNRzlrTXUgnN8OSq7MhX4Je?= =?us-ascii?Q?zQWYNz/h1qtDqcNc6371JNg0UlhzgHaU0JexU/wRBB6uMLcSGEzaUT4/Zi6B?= =?us-ascii?Q?Cdb3SkYORqrrEQGBbUJyBvGAQtnFfBhWcesHmAMG29w59tg5OIk68nvQRmV1?= =?us-ascii?Q?zkshfF5tFAkdVlzR2+PAOog9RnL3oP0DDapEuh6psVMoJMM9UJznquN+l83o?= =?us-ascii?Q?aWN7lVuGZx3wc3awSrm6FjPcoQj6UdNyWl8EEEk/FntcmuS+DeHYA52xX94V?= =?us-ascii?Q?Z189hpaowSxoMc37UbFYbZoAmWjKUgzbkipL45iqcDUgQzOFRiTPcZiACQZx?= =?us-ascii?Q?88p1vL3y7eLeyi97qU6sM+U3YddeOcA6aC5Qn7QnecNtGQIX56r65xv9A7XE?= =?us-ascii?Q?NLHLZA7CCNFv/Ff47WjPbiMTlxgluRwEaxNC3Eod0iDiFrChEWjMBr7Lv0Gt?= =?us-ascii?Q?NQNxNZT8wawX15DVBq7VXhUZSJkSiQZzOq24KahtkEY/jKEMTK6GeGEl1ayG?= =?us-ascii?Q?o112LY4CaYad0aF/j+owL4k2sn1YX5/vUtMwxZuDagVG9aGBa2iVml2Q97Ye?= =?us-ascii?Q?N2juPfJ3b/BvO4iI6ZyGZVOPNG9fQvuYjOtQTRDoPZcv0PLiDoC4BmAbRc/j?= =?us-ascii?Q?mkb9stIW7mAqXN9g6jvuRDz/X2uq8yYfKQDGaamZ+A8Ay8syJtu7zgrZHXl6?= =?us-ascii?Q?MpT5nDbdNgurXvVSgYnoLxeXpuHhD7PwPiWA5iKBjPnPcBPTkuRSfiY+m9rN?= =?us-ascii?Q?HP27aSz5885FQnuM1u2Rj9iYAxYWzFTlhYc3cN9JxxKuAx0WvDHKBZtn2XSM?= =?us-ascii?Q?YQPJR41SgOPPO0ec2jZP6ytdvZaz7imYKwla06ioe0iRrzfWoidN4MqkPcSC?= =?us-ascii?Q?TaQv+9RfvoOUWv4/4n8D+gsYZf2CmQoTH1NYG1D4boECdE02JYsn3vfIswDf?= =?us-ascii?Q?WAtPWkPXROAUXEDGffVldddE9lSnJEgsYHyuqV0TRCWbjuDdI9m42po2s2hH?= =?us-ascii?Q?vrkwJ0ahEETeciq97HGH81R?= X-Microsoft-Exchange-Diagnostics: 1; SG2PR06MB0919; 5:1RaKxwHfgEsRzOwV65W3KWnuSLoeu8ffHP6IOdqHyPL53HHtCwQKCmUlcx8kiVQVdZ5VlEuR2XROjZQSnIGtu8sXFb5iUov3U3tqMsaunHQ8LsJdqGPcv8DmBFiVcMPgjxzWcPyn7v1ti7PJMPkpxQ==; 24:kIMdfInMRyDJhVG1lUOOPHnJc7NuH8piCKcYkVMimzyJIZ+66SauqinQdXKBqDyaNERMlRuvoMl4RSC0B3U8xoI/m/7KSjXC/+2R3RnYcYA=; 20:b8tS8kDczm8ynwTm8JXAXQukbzYhtSPeMbflF0198Yqwi4WpUBQEx8kdtfakfUZV05NDtqe30D2RnFZant9XgO14V9wDUV1GjC/pX9A02U/D/ccVx5CMp7VjfE6YHOHQTCLFuc7EVXiWEaJ9gdKs1GQI4Z6ox6PBF+C1og8+Aco= SpamDiagnosticOutput: 1:23 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: renesas.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Mar 2016 02:30:38.6742 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: SG2PR06MB0919 Sender: linux-renesas-soc-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-renesas-soc@vger.kernel.org X-Spam-Status: No, score=-6.9 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,RCVD_IN_DNSWL_HI,RP_MATCHES_RCVD,UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP This patch adds a code to surely disable TX IRQ of the pipe before starting TX DMAC transfer. Otherwise, a lot of unnecessary TX IRQs may happen in rare cases when DMAC is used. Fixes: e73a989 ("usb: renesas_usbhs: add DMAEngine support") Cc: # v3.1+ Signed-off-by: Yoshihiro Shimoda --- drivers/usb/renesas_usbhs/fifo.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/usb/renesas_usbhs/fifo.c b/drivers/usb/renesas_usbhs/fifo.c index 0c25c01..000f975 100644 --- a/drivers/usb/renesas_usbhs/fifo.c +++ b/drivers/usb/renesas_usbhs/fifo.c @@ -890,6 +890,7 @@ static int usbhsf_dma_prepare_push(struct usbhs_pkt *pkt, int *is_done) pkt->trans = len; + usbhsf_tx_irq_ctrl(pipe, 0); INIT_WORK(&pkt->work, xfer_work); schedule_work(&pkt->work);