diff mbox

[1/2] ARM: dts: r8a7793: Add SDHI controllers

Message ID 1458148297-22159-2-git-send-email-ulrich.hecht+renesas@gmail.com (mailing list archive)
State Changes Requested
Delegated to: Simon Horman
Headers show

Commit Message

Ulrich Hecht March 16, 2016, 5:11 p.m. UTC 
Same as on r8a7791.

Signed-off-by: Ulrich Hecht <ulrich.hecht+renesas@gmail.com>
---
 arch/arm/boot/dts/r8a7793.dtsi | 33 +++++++++++++++++++++++++++++++++
 1 file changed, 33 insertions(+)

Comments

Sergei Shtylyov March 16, 2016, 5:22 p.m. UTC | #1 
On 03/16/2016 08:11 PM, Ulrich Hecht wrote:

> Same as on r8a7791.
>
> Signed-off-by: Ulrich Hecht <ulrich.hecht+renesas@gmail.com>
> ---
>   arch/arm/boot/dts/r8a7793.dtsi | 33 +++++++++++++++++++++++++++++++++
>   1 file changed, 33 insertions(+)
>
> diff --git a/arch/arm/boot/dts/r8a7793.dtsi b/arch/arm/boot/dts/r8a7793.dtsi
> index b7f32d3..009ce38 100644
> --- a/arch/arm/boot/dts/r8a7793.dtsi
> +++ b/arch/arm/boot/dts/r8a7793.dtsi
> @@ -509,6 +509,39 @@
>   		reg = <0 0xe6060000 0 0x250>;
>   	};
>
> +	sdhi0: sd@ee100000 {
> +		compatible = "renesas,sdhi-r8a7793";
> +		reg = <0 0xee100000 0 0x328>;
> +		interrupts = <0 165 IRQ_TYPE_LEVEL_HIGH>;
> +		clocks = <&mstp3_clks R8A7793_CLK_SDHI0>;
> +		dmas = <&dmac0 0xcd>, <&dmac0 0xce>,
> +		       <&dmac1 0xcd>, <&dmac1 0xce>;
> +		dma-names = "tx", "rx";

    4 DMA channels but only 2 channel names?

[...]

MBR, Sergei
Simon Horman March 17, 2016, 1:23 a.m. UTC | #2 
On Wed, Mar 16, 2016 at 08:22:13PM +0300, Sergei Shtylyov wrote:
> On 03/16/2016 08:11 PM, Ulrich Hecht wrote:
> 
> >Same as on r8a7791.
> >
> >Signed-off-by: Ulrich Hecht <ulrich.hecht+renesas@gmail.com>
> >---
> >  arch/arm/boot/dts/r8a7793.dtsi | 33 +++++++++++++++++++++++++++++++++
> >  1 file changed, 33 insertions(+)
> >
> >diff --git a/arch/arm/boot/dts/r8a7793.dtsi b/arch/arm/boot/dts/r8a7793.dtsi
> >index b7f32d3..009ce38 100644
> >--- a/arch/arm/boot/dts/r8a7793.dtsi
> >+++ b/arch/arm/boot/dts/r8a7793.dtsi
> >@@ -509,6 +509,39 @@
> >  		reg = <0 0xe6060000 0 0x250>;
> >  	};
> >
> >+	sdhi0: sd@ee100000 {
> >+		compatible = "renesas,sdhi-r8a7793";
> >+		reg = <0 0xee100000 0 0x328>;
> >+		interrupts = <0 165 IRQ_TYPE_LEVEL_HIGH>;
> >+		clocks = <&mstp3_clks R8A7793_CLK_SDHI0>;
> >+		dmas = <&dmac0 0xcd>, <&dmac0 0xce>,
> >+		       <&dmac1 0xcd>, <&dmac1 0xce>;
> >+		dma-names = "tx", "rx";
> 
>    4 DMA channels but only 2 channel names?

It looks like that should be:

		dma-names = "tx", "rx", "tx", "rx";

It also looks like there should be:

		power-domains = <&cpg_clocks>;

Ulrich, could you verify the above and repost as necessary?
diff mbox

Patch

diff --git a/arch/arm/boot/dts/r8a7793.dtsi b/arch/arm/boot/dts/r8a7793.dtsi
index b7f32d3..009ce38 100644
--- a/arch/arm/boot/dts/r8a7793.dtsi
+++ b/arch/arm/boot/dts/r8a7793.dtsi
@@ -509,6 +509,39 @@ 
 		reg = <0 0xe6060000 0 0x250>;
 	};
 
+	sdhi0: sd@ee100000 {
+		compatible = "renesas,sdhi-r8a7793";
+		reg = <0 0xee100000 0 0x328>;
+		interrupts = <0 165 IRQ_TYPE_LEVEL_HIGH>;
+		clocks = <&mstp3_clks R8A7793_CLK_SDHI0>;
+		dmas = <&dmac0 0xcd>, <&dmac0 0xce>,
+		       <&dmac1 0xcd>, <&dmac1 0xce>;
+		dma-names = "tx", "rx";
+		status = "disabled";
+	};
+
+	sdhi1: sd@ee140000 {
+		compatible = "renesas,sdhi-r8a7793";
+		reg = <0 0xee140000 0 0x100>;
+		interrupts = <0 167 IRQ_TYPE_LEVEL_HIGH>;
+		clocks = <&mstp3_clks R8A7793_CLK_SDHI1>;
+		dmas = <&dmac0 0xc1>, <&dmac0 0xc2>,
+		       <&dmac1 0xc1>, <&dmac1 0xc2>;
+		dma-names = "tx", "rx";
+		status = "disabled";
+	};
+
+	sdhi2: sd@ee160000 {
+		compatible = "renesas,sdhi-r8a7793";
+		reg = <0 0xee160000 0 0x100>;
+		interrupts = <0 168 IRQ_TYPE_LEVEL_HIGH>;
+		clocks = <&mstp3_clks R8A7793_CLK_SDHI2>;
+		dmas = <&dmac0 0xd3>, <&dmac0 0xd4>,
+		       <&dmac1 0xd3>, <&dmac1 0xd4>;
+		dma-names = "tx", "rx";
+		status = "disabled";
+	};
+
 	mmcif0: mmcif@ee200000 {
 		compatible = "renesas,mmcif-r8a7793", "renesas,sh-mmcif";
 		reg = <0 0xee200000 0 0x80>;