| Message ID | 1458563320-30541-5-git-send-email-abrodkin@synopsys.com (mailing list archive) |
|---|---|
| State | Superseded |
| Delegated to: | Geert Uytterhoeven |
| Headers | show |
Hi Alexey, Thank you for the patch. On Monday 21 Mar 2016 15:28:40 Alexey Brodkin wrote: > Now when generic drm_connector_register_all() helper exists we may safely s/Now when/Now that a/ > substiture with it driver-specific implementation of connectors plugging in s/substiture with it/substitute it for the/ > sysfs. And while at it, in the subject line, s/rcar-du - use/rcar-du: Use/ > Signed-off-by: Alexey Brodkin <abrodkin@synopsys.com> > Cc: Daniel Vetter <daniel@ffwll.ch> > Cc: David Airlie <airlied@linux.ie> > Cc: Laurent Pinchart <laurent.pinchart@ideasonboard.com> > Cc: linux-renesas-soc@vger.kernel.org Apart for the commit message fixes, Acked-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> > --- > > No changes v1 -> v2. > > drivers/gpu/drm/rcar-du/rcar_du_drv.c | 9 +-------- > 1 file changed, 1 insertion(+), 8 deletions(-) > > diff --git a/drivers/gpu/drm/rcar-du/rcar_du_drv.c > b/drivers/gpu/drm/rcar-du/rcar_du_drv.c index 644db36..0f251dc 100644 > --- a/drivers/gpu/drm/rcar-du/rcar_du_drv.c > +++ b/drivers/gpu/drm/rcar-du/rcar_du_drv.c > @@ -361,14 +361,7 @@ static int rcar_du_probe(struct platform_device *pdev) > if (ret) > goto error; > > - mutex_lock(&ddev->mode_config.mutex); > - drm_for_each_connector(connector, ddev) { > - ret = drm_connector_register(connector); > - if (ret < 0) > - break; > - } > - mutex_unlock(&ddev->mode_config.mutex); > - > + ret = drm_connector_register_all(ddev); > if (ret < 0) > goto error;
diff --git a/drivers/gpu/drm/rcar-du/rcar_du_drv.c b/drivers/gpu/drm/rcar-du/rcar_du_drv.c index 644db36..0f251dc 100644 --- a/drivers/gpu/drm/rcar-du/rcar_du_drv.c +++ b/drivers/gpu/drm/rcar-du/rcar_du_drv.c @@ -361,14 +361,7 @@ static int rcar_du_probe(struct platform_device *pdev) if (ret) goto error; - mutex_lock(&ddev->mode_config.mutex); - drm_for_each_connector(connector, ddev) { - ret = drm_connector_register(connector); - if (ret < 0) - break; - } - mutex_unlock(&ddev->mode_config.mutex); - + ret = drm_connector_register_all(ddev); if (ret < 0) goto error;
Now when generic drm_connector_register_all() helper exists we may safely substiture with it driver-specific implementation of connectors plugging in sysfs. Signed-off-by: Alexey Brodkin <abrodkin@synopsys.com> Cc: Daniel Vetter <daniel@ffwll.ch> Cc: David Airlie <airlied@linux.ie> Cc: Laurent Pinchart <laurent.pinchart@ideasonboard.com> Cc: linux-renesas-soc@vger.kernel.org --- No changes v1 -> v2. drivers/gpu/drm/rcar-du/rcar_du_drv.c | 9 +-------- 1 file changed, 1 insertion(+), 8 deletions(-)