| Message ID | 1466531574-3096-1-git-send-email-ben.dooks@codethink.co.uk (mailing list archive) |
|---|---|
| State | Accepted |
| Delegated to: | Geert Uytterhoeven |
| Headers | show |
On Tue, Jun 21, 2016 at 7:52 PM, Ben Dooks <ben.dooks@codethink.co.uk> wrote: > The usbhs_write32 function is not used outside of the rcar3.c > file, so fix the following sparse warning by making it static: > > drivers/usb/renesas_usbhs/rcar3.c:26:6: warning: symbol 'usbhs_write32' was not declared. Should it be static? > > Signed-off-by: Ben Dooks <ben.dooks@codethink.co.uk> > --- > Cc: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com> > Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org> > Cc: linux-usb@vger.kernel.org > Cc: linux-renesas-soc@vger.kernel.org > Cc: linux-arm-kernel@lists.infradead.org > --- > drivers/usb/renesas_usbhs/rcar3.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/usb/renesas_usbhs/rcar3.c b/drivers/usb/renesas_usbhs/rcar3.c > index 38b01f2..1d70add 100644 > --- a/drivers/usb/renesas_usbhs/rcar3.c > +++ b/drivers/usb/renesas_usbhs/rcar3.c > @@ -23,7 +23,7 @@ > #define UGCTRL2_RESERVED_3 0x00000001 /* bit[3:0] should be B'0001 */ > #define UGCTRL2_USB0SEL_OTG 0x00000030 > > -void usbhs_write32(struct usbhs_priv *priv, u32 reg, u32 data) > +static void usbhs_write32(struct usbhs_priv *priv, u32 reg, u32 data) > { > iowrite32(data, priv->base + reg); > } > -- > 2.8.1 static inline ?
Hi, Mathieu Malaterre <mathieu.malaterre@gmail.com> writes: > On Tue, Jun 21, 2016 at 7:52 PM, Ben Dooks <ben.dooks@codethink.co.uk> wrote: >> The usbhs_write32 function is not used outside of the rcar3.c >> file, so fix the following sparse warning by making it static: >> >> drivers/usb/renesas_usbhs/rcar3.c:26:6: warning: symbol 'usbhs_write32' was not declared. Should it be static? >> >> Signed-off-by: Ben Dooks <ben.dooks@codethink.co.uk> >> --- >> Cc: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com> >> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org> >> Cc: linux-usb@vger.kernel.org >> Cc: linux-renesas-soc@vger.kernel.org >> Cc: linux-arm-kernel@lists.infradead.org >> --- >> drivers/usb/renesas_usbhs/rcar3.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/drivers/usb/renesas_usbhs/rcar3.c b/drivers/usb/renesas_usbhs/rcar3.c >> index 38b01f2..1d70add 100644 >> --- a/drivers/usb/renesas_usbhs/rcar3.c >> +++ b/drivers/usb/renesas_usbhs/rcar3.c >> @@ -23,7 +23,7 @@ >> #define UGCTRL2_RESERVED_3 0x00000001 /* bit[3:0] should be B'0001 */ >> #define UGCTRL2_USB0SEL_OTG 0x00000030 >> >> -void usbhs_write32(struct usbhs_priv *priv, u32 reg, u32 data) >> +static void usbhs_write32(struct usbhs_priv *priv, u32 reg, u32 data) >> { >> iowrite32(data, priv->base + reg); >> } >> -- >> 2.8.1 > > static inline ? why? compiler can make that choice
Hi, > From: Ben Dooks > Sent: Wednesday, June 22, 2016 2:53 AM > > The usbhs_write32 function is not used outside of the rcar3.c > file, so fix the following sparse warning by making it static: > > drivers/usb/renesas_usbhs/rcar3.c:26:6: warning: symbol 'usbhs_write32' was not declared. Should it be static? > > Signed-off-by: Ben Dooks <ben.dooks@codethink.co.uk> Thank you for the patch. Acked-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com> Best regards, Yoshihiro Shimoda > --- > Cc: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com> > Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org> > Cc: linux-usb@vger.kernel.org > Cc: linux-renesas-soc@vger.kernel.org > Cc: linux-arm-kernel@lists.infradead.org > --- > drivers/usb/renesas_usbhs/rcar3.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/usb/renesas_usbhs/rcar3.c b/drivers/usb/renesas_usbhs/rcar3.c > index 38b01f2..1d70add 100644 > --- a/drivers/usb/renesas_usbhs/rcar3.c > +++ b/drivers/usb/renesas_usbhs/rcar3.c > @@ -23,7 +23,7 @@ > #define UGCTRL2_RESERVED_3 0x00000001 /* bit[3:0] should be B'0001 */ > #define UGCTRL2_USB0SEL_OTG 0x00000030 > > -void usbhs_write32(struct usbhs_priv *priv, u32 reg, u32 data) > +static void usbhs_write32(struct usbhs_priv *priv, u32 reg, u32 data) > { > iowrite32(data, priv->base + reg); > } > -- > 2.8.1
diff --git a/drivers/usb/renesas_usbhs/rcar3.c b/drivers/usb/renesas_usbhs/rcar3.c index 38b01f2..1d70add 100644 --- a/drivers/usb/renesas_usbhs/rcar3.c +++ b/drivers/usb/renesas_usbhs/rcar3.c @@ -23,7 +23,7 @@ #define UGCTRL2_RESERVED_3 0x00000001 /* bit[3:0] should be B'0001 */ #define UGCTRL2_USB0SEL_OTG 0x00000030 -void usbhs_write32(struct usbhs_priv *priv, u32 reg, u32 data) +static void usbhs_write32(struct usbhs_priv *priv, u32 reg, u32 data) { iowrite32(data, priv->base + reg); }
The usbhs_write32 function is not used outside of the rcar3.c file, so fix the following sparse warning by making it static: drivers/usb/renesas_usbhs/rcar3.c:26:6: warning: symbol 'usbhs_write32' was not declared. Should it be static? Signed-off-by: Ben Dooks <ben.dooks@codethink.co.uk> --- Cc: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org> Cc: linux-usb@vger.kernel.org Cc: linux-renesas-soc@vger.kernel.org Cc: linux-arm-kernel@lists.infradead.org --- drivers/usb/renesas_usbhs/rcar3.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)