From patchwork Thu Oct 20 04:19:19 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Yoshihiro Shimoda X-Patchwork-Id: 9385905 X-Patchwork-Delegate: geert@linux-m68k.org Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 7F8E860487 for ; Thu, 20 Oct 2016 04:20:46 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 751C228B42 for ; Thu, 20 Oct 2016 04:20:46 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 64D5128FF0; Thu, 20 Oct 2016 04:20:46 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 87D1E28B42 for ; Thu, 20 Oct 2016 04:20:45 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753640AbcJTEUn (ORCPT ); Thu, 20 Oct 2016 00:20:43 -0400 Received: from relmlor1.renesas.com ([210.160.252.171]:36881 "EHLO relmlie4.idc.renesas.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751441AbcJTEUl (ORCPT ); Thu, 20 Oct 2016 00:20:41 -0400 Received: from unknown (HELO relmlir1.idc.renesas.com) ([10.200.68.151]) by relmlie4.idc.renesas.com with ESMTP; 20 Oct 2016 13:20:34 +0900 Received: from relmlac1.idc.renesas.com (relmlac1.idc.renesas.com [10.200.69.21]) by relmlir1.idc.renesas.com (Postfix) with ESMTP id E3A6B4D2FE; Thu, 20 Oct 2016 13:20:33 +0900 (JST) Received: by relmlac1.idc.renesas.com (Postfix, from userid 0) id D858580030; Thu, 20 Oct 2016 13:20:33 +0900 (JST) Received: from relmlac1.idc.renesas.com (localhost [127.0.0.1]) by relmlac1.idc.renesas.com (Postfix) with ESMTP id D34E28002F; Thu, 20 Oct 2016 13:20:33 +0900 (JST) Received: from relmlii2.idc.renesas.com [10.200.68.66] by relmlac1.idc.renesas.com with ESMTP id PAA10040; Thu, 20 Oct 2016 13:20:33 +0900 X-IronPort-AV: E=Sophos;i="5.31,517,1473087600"; d="scan'";a="223399376" Received: from mail-hk2apc01lp0207.outbound.protection.outlook.com (HELO APC01-HK2-obe.outbound.protection.outlook.com) ([65.55.88.207]) by relmlii2.idc.renesas.com with ESMTP/TLS/AES256-SHA; 20 Oct 2016 13:20:33 +0900 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=renesasgroup.onmicrosoft.com; s=selector1-renesas-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=DrU8ZOvxESqObJshP8Au+NBsiN82+vPL/zxj0l6HBX4=; b=G3o5cal1AJddUeLC6sUKCt1DhuGgLxsqBgN3+wCIvLwAZI59cDVaONpxEvMIzrBMJlUVcGv7rQed9KT1jVRVr2VmHNL+21eLG+R9+W7PpRP5R1EvJa3Dq0A0DVN5/JMbZB2GKleOnBn1SNP/tg6ccfKZO7RFwglOJMC6Tpm1j44= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=<>; Received: from localhost.localdomain (211.11.155.144) by HK2PR06MB0548.apcprd06.prod.outlook.com (10.161.183.153) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P384) id 15.1.659.11; Thu, 20 Oct 2016 04:20:31 +0000 From: Yoshihiro Shimoda To: CC: , , , , Yoshihiro Shimoda Subject: [PATCH] usb: renesas_usbhs: add wait after initialization for R-Car Gen3 Date: Thu, 20 Oct 2016 13:19:19 +0900 Message-ID: <1476937159-5079-1-git-send-email-yoshihiro.shimoda.uh@renesas.com> X-Mailer: git-send-email 1.9.1 MIME-Version: 1.0 X-Originating-IP: [211.11.155.144] X-ClientProxiedBy: OS2PR01CA0014.jpnprd01.prod.outlook.com (10.161.74.152) To HK2PR06MB0548.apcprd06.prod.outlook.com (10.161.183.153) X-MS-Office365-Filtering-Correlation-Id: 52377620-198c-4b4c-1454-08d3f8a06eba X-Microsoft-Exchange-Diagnostics: 1; HK2PR06MB0548; 2:lRg384TSYnH8jHAxkVLFNGtw/dY/ZnHu0daK2/28oIIVTYisgL8yAgPvowKjEr1uyyUOPQcxCtiYrtIfO4TOTPjYXmdUiqs/7BvMx8bvB9+ldX+vNwYWQk6iF8u7g8FrjCfqrPdhNhRLLWS41S7tYGK9Uy4glGC8DIy/IVESET0ru5y+houvTXq2+ey3+zKi1mYYiX4HRHQULveb9hQCFg==; 3:hiKcd6tkuXilHH7FQ5xzK98+T3XFQhJifLKNkzamgT8rzM1ejsEPbRteTd92rk1t/2Cnnr+3gEiRBGyhBiiD7lMqL+Ax984dP6Y0wRCaruuDwE8vove284Jm9yA+Zf0iiuMHXmvoqWgKnEOJPFG9zA== X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:HK2PR06MB0548; X-Microsoft-Exchange-Diagnostics: 1; HK2PR06MB0548; 25:TJoIvC4xf3HqvI/SVzHdJbevTTnDKV0UU9J7vaM9O3h6UaY1y4Kun4fTKUsLgaBHjNiUzwgiRnYGS/IpgtQMDYkOeE1MAMwxqi1iEh7tLGLol+c20WqN7fXx2X1J00lt3spknaUmzyRZFxj46JAB2/UFgJBkLTY3zpjYjgj1MrPXmi9GLsWyWbx1ZqHgpHXQT4pyxZG1llPtqtQTM2joHSdkcH8Pu74cAuHLL/9m0xMYUL11sMdcVNNsWrET66Uz3hU18NrQ8M0ituxT+QgcO52bs7XEioOYS2tSu3l+DTHRmwxM72esV3llNwdoOtBQI6hFiAHUCUsXyFVtkRY961MHLUIo2LZhb7d/rAhDUKwA7uhgwcFP7OSV0czbLc1LpQJxdQGakyL/MKJai+7EPQt2iv67a9ZUiFs7fK2CZF3xA1Wp0r2rGs0074bjkE5AuDha2YQuA8M1mT7lQ1dKLGb4VVGrRbg0Mu7LhPUSdCudFWjS4NC4eyUGecNQf7LB22+ar0dmKMNtsfu2ewTgdH7aZYXDj2/jnxbi7QAuboP3EuhLNBX89Vz8/UNJHlUVdb4qbOQDuf9qrL8C4/TGULIEM+b0hOeP7oAdSYbeSQ/50P/6QBluZ5pbgM7xAZtti0BbhD1NIJaS4FqmxryUCnPWvBK3XgJrv3B0g6Z3bodYBAj2G32lHz76UkkInYsaz0tOKhM8XBkkJ0CyrZBbGuxJ5TCTBks/43DO3gRtZutKWX++RsecOd4lurAxkMzH6PChDTegRUIplCmhVCCCqg== X-Microsoft-Exchange-Diagnostics: 1; HK2PR06MB0548; 31:eubIpbpL37HGqjJw0Zcf/gpEqKg6m95HA1ZCOPP8S8ocX60RzAoyitLCVwm6v2rKz06VWog35w5i2aGiSpuV9e49d0nSRQyIY2JFF8abOOtACY3xPinfDT0VgZpSYpjwVIuRvs8CgMywjlsgZXimM1h07LtBW1k2Z55nxjLz/VErLLIgGjFcz0lID5dnvFlkyu8COrxKN7RNhdzC35+xd/B5ApK/rW0Ii7snWVS8EC3Vfah0pKR148WEt3jE56uW1gE5Lo/GzQ5gj5iTl2gmDA==; 20:VLT0YXx+izLSRWql0tP7K8kqXXA8SPAofTD/KgP4hpIdwz5v5B09kXFw7e/qNXym4l8REXqnETpRmFDEEsSz77v2WNRdunGdDznNJb8Fa60bF7dJGX7eNLE7pJKMHW7lSs8gHxqbjG3iuYqjg2j/WB/TFAh1B6It328/WSTLA2myzN7xYDDT+RR9B3GdLF9j4b9N9fmwYIat3B4tKsIc199hvXHMiG1e2gZJKh3KcXd6iUXyBfeZ0X4H5j3hyhjEIZv3V+iPSs+XT0sTHoUQHCD4kjZfVThpKJDwvA627LhtEibzKzwc7oQtStlsYY5iMiiFzvI1ea0+ay+AI+6+YbAbYA/jZtJMA/AWleIGoWjtz0035iPjQCQVkk50IptVinMynjerFIhnY/moX3zwOvpTWzXa/63xdpTyt3ow5FFrxEB8bkUW0KDYuIsD0SfAS5S7Rn7Haq1tbU4RYNz5Q0i1tjb/Gn+7tGH+kWUiKb0cZw+MUJDBG2vdBGjAEf9L X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(9452136761055); X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(6040176)(601004)(2401047)(8121501046)(5005006)(3002001)(10201501046)(6055026); SRVR:HK2PR06MB0548; BCL:0; PCL:0; RULEID:; SRVR:HK2PR06MB0548; X-Microsoft-Exchange-Diagnostics: 1; HK2PR06MB0548; 4:xJ7TmnQ5jhmBDgaGcsK5TXalxY+RTZgPHv9zSNiMjnF9YO0z86MMJBucndp7xLI97e3Tqx9coZ5YgjNATzNtm/CwtEOfbXIVP+X8yT/m8Uuo1kG9XOa7tt9Ksxr/wQDGGSZ5aLla3vWwztmsM5IiWkKzJhIjmUpSxW9bjWWDx1O+X+tT/htV8NcQ8/r433kxJsJydnZ8B03jFL8ZT0rZNTWVYxjXTZo5VFr5kDWgz4KtJDO4ET5uFGG3WMEcocqepwp+wCEdflAaQo5GX7NMQyGbsruMH3jpsXbKZFe59NMMN+dYczKsiW/RjK7sBC5Rt1QfwbXxqAFPXdqoaaQs8lq+Hz4rtKDuvGXe9K1DBDM5xDOMc21rW45wwGROGIgTVZzB7WEdAtss39tq3C5U19+PFlW6m+DXTfAs2HNaSAJxft6a0JDFflbr3zRvHX7x/3pEjcTPY2URkr7Eab66HA== X-Forefront-PRVS: 01018CB5B3 X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10019020)(4630300001)(6009001)(6069001)(7916002)(189002)(199003)(2906002)(77096005)(2351001)(78352004)(110136003)(5660300001)(3846002)(6116002)(6666003)(66066001)(68736007)(229853001)(101416001)(36756003)(42882006)(6916009)(7736002)(47776003)(305945005)(92566002)(19580405001)(4001430100002)(48376002)(50466002)(19580395003)(42186005)(4326007)(7846002)(50986999)(81156014)(81166006)(8676002)(50226002)(107886002)(575784001)(5003940100001)(106356001)(105586002)(189998001)(586003)(33646002)(97736004); DIR:OUT; SFP:1102; SCL:1; SRVR:HK2PR06MB0548; H:localhost.localdomain; FPR:; SPF:None; PTR:InfoNoRecords; MX:0; A:0; LANG:en; X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; HK2PR06MB0548; 23:fFYsZAeBQNyg43hWOOyL2vislA7fTdiNp9TL2q2dj?= =?us-ascii?Q?TNgvVkTTg6FvhKsb4wUNWQtgJ0wJSTqDrOT1xSMACQuFrqtvth38SpfIH67e?= =?us-ascii?Q?DdBMp9L79WJ94ZbfhfW+CdmdtdkwNJ7AeSoPtKyUiocQcnhQLsY9CDsIwbsY?= =?us-ascii?Q?OtITbAMICpNC8DLM0eLyzw7xJxZQs8GpIAtRKfwkDu8OPZWuYnxQa3+goC8D?= =?us-ascii?Q?XbvkwPJkf879ydMmp9lCKoBaF+U4hHQ9n3fMK5y99FjiBZyAjHGX7Kr9NWHI?= =?us-ascii?Q?3d9fXo7mSenWJ+Hi2cPWKzUGEHeCg95qMuqfFD7OyvhrsND1tqE+9l6W95Ut?= =?us-ascii?Q?88MAUJ3+NcBYel+dq+fZD5kMBXckhp3R6VXOOXQpl1CB7eydUSgEkChgILvQ?= =?us-ascii?Q?Tic0fPljaLvJdh/7QfzYYHxiHezcneBfCK71aKf1qenWJRjpjSY81vAaBF+z?= =?us-ascii?Q?pZh9pW7qMd0rKbRjUJLkSbs2a3ZAS3BnYOtg6t1v/HOhViv/FVi7nT0Xi4Rf?= =?us-ascii?Q?S4sXiqFt1MDwwOz+i9j6BirheCyBi4/a0fmrmntcF306fbuMr9/SfaDr2VKl?= =?us-ascii?Q?f/A1YAWc7CYG6z2tC00aoz5zkKUnQkpgRLzLWMIeMRNV0cRXXmx6+qXBUuBd?= =?us-ascii?Q?viISzjptS8j+3tgNP+ItI8dfQLZDYRCmLUp1/VUYH7l1v+xQuCCRAcDQUw5D?= =?us-ascii?Q?+NS5TrexGAlbzGQTdLkViU8vr7xil3mqah8D8WUGdnWy5pxN32PyonrFWc9q?= =?us-ascii?Q?b+dqcv8mJtACB1ygp2UHEM/TYAVpTaXCJBzkSaIHf5zVnF2QC3fn3hs76IUy?= =?us-ascii?Q?tfFpui5qIhkopXYNGkYhgo9WdoQlBhVhW+S7UUlAjii+59tQ+TARpyBKlJz4?= =?us-ascii?Q?oAnVJ721f80rSuADorC647CPPt3NXZwumaVWWZXkCmNfo8PN++7sgGe+jn9u?= =?us-ascii?Q?rpk5mHkIQXt07LBiLmnLWFlwvK1RMiRF+BdeW5VGVByNR/nsKKe3XyGlV3qN?= =?us-ascii?Q?8R8Zx1zQPdhuLo87DUNBh5ky/OdTKxmtvDgSv4lQtOIueJB9us11uToq6iCl?= =?us-ascii?Q?1JbKulGomYNS5uQHirS9ngO9QMrgpMaV/ee5lidVXQLTCjQcos4kV2wEv9nS?= =?us-ascii?Q?HG/XB3h8TQr9vzVjlwPc30+DjQ1JZFcVupQ9Cb3L3FGvZ3tlE334lrP+UGun?= =?us-ascii?Q?HXxsPn6u45DvOKTiHqU4Gyz3gtj1kj4pR7e?= X-Microsoft-Exchange-Diagnostics: 1; HK2PR06MB0548; 6:Nl4EmpkI0RS6GTPGlyTwYQAdiCh9+iQvErtQyhiHk3n6RMb8XCEKVrycS6zlBJwdOghqA3UaMdxlqHHtNgZLVHHMLr6CQmRvEwUppAUXD2GJq+GTIlLgrXQwyjPr9g+PaERR+OspQ1w2Mt3JxNRdpVGFinMZmaUo1YX5KBMVmwyL2+Prn5cQLMcqfk+IhOpSAV7IVo3FMhkSdZiJoSQKoXsZBnl61wpLscWumlJjUmvGBmo4WXhdK7MKw868LQ4Ow+HJRcxxsab5T73dLegH8QYt4GYngnbwF6LPZY8PJ64HrteyEtPkruM9XikSHGzEs2QozbKgRTmTK9z4/v1SCw==; 5:wysULsY8FxN9hE8AwJjnM0VB/Zez2OHqkM03QzEG1Qrs7KHgi8XDRMkdA3XbD2EUZpUxnV6b1sLNBycKXqn0txH/vMTc4iqNyepq/+gnHiZXk+fkRTbBEWIooLfoJLMpLPm4CZrpGcUlSNwuKIF+lA==; 24:bCgQO0KEXdnKbi292zh2Oiodk8anq2VKOxJa4FYehAb7YA22/C/01767WKnOYKM5vckiFL4xT7OxS9yXWZvcfrGzWrL+QFfzOG+rzDscmdo= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1; HK2PR06MB0548; 7:PjBB9uWT7Sf11JjysrajWsfGbkQ2htbSnZyPDdYL+RNdmjJuKspOqJqid+Wo2kltbAzozflMVt07YqKHS1mtw2gljo5MRVNdLPJaZ/hBg3W0nqunC+zUhGaAXG/YmNgjLHH3TAeUQ8u+0ujNCmumAoTK7gJ4R4zXXoke7OBX+cexfzwUg8xZILCymGIgXFc8V9rnnhCeMdsKUfbEIJh7P7j6WhNKN+RQDuMxY6t2NV59Sdc493C0fsEt6l2tJSQtfvtVyxSP+l6SP0MxIX5gnAfF7nVwoIF8pdp6lDj8enC0zm3W6dNwg0x80a9JARLQQznIXpy5hbC87jVcrX7YaUyISdwtZB6p9M0dY8wfEJE=; 20:fXvSL/PYZ2ddzbxa5E6wFk2pwGIYFKVceXHbwmeobuLC2QzZ3/xywNK+lGyHdxTVENTeDQRMFLaHzbsO4cJXXqv23OcSlaE0XhI5tOHlDuoroNxMFrFOOg43MV2JtoiPAuDrj5mlboS4b9Wh6V77k4eHQ0gjEG6jwMl7fpFhf30= X-OriginatorOrg: renesas.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Oct 2016 04:20:31.9531 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: HK2PR06MB0548 Sender: linux-renesas-soc-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-renesas-soc@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Since the controller on R-Car Gen3 doesn't have any status registers to detect initialization (LPSTS.SUSPM = 1) and the initialization needs up to 45 usec, this patch adds wait after the initialization. Otherwise, writing other registers (e.g. INTENB0) will fail. Fixes: de18757e272d ("usb: renesas_usbhs: add R-Car Gen3 power control") Cc: # v4.6+ Signed-off-by: Yoshihiro Shimoda --- This patch is based on the latest Felipe's usb.git / testing/fixes branch (commit id = a1aa8cf6471b17c0fa7132ea5eeef0ae07ca07cd). drivers/usb/renesas_usbhs/rcar3.c | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/drivers/usb/renesas_usbhs/rcar3.c b/drivers/usb/renesas_usbhs/rcar3.c index 1d70add..d544b33 100644 --- a/drivers/usb/renesas_usbhs/rcar3.c +++ b/drivers/usb/renesas_usbhs/rcar3.c @@ -9,6 +9,7 @@ * */ +#include #include #include "common.h" #include "rcar3.h" @@ -35,10 +36,13 @@ static int usbhs_rcar3_power_ctrl(struct platform_device *pdev, usbhs_write32(priv, UGCTRL2, UGCTRL2_RESERVED_3 | UGCTRL2_USB0SEL_OTG); - if (enable) + if (enable) { usbhs_bset(priv, LPSTS, LPSTS_SUSPM, LPSTS_SUSPM); - else + /* The controller on R-Car Gen3 needs to wait up to 45 usec */ + udelay(45); + } else { usbhs_bset(priv, LPSTS, LPSTS_SUSPM, 0); + } return 0; }