| Message ID | 1477491249-2976-6-git-send-email-ulrich.hecht+renesas@gmail.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | ffaecb08c2cb64eba01cf35e2234c0a2abb547ad |
| Delegated to: | Geert Uytterhoeven |
| Headers | show |
On Wed, Oct 26, 2016 at 4:14 PM, Ulrich Hecht <ulrich.hecht+renesas@gmail.com> wrote: > Signed-off-by: Ulrich Hecht <ulrich.hecht+renesas@gmail.com> > Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be> > --- > arch/arm64/boot/dts/renesas/r8a7796-salvator-x.dts | 12 ++++++++++++ > 1 file changed, 12 insertions(+) > > diff --git a/arch/arm64/boot/dts/renesas/r8a7796-salvator-x.dts b/arch/arm64/boot/dts/renesas/r8a7796-salvator-x.dts > index 8255c56..e48de7c 100644 > --- a/arch/arm64/boot/dts/renesas/r8a7796-salvator-x.dts > +++ b/arch/arm64/boot/dts/renesas/r8a7796-salvator-x.dts > @@ -111,6 +111,11 @@ > function = "scif_clk"; > }; > > + i2c2_pins: i2c2 { > + groups = "i2c2_a"; > + function = "i2c2"; > + }; > + > sdhi0_pins: sd0 { > groups = "sdhi0_data4", "sdhi0_ctrl"; > function = "sdhi0"; BTW, do we have a policy about (alphabetical) ordering? Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds
On Mon, Nov 07, 2016 at 07:53:04PM +0100, Geert Uytterhoeven wrote: > On Wed, Oct 26, 2016 at 4:14 PM, Ulrich Hecht > <ulrich.hecht+renesas@gmail.com> wrote: > > Signed-off-by: Ulrich Hecht <ulrich.hecht+renesas@gmail.com> > > Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be> > > --- > > arch/arm64/boot/dts/renesas/r8a7796-salvator-x.dts | 12 ++++++++++++ > > 1 file changed, 12 insertions(+) > > > > diff --git a/arch/arm64/boot/dts/renesas/r8a7796-salvator-x.dts b/arch/arm64/boot/dts/renesas/r8a7796-salvator-x.dts > > index 8255c56..e48de7c 100644 > > --- a/arch/arm64/boot/dts/renesas/r8a7796-salvator-x.dts > > +++ b/arch/arm64/boot/dts/renesas/r8a7796-salvator-x.dts > > @@ -111,6 +111,11 @@ > > function = "scif_clk"; > > }; > > > > + i2c2_pins: i2c2 { > > + groups = "i2c2_a"; > > + function = "i2c2"; > > + }; > > + > > sdhi0_pins: sd0 { > > groups = "sdhi0_data4", "sdhi0_ctrl"; > > function = "sdhi0"; > > BTW, do we have a policy about (alphabetical) ordering? FWIW I think we should aim to have notes sorted by a) base address and b) alphabetically.
Hi Simon, On Tue, Nov 8, 2016 at 11:02 AM, Simon Horman <horms@verge.net.au> wrote: > On Mon, Nov 07, 2016 at 07:53:04PM +0100, Geert Uytterhoeven wrote: >> On Wed, Oct 26, 2016 at 4:14 PM, Ulrich Hecht >> <ulrich.hecht+renesas@gmail.com> wrote: >> > Signed-off-by: Ulrich Hecht <ulrich.hecht+renesas@gmail.com> >> > Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be> >> > --- >> > arch/arm64/boot/dts/renesas/r8a7796-salvator-x.dts | 12 ++++++++++++ >> > 1 file changed, 12 insertions(+) >> > >> > diff --git a/arch/arm64/boot/dts/renesas/r8a7796-salvator-x.dts b/arch/arm64/boot/dts/renesas/r8a7796-salvator-x.dts >> > index 8255c56..e48de7c 100644 >> > --- a/arch/arm64/boot/dts/renesas/r8a7796-salvator-x.dts >> > +++ b/arch/arm64/boot/dts/renesas/r8a7796-salvator-x.dts >> > @@ -111,6 +111,11 @@ >> > function = "scif_clk"; >> > }; >> > >> > + i2c2_pins: i2c2 { >> > + groups = "i2c2_a"; >> > + function = "i2c2"; >> > + }; >> > + >> > sdhi0_pins: sd0 { >> > groups = "sdhi0_data4", "sdhi0_ctrl"; >> > function = "sdhi0"; >> >> BTW, do we have a policy about (alphabetical) ordering? > > FWIW I think we should aim to have notes sorted by a) base address and > b) alphabetically. I think "nodes" comes first, before "notes" ;-) Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds
On Tue, Nov 08, 2016 at 11:07:58AM +0100, Geert Uytterhoeven wrote: > Hi Simon, > > On Tue, Nov 8, 2016 at 11:02 AM, Simon Horman <horms@verge.net.au> wrote: > > On Mon, Nov 07, 2016 at 07:53:04PM +0100, Geert Uytterhoeven wrote: > >> On Wed, Oct 26, 2016 at 4:14 PM, Ulrich Hecht > >> <ulrich.hecht+renesas@gmail.com> wrote: > >> > Signed-off-by: Ulrich Hecht <ulrich.hecht+renesas@gmail.com> > >> > Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be> > >> > --- > >> > arch/arm64/boot/dts/renesas/r8a7796-salvator-x.dts | 12 ++++++++++++ > >> > 1 file changed, 12 insertions(+) > >> > > >> > diff --git a/arch/arm64/boot/dts/renesas/r8a7796-salvator-x.dts b/arch/arm64/boot/dts/renesas/r8a7796-salvator-x.dts > >> > index 8255c56..e48de7c 100644 > >> > --- a/arch/arm64/boot/dts/renesas/r8a7796-salvator-x.dts > >> > +++ b/arch/arm64/boot/dts/renesas/r8a7796-salvator-x.dts > >> > @@ -111,6 +111,11 @@ > >> > function = "scif_clk"; > >> > }; > >> > > >> > + i2c2_pins: i2c2 { > >> > + groups = "i2c2_a"; > >> > + function = "i2c2"; > >> > + }; > >> > + > >> > sdhi0_pins: sd0 { > >> > groups = "sdhi0_data4", "sdhi0_ctrl"; > >> > function = "sdhi0"; > >> > >> BTW, do we have a policy about (alphabetical) ordering? > > > > FWIW I think we should aim to have notes sorted by a) base address and > > b) alphabetically. > > I think "nodes" comes first, before "notes" ;-) Yes, that's the spirit.
diff --git a/arch/arm64/boot/dts/renesas/r8a7796-salvator-x.dts b/arch/arm64/boot/dts/renesas/r8a7796-salvator-x.dts index 8255c56..e48de7c 100644 --- a/arch/arm64/boot/dts/renesas/r8a7796-salvator-x.dts +++ b/arch/arm64/boot/dts/renesas/r8a7796-salvator-x.dts @@ -111,6 +111,11 @@ function = "scif_clk"; }; + i2c2_pins: i2c2 { + groups = "i2c2_a"; + function = "i2c2"; + }; + sdhi0_pins: sd0 { groups = "sdhi0_data4", "sdhi0_ctrl"; function = "sdhi0"; @@ -209,6 +214,13 @@ status = "okay"; }; +&i2c2 { + pinctrl-0 = <&i2c2_pins>; + pinctrl-names = "default"; + + status = "okay"; +}; + &wdt0 { timeout-sec = <60>; status = "okay";