diff mbox

[4/9] arm64: dts: m3ulcb: enable GPIO leds

Message ID 1478196451-1298-1-git-send-email-vladimir.barinov@cogentembedded.com (mailing list archive)
State Accepted
Commit 811a0d07e68ed3bb576e2f193f2c9831bb25c04e
Headers show

Commit Message

Vladimir Barinov Nov. 3, 2016, 6:07 p.m. UTC
This supports GPIO leds on M3ULCB board

Signed-off-by: Vladimir Barinov <vladimir.barinov@cogentembedded.com>
---
 arch/arm64/boot/dts/renesas/r8a7796-m3ulcb.dts | 13 +++++++++++++
 1 file changed, 13 insertions(+)

Comments

Simon Horman Nov. 7, 2016, 12:57 p.m. UTC | #1
On Thu, Nov 03, 2016 at 09:07:31PM +0300, Vladimir Barinov wrote:
> This supports GPIO leds on M3ULCB board

Are GPIO leds and keys also present on the H3ULCB.
If so could you consider sending patches to enable them?

> Signed-off-by: Vladimir Barinov <vladimir.barinov@cogentembedded.com>
> ---
>  arch/arm64/boot/dts/renesas/r8a7796-m3ulcb.dts | 13 +++++++++++++
>  1 file changed, 13 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/renesas/r8a7796-m3ulcb.dts b/arch/arm64/boot/dts/renesas/r8a7796-m3ulcb.dts
> index fb694b8..3329f78 100644
> --- a/arch/arm64/boot/dts/renesas/r8a7796-m3ulcb.dts
> +++ b/arch/arm64/boot/dts/renesas/r8a7796-m3ulcb.dts
> @@ -31,6 +31,17 @@
>  		/* first 128MB is reserved for secure area. */
>  		reg = <0x0 0x48000000 0x0 0x38000000>;
>  	};
> +
> +	leds {
> +		compatible = "gpio-leds";
> +
> +		led5 {
> +			gpios = <&gpio6 12 GPIO_ACTIVE_HIGH>;
> +		};
> +		led6 {
> +			gpios = <&gpio6 13 GPIO_ACTIVE_HIGH>;
> +		};
> +	};
>  };
>  
>  &extal_clk {
> -- 
> 1.9.1
>
Vladimir Barinov Nov. 7, 2016, 1:02 p.m. UTC | #2
Hi Simon,

On 07.11.2016 15:57, Simon Horman wrote:
> On Thu, Nov 03, 2016 at 09:07:31PM +0300, Vladimir Barinov wrote:
>> This supports GPIO leds on M3ULCB board
> Are GPIO leds and keys also present on the H3ULCB.
Yes.
> If so could you consider sending patches to enable them?
H3ULCB already includes GPIO leds and keys support in upstream kernel.

Regards,
Vladimir
>
>> Signed-off-by: Vladimir Barinov <vladimir.barinov@cogentembedded.com>
>> ---
>>   arch/arm64/boot/dts/renesas/r8a7796-m3ulcb.dts | 13 +++++++++++++
>>   1 file changed, 13 insertions(+)
>>
>> diff --git a/arch/arm64/boot/dts/renesas/r8a7796-m3ulcb.dts b/arch/arm64/boot/dts/renesas/r8a7796-m3ulcb.dts
>> index fb694b8..3329f78 100644
>> --- a/arch/arm64/boot/dts/renesas/r8a7796-m3ulcb.dts
>> +++ b/arch/arm64/boot/dts/renesas/r8a7796-m3ulcb.dts
>> @@ -31,6 +31,17 @@
>>   		/* first 128MB is reserved for secure area. */
>>   		reg = <0x0 0x48000000 0x0 0x38000000>;
>>   	};
>> +
>> +	leds {
>> +		compatible = "gpio-leds";
>> +
>> +		led5 {
>> +			gpios = <&gpio6 12 GPIO_ACTIVE_HIGH>;
>> +		};
>> +		led6 {
>> +			gpios = <&gpio6 13 GPIO_ACTIVE_HIGH>;
>> +		};
>> +	};
>>   };
>>   
>>   &extal_clk {
>> -- 
>> 1.9.1
>>
diff mbox

Patch

diff --git a/arch/arm64/boot/dts/renesas/r8a7796-m3ulcb.dts b/arch/arm64/boot/dts/renesas/r8a7796-m3ulcb.dts
index fb694b8..3329f78 100644
--- a/arch/arm64/boot/dts/renesas/r8a7796-m3ulcb.dts
+++ b/arch/arm64/boot/dts/renesas/r8a7796-m3ulcb.dts
@@ -31,6 +31,17 @@ 
 		/* first 128MB is reserved for secure area. */
 		reg = <0x0 0x48000000 0x0 0x38000000>;
 	};
+
+	leds {
+		compatible = "gpio-leds";
+
+		led5 {
+			gpios = <&gpio6 12 GPIO_ACTIVE_HIGH>;
+		};
+		led6 {
+			gpios = <&gpio6 13 GPIO_ACTIVE_HIGH>;
+		};
+	};
 };
 
 &extal_clk {