| Message ID | 1478545627-32280-1-git-send-email-geert+renesas@glider.be (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | dc8ee9dbdba509fb58e23ba79f2e6059fe5d8b3b |
| Headers | show |
Hi Geert-san, > -----Original Message----- > From: Geert Uytterhoeven > Sent: Tuesday, November 08, 2016 4:07 AM > > The parent clock of the HSUSB clock is the HP clock, not the MP clock. > > Fixes: c7bab9f929e51761 ("ARM: shmobile: r8a7794: Add USB clocks to device tree") > Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be> Thank you for the patch. Acked-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com> Best regards, Yoshihiro Shimoda > --- > arch/arm/boot/dts/r8a7794.dtsi | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/arm/boot/dts/r8a7794.dtsi b/arch/arm/boot/dts/r8a7794.dtsi > index 01816ac775a8d177..7d9f0601d3ca8def 100644 > --- a/arch/arm/boot/dts/r8a7794.dtsi > +++ b/arch/arm/boot/dts/r8a7794.dtsi > @@ -1262,7 +1262,7 @@ > mstp7_clks: mstp7_clks@e615014c { > compatible = "renesas,r8a7794-mstp-clocks", "renesas,cpg-mstp-clocks"; > reg = <0 0xe615014c 0 4>, <0 0xe61501c4 0 4>; > - clocks = <&mp_clk>, <&mp_clk>, > + clocks = <&mp_clk>, <&hp_clk>, > <&zs_clk>, <&p_clk>, <&p_clk>, <&zs_clk>, > <&zs_clk>, <&p_clk>, <&p_clk>, <&p_clk>, <&p_clk>, > <&zx_clk>; > -- > 1.9.1
On Tue, Nov 08, 2016 at 12:16:17PM +0000, Yoshihiro Shimoda wrote: > Hi Geert-san, > > > -----Original Message----- > > From: Geert Uytterhoeven > > Sent: Tuesday, November 08, 2016 4:07 AM > > > > The parent clock of the HSUSB clock is the HP clock, not the MP clock. > > > > Fixes: c7bab9f929e51761 ("ARM: shmobile: r8a7794: Add USB clocks to device tree") > > Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be> > > Thank you for the patch. > > Acked-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com> Thanks, I have queued this up.
On Mon, Nov 07, 2016 at 08:07:07PM +0100, Geert Uytterhoeven wrote: > The parent clock of the HSUSB clock is the HP clock, not the MP clock. > > Fixes: c7bab9f929e51761 ("ARM: shmobile: r8a7794: Add USB clocks to device tree") > Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be> Thanks, I have queued this up. I also checked that the correct parent is used on the r8a7790, 1 and 3. HSUSB is not present on the r8a7792. > --- > arch/arm/boot/dts/r8a7794.dtsi | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/arm/boot/dts/r8a7794.dtsi b/arch/arm/boot/dts/r8a7794.dtsi > index 01816ac775a8d177..7d9f0601d3ca8def 100644 > --- a/arch/arm/boot/dts/r8a7794.dtsi > +++ b/arch/arm/boot/dts/r8a7794.dtsi > @@ -1262,7 +1262,7 @@ > mstp7_clks: mstp7_clks@e615014c { > compatible = "renesas,r8a7794-mstp-clocks", "renesas,cpg-mstp-clocks"; > reg = <0 0xe615014c 0 4>, <0 0xe61501c4 0 4>; > - clocks = <&mp_clk>, <&mp_clk>, > + clocks = <&mp_clk>, <&hp_clk>, > <&zs_clk>, <&p_clk>, <&p_clk>, <&zs_clk>, > <&zs_clk>, <&p_clk>, <&p_clk>, <&p_clk>, <&p_clk>, > <&zx_clk>; > -- > 1.9.1 >
diff --git a/arch/arm/boot/dts/r8a7794.dtsi b/arch/arm/boot/dts/r8a7794.dtsi index 01816ac775a8d177..7d9f0601d3ca8def 100644 --- a/arch/arm/boot/dts/r8a7794.dtsi +++ b/arch/arm/boot/dts/r8a7794.dtsi @@ -1262,7 +1262,7 @@ mstp7_clks: mstp7_clks@e615014c { compatible = "renesas,r8a7794-mstp-clocks", "renesas,cpg-mstp-clocks"; reg = <0 0xe615014c 0 4>, <0 0xe61501c4 0 4>; - clocks = <&mp_clk>, <&mp_clk>, + clocks = <&mp_clk>, <&hp_clk>, <&zs_clk>, <&p_clk>, <&p_clk>, <&zs_clk>, <&zs_clk>, <&p_clk>, <&p_clk>, <&p_clk>, <&p_clk>, <&zx_clk>;
The parent clock of the HSUSB clock is the HP clock, not the MP clock. Fixes: c7bab9f929e51761 ("ARM: shmobile: r8a7794: Add USB clocks to device tree") Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be> --- arch/arm/boot/dts/r8a7794.dtsi | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)